From: Kurt Miller <kurt@intricatesoftware.com>
To: u-boot@lists.denx.de
Subject: [PATCH] rockchip: rockpro64: Set cooling levels for pwm-fan
Date: Fri, 29 May 2020 08:42:31 -0400 [thread overview]
Message-ID: <1590756151.9708.47.camel@intricatesoftware.com> (raw)
In-Reply-To: <CALeDE9NwUh56D-uKSSzqcufdnG_TrQzy87bid8t2_5zWj0fJhw@mail.gmail.com>
On Fri, 2020-05-29 at 09:27 +0100, Peter Robinson wrote:
> On Thu, May 28, 2020 at 8:32 PM Kurt Miller <kurt@intricatesoftware.com> wrote:
> >
> >
> > The cooling levels are tuned to the fan that comes with the rockpro64 NAS
> > case. A gpu_thermal zone was not added because having two active cooling
> > maps control one physical fan causes them to compete for the fan speed
> > which results in erratic fan behavior.
> Is there any reason this shouldn't go to the linux kernel first and
> then be synced back to the standard rk3399-rockpro64.dtsi?
Is that a requirement? I do my primary development on OpenBSD and
while I use Linux for work tasks, I don't have available time right
now to push these changes to Linux kernel first.
>
> >
> > Signed-off-by: Kurt Miller <kurt@intricatesoftware.com>
> > ---
> >
> > ?arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 43 +++++++++++++++++++++++
> > ?1 file changed, 43 insertions(+)
> >
> > diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > index deaa3efd39..c0e0396758 100644
> > --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > @@ -13,6 +13,49 @@
> > ????????chosen {
> > ????????????????u-boot,spl-boot-order = "same-as-spl", &sdmmc, &sdhci;
> > ????????};
> > +
> > +???????fan: pwm-fan {
> > +???????????????cooling-levels = <0 40 80 255>;
> > +???????};
> > +};
> > +
> > +&cpu_thermal {
> > +???????trips {
> > +???????????????cpu_warm: cpu_warm {
> > +???????????????????????temperature = <50000>;
> > +???????????????????????hysteresis = <2000>;
> > +???????????????????????type = "active";
> > +???????????????};
> > +
> > +???????????????cpu_med: cpu_med {
> > +???????????????????????temperature = <60000>;
> > +???????????????????????hysteresis = <2000>;
> > +???????????????????????type = "active";
> > +???????????????};
> > +
> > +???????????????cpu_hot: cpu_hot {
> > +???????????????????????temperature = <65000>;
> > +???????????????????????hysteresis = <2000>;
> > +???????????????????????type = "active";
> > +???????????????};
> > +???????};
> > +
> > +???????cooling-maps {
> > +???????????????map2 {
> > +???????????????????????trip = <&cpu_warm>;
> > +???????????????????????cooling-device = <&fan THERMAL_NO_LIMIT 1>;
> > +???????????????};
> > +
> > +???????????????map3 {
> > +???????????????????????trip = <&cpu_med>;
> > +???????????????????????cooling-device = <&fan THERMAL_NO_LIMIT 2>;
> > +???????????????};
> > +
> > +???????????????map4 {
> > +???????????????????????trip = <&cpu_hot>;
> > +???????????????????????cooling-device = <&fan 2 THERMAL_NO_LIMIT>;
> > +???????????????};
> > +???????};
> > ?};
> >
> > ?&vdd_center {
> > --
> > 2.26.2
> >
next prev parent reply other threads:[~2020-05-29 12:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 19:32 [PATCH] rockchip: rockpro64: Set cooling levels for pwm-fan Kurt Miller
2020-05-29 8:27 ` Peter Robinson
2020-05-29 12:42 ` Kurt Miller [this message]
2020-05-29 19:00 ` Simon Glass
2020-06-01 18:29 ` Kurt Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1590756151.9708.47.camel@intricatesoftware.com \
--to=kurt@intricatesoftware.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox