From: Kurt Miller <kurt@intricatesoftware.com>
To: u-boot@lists.denx.de
Subject: [PATCH] rockchip: Add delay after link-training
Date: Mon, 01 Jun 2020 17:18:21 -0400 [thread overview]
Message-ID: <1591046301.9708.74.camel@intricatesoftware.com> (raw)
In-Reply-To: <CAMty3ZDSwPEQvqo2BMJWHz6JqBHiFs+6qgvChU9rzrwtd60HZw@mail.gmail.com>
On Tue, 2020-06-02 at 02:16 +0530, Jagan Teki wrote:
> On Tue, Jun 2, 2020 at 2:00 AM Kurt Miller <kurt@intricatesoftware.com> wrote:
> >
> >
> > On at least the RockPro64, many cards will trip a
> > synchronous abort when first accessing PCIe config space
> > during bus scanning. A delay after link training allows
> > some of these cards to function.
> Can you check does the SoC has external PCIe pwr-pin GPIO?
>
> I did see unstable SSD behavior on rock960 but fixed with this.
> https://github.com/radxa/u-boot/blob/stable-4.4-rockpi4/board/rockchip/evb_rk3399/evb-rk3399.c#L168
The schematic has:
GPIO1_D0/TCPD_VBUS_SOURCE2_d ---L26---->>PCIE_PWR
and?arch/arm/dts/rk3399-rockpro64.dtsi has:
&pinctrl {
? ? ? ? pcie {
? ? ? ? ? ? ? ? pcie_pwr_en: pcie-pwr-en {
????????????????????????rockchip,pins = <1 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>;
????????????????};
????????};
};
Does that answer your question? I'm rather new at this so
I may need more guidance if I miss understood your question.
Thanks,
-Kurt
next prev parent reply other threads:[~2020-06-01 21:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 20:30 [PATCH] rockchip: Add delay after link-training Kurt Miller
2020-06-01 20:46 ` Jagan Teki
2020-06-01 21:18 ` Kurt Miller [this message]
2020-06-02 1:59 ` Kever Yang
2020-06-02 2:23 ` Shawn Lin
2020-06-02 15:12 ` Kurt Miller
2020-06-03 21:17 ` Peter Geis
2020-06-27 12:57 ` Kever Yang
2020-06-30 17:57 ` Kurt Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591046301.9708.74.camel@intricatesoftware.com \
--to=kurt@intricatesoftware.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox