[U-Boot-Users] Re: board.c patch got undone

[U-Boot-Users] Re: board.c patch got undone

[Stephen Williams]

Perhaps this is an even better patch:

===================================================================
RCS file: /cvsroot/u-boot/u-boot/README,v
retrieving revision 1.79
diff -p -u -r1.79 README
--- README      14 Mar 2004 14:09:05 -0000      1.79
+++ README      16 Mar 2004 04:12:44 -0000
@@ -441,8 +441,8 @@ The following options need to be configu
                 (RTS/CTS) and UART's built-in FIFO. Set the number of
                 bytes the interrupt driven input buffer should have.

-               Set to 0 to disable this feature (this is the default).
-               This will also disable hardware handshake.
+               Leave undefined to disable this feature, including
+               disable the buffer and hardware handshake.

  - Console UART Number:
                 CONFIG_UART1_CONSOLE


Stephen Williams wrote:
> 
> It looks like in the last wave of changes, a patch got undone:
> 
> 
> wing % cvs diff -r1.35 board.c
> Index: board.c
> ===================================================================
> RCS file: /cvsroot/u-boot/u-boot/lib_ppc/board.c,v
> retrieving revision 1.35
> retrieving revision 1.36
> diff -r1.35 -r1.36
> 877c877
> < #if CONFIG_SERIAL_SOFTWARE_FIFO
> ---
>  > #ifdef CONFIG_SERIAL_SOFTWARE_FIFO
> 
> 
> The "#if CONFIG_SERIAL_SOFTWARE_FIFO" is the right version,
> if one assumes the documentation is correct that setting
> CONFIG_SERIAL_SOFTWARE_FIFO=0 causes the serial port to become
> insensitive to CTS.
> 
> Perhaps it would be even better to change it to:
> 
> #if defined(CONFIG_SERIAL_SOFTWARE_FIFO) && CONFIG_SOFTWARE_FIFO>0
> ...
> #endif
> 


-- 
Steve Williams                "The woods are lovely, dark and deep.
steve at XXXXXXXXXX           But I have promises to keep,
http://www.XXXXXXXXXX         and lines to code before I sleep,
http://www.picturel.com       And lines to code before I sleep."

[U-Boot-Users] Re: board.c patch got undone

[Wolfgang Denk]

In message <15911-31205@sneakemail.com> you wrote:
> 
> Perhaps this is an even better patch:
...
> > The "#if CONFIG_SERIAL_SOFTWARE_FIFO" is the right version,
> > if one assumes the documentation is correct that setting
> > CONFIG_SERIAL_SOFTWARE_FIFO=0 causes the serial port to become
> > insensitive to CTS.
> > 
> > Perhaps it would be even better to change it to:
> > 
> > #if defined(CONFIG_SERIAL_SOFTWARE_FIFO) && CONFIG_SOFTWARE_FIFO>0
> > ...
> > #endif

Thanks, added.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
If you want strict real-time behavior, run in the real  time  schedu-
ling class.  But there are no seatbelts or airbags;  main(){for(;;);}
can hard hang your system.                          -- Bart Smaalders