public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ravik Hasija <rahasij@linux.microsoft.com>
To: u-boot@lists.denx.de
Subject: [PATCH v4] net: tftp: Add client support for RFC 7440
Date: Thu, 4 Jun 2020 10:51:16 -0700 (MST)	[thread overview]
Message-ID: <1591293076068-0.post@n7.nabble.com> (raw)
In-Reply-To: <CAGi-RU+nyqjQWqouObKjDtmYn+5bsPMjCvKw-VPW8iHDPNWE4w@mail.gmail.com>


On Wed, Jun 3, 2020 at 5:55 AM Ravik Hasija &lt;rahasij at .microsoft&gt;
wrote:
>
> Ramon Fried-4 wrote
> > +                     if (strcmp((char *)pkt + i,  "windowsize") == 0) {
> > For servers that doesnt support windowsize option the above check could
> > result in accessing memory outside of valid range. Please check if
> (i+11)
> > < len before comparing the strings.
> This is the same handling as all other possible configurations,
> following the same code.
> I agree that this needs reworking, but I'll do it in a different patch
> all together.

Yes, the other options need to be fixed as well. However, we should fix
(i+11)<len in this patch itself, and restructure others, and windowsize (if
needed) in a different patch, since the tftpd (commonly used for TFTP
server) does not support windowsize option while it supports other options
(tsize,blksize,timeout etc.), and there is a high chance that the client
code might crash in that case.

&lt;/quote>




--
Sent from: http://u-boot.10912.n7.nabble.com/

      reply	other threads:[~2020-06-04 17:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 19:25 [PATCH v4] net: tftp: Add client support for RFC 7440 Ramon Fried
2020-05-22  0:29 ` rahasij
2020-05-22 19:19   ` Ramon Fried
2020-05-23 17:39 ` Matthias Brugger
2020-05-23 17:59   ` Ramon Fried
2020-06-03  2:54 ` Ravik Hasija
2020-06-04 16:17   ` Ramon Fried
2020-06-04 17:51     ` Ravik Hasija [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1591293076068-0.post@n7.nabble.com \
    --to=rahasij@linux.microsoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox