From: Ye Li <ye.li@nxp.com>
To: u-boot@lists.denx.de
Subject: [EXT] [PATCH 1/1] power: pmic_pca9450: fix PCA9450A I2C address
Date: Mon, 29 Jun 2020 09:51:06 +0000 [thread overview]
Message-ID: <1593424001.29491.3.camel@nxp.com> (raw)
In-Reply-To: <20200629084215.25006-1-sebastien.szymanski@armadeus.com>
On Mon, 2020-06-29 at 10:42 +0200, S?bastien Szymanski wrote:
> Caution: EXT Email
>
> PCA9450A I2C address is 0x25. Fix it.
>
> Signed-off-by: S?bastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
> ?drivers/power/pmic/pmic_pca9450.c | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/pmic/pmic_pca9450.c
> b/drivers/power/pmic/pmic_pca9450.c
> index 67a9090200..c0fb78c4cd 100644
> --- a/drivers/power/pmic/pmic_pca9450.c
> +++ b/drivers/power/pmic/pmic_pca9450.c
> @@ -23,7 +23,7 @@ int power_pca9450a_init(unsigned char bus)
> ????????p->name = pca9450_name;
> ????????p->interface = PMIC_I2C;
> ????????p->number_of_regs = PCA9450_REG_NUM;
> -???????p->hw.i2c.addr = 0x35;
> +???????p->hw.i2c.addr = 0x25;
The address 0x35 is correct for PCA9540A. You are probably using
PCA9540B/C which address is 0x25. If so, please
call?power_pca9450b_init.
Best regards,
Ye Li
> ????????p->hw.i2c.tx_num = 1;
> ????????p->bus = bus;
>
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-06-29 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 8:42 [PATCH 1/1] power: pmic_pca9450: fix PCA9450A I2C address Sébastien Szymanski
2020-06-29 9:51 ` Ye Li [this message]
2020-06-29 10:11 ` [EXT] " Sébastien Szymanski
2020-06-29 13:45 ` Ye Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1593424001.29491.3.camel@nxp.com \
--to=ye.li@nxp.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox