* [PATCH v2 1/1] power: pmic_pca9450: fix PCA9450A I2C address
@ 2020-06-30 13:03 Sébastien Szymanski
2020-06-30 13:23 ` Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sébastien Szymanski @ 2020-06-30 13:03 UTC (permalink / raw)
To: u-boot
Quoting Ye Li from NXP:
"We have confirmed with PMIC team, 0x35 is used only on early chips
and not used any more. 0x25 is the final address."
Fix it by merging power_pca9450a_init and power_pca9450b_init into one
function power_pca9450_init.
Signed-off-by: S?bastien Szymanski <sebastien.szymanski@armadeus.com>
---
Changes for v2:
* Quoting Ye Li
* Merge both function into one as suggested by Ye Li
board/freescale/imx8mp_evk/spl.c | 2 +-
drivers/power/pmic/pmic_pca9450.c | 21 +--------------------
include/power/pca9450.h | 3 +--
3 files changed, 3 insertions(+), 23 deletions(-)
diff --git a/board/freescale/imx8mp_evk/spl.c b/board/freescale/imx8mp_evk/spl.c
index 3b3a854e29..3214718e62 100644
--- a/board/freescale/imx8mp_evk/spl.c
+++ b/board/freescale/imx8mp_evk/spl.c
@@ -68,7 +68,7 @@ int power_init_board(void)
struct pmic *p;
int ret;
- ret = power_pca9450b_init(I2C_PMIC);
+ ret = power_pca9450_init(I2C_PMIC);
if (ret)
printf("power init failed");
p = pmic_get("PCA9450");
diff --git a/drivers/power/pmic/pmic_pca9450.c b/drivers/power/pmic/pmic_pca9450.c
index 67a9090200..d4f27428bd 100644
--- a/drivers/power/pmic/pmic_pca9450.c
+++ b/drivers/power/pmic/pmic_pca9450.c
@@ -11,26 +11,7 @@
static const char pca9450_name[] = "PCA9450";
-int power_pca9450a_init(unsigned char bus)
-{
- struct pmic *p = pmic_alloc();
-
- if (!p) {
- printf("%s: POWER allocation error!\n", __func__);
- return -ENOMEM;
- }
-
- p->name = pca9450_name;
- p->interface = PMIC_I2C;
- p->number_of_regs = PCA9450_REG_NUM;
- p->hw.i2c.addr = 0x35;
- p->hw.i2c.tx_num = 1;
- p->bus = bus;
-
- return 0;
-}
-
-int power_pca9450b_init(unsigned char bus)
+int power_pca9450_init(unsigned char bus)
{
struct pmic *p = pmic_alloc();
diff --git a/include/power/pca9450.h b/include/power/pca9450.h
index 5d4f58ca44..5a9a697d62 100644
--- a/include/power/pca9450.h
+++ b/include/power/pca9450.h
@@ -54,7 +54,6 @@ enum {
PCA9450_REG_NUM,
};
-int power_pca9450a_init(unsigned char bus);
-int power_pca9450b_init(unsigned char bus);
+int power_pca9450_init(unsigned char bus);
#endif
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 1/1] power: pmic_pca9450: fix PCA9450A I2C address
2020-06-30 13:03 [PATCH v2 1/1] power: pmic_pca9450: fix PCA9450A I2C address Sébastien Szymanski
@ 2020-06-30 13:23 ` Fabio Estevam
2020-07-01 4:01 ` [EXT] " Ye Li
2020-07-16 17:48 ` sbabic at denx.de
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2020-06-30 13:23 UTC (permalink / raw)
To: u-boot
On Tue, Jun 30, 2020 at 10:03 AM S?bastien Szymanski
<sebastien.szymanski@armadeus.com> wrote:
>
> Quoting Ye Li from NXP:
>
> "We have confirmed with PMIC team, 0x35 is used only on early chips
> and not used any more. 0x25 is the final address."
>
> Fix it by merging power_pca9450a_init and power_pca9450b_init into one
> function power_pca9450_init.
>
> Signed-off-by: S?bastien Szymanski <sebastien.szymanski@armadeus.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [EXT] [PATCH v2 1/1] power: pmic_pca9450: fix PCA9450A I2C address
2020-06-30 13:03 [PATCH v2 1/1] power: pmic_pca9450: fix PCA9450A I2C address Sébastien Szymanski
2020-06-30 13:23 ` Fabio Estevam
@ 2020-07-01 4:01 ` Ye Li
2020-07-16 17:48 ` sbabic at denx.de
2 siblings, 0 replies; 4+ messages in thread
From: Ye Li @ 2020-07-01 4:01 UTC (permalink / raw)
To: u-boot
On Tue, 2020-06-30 at 15:03 +0200, S?bastien Szymanski wrote:
> Caution: EXT Email
>
> Quoting Ye Li from NXP:
>
> ????"We have confirmed with PMIC team, 0x35 is used only on early
> chips
> ????and not used any more. 0x25 is the final address."
>
> Fix it by merging power_pca9450a_init and power_pca9450b_init into
> one
> function power_pca9450_init.
>
> Signed-off-by: S?bastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
>
> Changes for v2:
> ?* Quoting Ye Li
> ?* Merge both function into one as suggested by Ye Li
>
> ?board/freescale/imx8mp_evk/spl.c??|??2 +-
> ?drivers/power/pmic/pmic_pca9450.c | 21 +--------------------
> ?include/power/pca9450.h???????????|??3 +--
> ?3 files changed, 3 insertions(+), 23 deletions(-)
>
> diff --git a/board/freescale/imx8mp_evk/spl.c
> b/board/freescale/imx8mp_evk/spl.c
> index 3b3a854e29..3214718e62 100644
> --- a/board/freescale/imx8mp_evk/spl.c
> +++ b/board/freescale/imx8mp_evk/spl.c
> @@ -68,7 +68,7 @@ int power_init_board(void)
> ????????struct pmic *p;
> ????????int ret;
>
> -???????ret = power_pca9450b_init(I2C_PMIC);
> +???????ret = power_pca9450_init(I2C_PMIC);
> ????????if (ret)
> ????????????????printf("power init failed");
> ????????p = pmic_get("PCA9450");
> diff --git a/drivers/power/pmic/pmic_pca9450.c
> b/drivers/power/pmic/pmic_pca9450.c
> index 67a9090200..d4f27428bd 100644
> --- a/drivers/power/pmic/pmic_pca9450.c
> +++ b/drivers/power/pmic/pmic_pca9450.c
> @@ -11,26 +11,7 @@
>
> ?static const char pca9450_name[] = "PCA9450";
>
> -int power_pca9450a_init(unsigned char bus)
> -{
> -???????struct pmic *p = pmic_alloc();
> -
> -???????if (!p) {
> -???????????????printf("%s: POWER allocation error!\n", __func__);
> -???????????????return -ENOMEM;
> -???????}
> -
> -???????p->name = pca9450_name;
> -???????p->interface = PMIC_I2C;
> -???????p->number_of_regs = PCA9450_REG_NUM;
> -???????p->hw.i2c.addr = 0x35;
> -???????p->hw.i2c.tx_num = 1;
> -???????p->bus = bus;
> -
> -???????return 0;
> -}
> -
> -int power_pca9450b_init(unsigned char bus)
> +int power_pca9450_init(unsigned char bus)
> ?{
> ????????struct pmic *p = pmic_alloc();
>
> diff --git a/include/power/pca9450.h b/include/power/pca9450.h
> index 5d4f58ca44..5a9a697d62 100644
> --- a/include/power/pca9450.h
> +++ b/include/power/pca9450.h
> @@ -54,7 +54,6 @@ enum {
> ????????PCA9450_REG_NUM,
> ?};
>
> -int power_pca9450a_init(unsigned char bus);
> -int power_pca9450b_init(unsigned char bus);
> +int power_pca9450_init(unsigned char bus);
>
> ?#endif
> --
> 2.26.2
>
Reviewed-by: Ye Li <ye.li@nxp.com>
Best regards,
Ye Li
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/1] power: pmic_pca9450: fix PCA9450A I2C address
2020-06-30 13:03 [PATCH v2 1/1] power: pmic_pca9450: fix PCA9450A I2C address Sébastien Szymanski
2020-06-30 13:23 ` Fabio Estevam
2020-07-01 4:01 ` [EXT] " Ye Li
@ 2020-07-16 17:48 ` sbabic at denx.de
2 siblings, 0 replies; 4+ messages in thread
From: sbabic at denx.de @ 2020-07-16 17:48 UTC (permalink / raw)
To: u-boot
> Quoting Ye Li from NXP:
> "We have confirmed with PMIC team, 0x35 is used only on early chips
> and not used any more. 0x25 is the final address."
> Fix it by merging power_pca9450a_init and power_pca9450b_init into one
> function power_pca9450_init.
> Signed-off-by: S?bastien Szymanski <sebastien.szymanski@armadeus.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> Reviewed-by: Ye Li <ye.li@nxp.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-16 17:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-30 13:03 [PATCH v2 1/1] power: pmic_pca9450: fix PCA9450A I2C address Sébastien Szymanski
2020-06-30 13:23 ` Fabio Estevam
2020-07-01 4:01 ` [EXT] " Ye Li
2020-07-16 17:48 ` sbabic at denx.de
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox