From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: u-boot@lists.denx.de
Subject: [PATCH v1 08/10] dts: r64: add sata- and asm_sel nodes
Date: Mon, 17 Aug 2020 14:50:14 +0800 [thread overview]
Message-ID: <1597647014.5429.11.camel@mhfsdcap03> (raw)
In-Reply-To: <20200816082431.5087-9-linux@fw-web.de>
On Sun, 2020-08-16 at 10:24 +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> asm_sel is for switching between sata and pcie mode
> on r64 there is GPIO90 connected to ASM1480 which
> switches RX/TX pairs to PCIe/SATA connector
> output-low means sata-controller is active
>
> with 2020-10 now reg is also needed for the phy itself
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> arch/arm/dts/mt7622-bananapi-bpi-r64.dts | 9 +++++++
> arch/arm/dts/mt7622.dtsi | 32 ++++++++++++++++++++++++
> 2 files changed, 41 insertions(+)
>
> diff --git a/arch/arm/dts/mt7622-bananapi-bpi-r64.dts b/arch/arm/dts/mt7622-bananapi-bpi-r64.dts
> index 768f15bc2c..c36ec8f8d0 100644
> --- a/arch/arm/dts/mt7622-bananapi-bpi-r64.dts
> +++ b/arch/arm/dts/mt7622-bananapi-bpi-r64.dts
> @@ -204,3 +204,12 @@
> full-duplex;
> };
> };
> +
> +&gpio {
> + /*gpio 90 for setting mode to sata*/
> + asm_sel {
> + gpio-hog;
> + gpios = <90 GPIO_ACTIVE_HIGH>;
> + output-low;
> + };
> +};
> diff --git a/arch/arm/dts/mt7622.dtsi b/arch/arm/dts/mt7622.dtsi
> index fec071643e..c43ad65702 100644
> --- a/arch/arm/dts/mt7622.dtsi
> +++ b/arch/arm/dts/mt7622.dtsi
> @@ -10,6 +10,7 @@
> #include <dt-bindings/power/mt7629-power.h>
> #include <dt-bindings/reset/mt7629-reset.h>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/phy/phy.h>
>
> / {
> compatible = "mediatek,mt7622";
> @@ -270,6 +271,37 @@
> };
> };
>
> + sata: sata at 1a200000 {
> + compatible = "mediatek,mtk-ahci";
> + reg = <0x1a200000 0x1100>;
> + resets = <&pciesys MT7622_SATA_AXI_BUS_RST>,
> + <&pciesys MT7622_SATA_PHY_SW_RST>,
> + <&pciesys MT7622_SATA_PHY_REG_RST>;
> + reset-names = "axi", "sw", "reg";
> + mediatek,phy-mode = <&pciesys>;
> + ports-implemented = <0x1>;
> + phys = <&sata_port PHY_TYPE_SATA>;
> + phy-names = "sata-phy";
> + status = "okay";
> + };
> +
> + sata_phy: sata-phy at 1a243000 {
> + compatible = "mediatek,generic-tphy-v1";
> + reg = <0x1a243000 0x0100>;
Would you please change the tphy driver to make the shared reg optional
when version is v1 for sata, as Linux kernel does.
then we can remove "reg" property here.
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> + status = "okay";
> +
> + sata_port: sata-phy at 1a243000 {
> + reg = <0x1a243000 0x0100>;
> + clocks = <&topckgen CLK_TOP_ETH_500M>;
> + clock-names = "ref";
> + #phy-cells = <1>;
> + status = "okay";
> + };
> + };
> +
> ethsys: syscon at 1b000000 {
> compatible = "mediatek,mt7622-ethsys", "syscon";
> reg = <0x1b000000 0x1000>;
next prev parent reply other threads:[~2020-08-17 6:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-16 8:24 [PATCH v1 00/10] Add MTK AHCI driver, BPI-R64 dts and USB-Nodes for mt7622/mt7623 Frank Wunderlich
2020-08-16 8:24 ` [PATCH v1 01/10] arm: dts: mt7622: add SATA reset constants Frank Wunderlich
2020-08-16 8:24 ` [PATCH v1 02/10] phy: mtk-tphy: add PHY_TYPE_SATA Frank Wunderlich
2020-08-16 8:24 ` [PATCH v1 03/10] reset: add basic reset controller for pciesys Frank Wunderlich
2020-08-16 8:24 ` [PATCH v1 04/10] ahci: mediatek: add ahci driver Frank Wunderlich
2020-08-16 8:24 ` [PATCH v1 05/10] clk: mt7622: add needed clocks for ssusb-node Frank Wunderlich
2020-08-16 8:24 ` [PATCH v1 06/10] arm: dts: add watchdog-reboot node for mt7622 Frank Wunderlich
2020-08-16 8:24 ` [PATCH v1 07/10] arm: dts: add dts for Bananapi-R64 Frank Wunderlich
2020-08-16 8:24 ` [PATCH v1 08/10] dts: r64: add sata- and asm_sel nodes Frank Wunderlich
2020-08-17 6:50 ` Chunfeng Yun [this message]
2020-08-16 8:24 ` [PATCH v1 09/10] arm: dts: mt7622: add USB nodes Frank Wunderlich
2020-08-17 2:59 ` Chunfeng Yun
2020-08-17 6:25 ` Frank Wunderlich
2020-08-16 8:24 ` [PATCH v1 10/10] arm: dts: mt7623: " Frank Wunderlich
2020-08-17 2:43 ` Chunfeng Yun
2020-08-17 3:02 ` Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597647014.5429.11.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox