public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sam Shih <sam.shih@mediatek.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 04/11] reset: add basic reset controller for pciesys
Date: Wed, 19 Aug 2020 16:33:32 +0800	[thread overview]
Message-ID: <1597826012.6513.4.camel@mtksdccf07> (raw)
In-Reply-To: <20200819080225.4267-5-linux@fw-web.de>

Hi Frank,

Thanks your for your patches.
some suggestions for coding style.


On Wed, 2020-08-19 at 10:02 +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> bind reset controller to pciesys
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>  drivers/clk/mediatek/clk-mt7622.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/drivers/clk/mediatek/clk-mt7622.c b/drivers/clk/mediatek/clk-mt7622.c
> index bd86b5b974..d53ed69189 100644
> --- a/drivers/clk/mediatek/clk-mt7622.c
> +++ b/drivers/clk/mediatek/clk-mt7622.c
> @@ -594,6 +594,20 @@ static int mt7622_pciesys_probe(struct udevice *dev)
>  	return mtk_common_clk_gate_init(dev, &mt7622_clk_tree, pcie_cgs);
>  }
>  
> +static int mt7622_pciesys_bind(struct udevice *dev)
> +{
> +	int ret = 0;
> +
> +	if (IS_ENABLED(CONFIG_RESET_MEDIATEK)) {
> +//	PCIESYS uses in linux also 0x34 = ETHSYS reset controller

No need to add special comments that are not easy to understand,
and please uses "/* */" instead of "//".

Thanks,
Best Regards,
Sam Shih

  reply	other threads:[~2020-08-19  8:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19  8:02 [PATCH v2 00/11] Add MTK AHCI driver, BPI-R64 dts and USB-Nodes for mt7622/mt7623 Frank Wunderlich
2020-08-19  8:02 ` [PATCH v2 01/11] arm: dts: mt7622: add SATA reset constants Frank Wunderlich
2020-08-19  8:02 ` [PATCH v2 02/11] phy: mtk-tphy: add PHY_TYPE_SATA Frank Wunderlich
2020-08-19  8:02 ` [PATCH v2 03/11] phy: mtk-tphy: make shared reg optional for v1 Frank Wunderlich
2020-08-19  8:27   ` Chunfeng Yun
2020-08-19  8:02 ` [PATCH v2 04/11] reset: add basic reset controller for pciesys Frank Wunderlich
2020-08-19  8:33   ` Sam Shih [this message]
2020-08-19 11:04     ` Aw: " Frank Wunderlich
2020-08-19  8:02 ` [PATCH v2 05/11] ahci: mediatek: add ahci driver Frank Wunderlich
2020-08-19  8:38   ` Sam Shih
2020-08-19 11:11     ` Aw: " Frank Wunderlich
2020-08-19  8:02 ` [PATCH v2 06/11] clk: mt7622: add needed clocks for ssusb-node Frank Wunderlich
2020-08-19  8:02 ` [PATCH v2 07/11] arm: dts: add watchdog-reboot node for mt7622 Frank Wunderlich
2020-08-19  8:02 ` [PATCH v2 08/11] arm: dts: add dts for Bananapi-R64 Frank Wunderlich
2020-08-19  8:02 ` [PATCH v2 09/11] arm: dts: mt7622: add sata- and asm_sel nodes Frank Wunderlich
2020-08-19  8:54   ` Chunfeng Yun
2020-08-19 10:58     ` Aw: " Frank Wunderlich
2020-08-20  1:24       ` Chunfeng Yun
2020-08-19  8:02 ` [PATCH v2 10/11] arm: dts: mt7622: add USB nodes Frank Wunderlich
2020-08-19  8:02 ` [PATCH v2 11/11] arm: dts: mt7623: " Frank Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1597826012.6513.4.camel@mtksdccf07 \
    --to=sam.shih@mediatek.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox