From: Sam Shih <sam.shih@mediatek.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 05/11] ahci: mediatek: add ahci driver
Date: Wed, 19 Aug 2020 16:38:36 +0800 [thread overview]
Message-ID: <1597826316.6513.9.camel@mtksdccf07> (raw)
In-Reply-To: <20200819080225.4267-6-linux@fw-web.de>
Hi Frank,
Thanks your for your patches.
some suggestions for coding style.O
> From: Frank Wunderlich <frank-w@public-files.de>
> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index a69edb10f7..98fb480700 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -19,3 +19,4 @@ obj-$(CONFIG_SATA_SIL) += sata_sil.o
> obj-$(CONFIG_SANDBOX) += sata_sandbox.o
> obj-$(CONFIG_AHCI_MVEBU) += ahci_mvebu.o
> obj-$(CONFIG_SUNXI_AHCI) += ahci_sunxi.o
> +obj-$(CONFIG_MTK_AHCI) += mtk_ahci.o
> diff --git a/drivers/ata/mtk_ahci.c b/drivers/ata/mtk_ahci.c
> new file mode 100644
> index 0000000000..8e09c5f9e6
> --- /dev/null
> +++ b/drivers/ata/mtk_ahci.c
> @@ -0,0 +1,130 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * MTK SATA platform driver
> + *
> + * (C) Copyright 2020
> + * Mediatek
Please make copyright in the same line.
Copyright (C) 2020 MediaTek Inc.
> + *
> + * Author: Frank Wunderlich <frank-w@public-files.de>
> + * based on https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/ata/ahci_mtk.c
Don't place this line between the Author tags
> + * Author: Ryder Lee <ryder.lee@mediatek.com>
> + */
Thanks,
Best Regards,
Sam Shih
next prev parent reply other threads:[~2020-08-19 8:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 8:02 [PATCH v2 00/11] Add MTK AHCI driver, BPI-R64 dts and USB-Nodes for mt7622/mt7623 Frank Wunderlich
2020-08-19 8:02 ` [PATCH v2 01/11] arm: dts: mt7622: add SATA reset constants Frank Wunderlich
2020-08-19 8:02 ` [PATCH v2 02/11] phy: mtk-tphy: add PHY_TYPE_SATA Frank Wunderlich
2020-08-19 8:02 ` [PATCH v2 03/11] phy: mtk-tphy: make shared reg optional for v1 Frank Wunderlich
2020-08-19 8:27 ` Chunfeng Yun
2020-08-19 8:02 ` [PATCH v2 04/11] reset: add basic reset controller for pciesys Frank Wunderlich
2020-08-19 8:33 ` Sam Shih
2020-08-19 11:04 ` Aw: " Frank Wunderlich
2020-08-19 8:02 ` [PATCH v2 05/11] ahci: mediatek: add ahci driver Frank Wunderlich
2020-08-19 8:38 ` Sam Shih [this message]
2020-08-19 11:11 ` Aw: " Frank Wunderlich
2020-08-19 8:02 ` [PATCH v2 06/11] clk: mt7622: add needed clocks for ssusb-node Frank Wunderlich
2020-08-19 8:02 ` [PATCH v2 07/11] arm: dts: add watchdog-reboot node for mt7622 Frank Wunderlich
2020-08-19 8:02 ` [PATCH v2 08/11] arm: dts: add dts for Bananapi-R64 Frank Wunderlich
2020-08-19 8:02 ` [PATCH v2 09/11] arm: dts: mt7622: add sata- and asm_sel nodes Frank Wunderlich
2020-08-19 8:54 ` Chunfeng Yun
2020-08-19 10:58 ` Aw: " Frank Wunderlich
2020-08-20 1:24 ` Chunfeng Yun
2020-08-19 8:02 ` [PATCH v2 10/11] arm: dts: mt7622: add USB nodes Frank Wunderlich
2020-08-19 8:02 ` [PATCH v2 11/11] arm: dts: mt7623: " Frank Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597826316.6513.9.camel@mtksdccf07 \
--to=sam.shih@mediatek.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox