From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sam Shih <sam.shih@mediatek.com>
Date: Wed, 19 Aug 2020 16:38:36 +0800
Subject: [PATCH v2 05/11] ahci: mediatek: add ahci driver
In-Reply-To: <20200819080225.4267-6-linux@fw-web.de>
References: <20200819080225.4267-1-linux@fw-web.de>
 <20200819080225.4267-6-linux@fw-web.de>
Message-ID: <1597826316.6513.9.camel@mtksdccf07>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Frank,
Thanks your for your patches.
some suggestions for coding style.O

> From: Frank Wunderlich <frank-w@public-files.de>

> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index a69edb10f7..98fb480700 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -19,3 +19,4 @@ obj-$(CONFIG_SATA_SIL) += sata_sil.o
>  obj-$(CONFIG_SANDBOX) += sata_sandbox.o
>  obj-$(CONFIG_AHCI_MVEBU) += ahci_mvebu.o
>  obj-$(CONFIG_SUNXI_AHCI) += ahci_sunxi.o
> +obj-$(CONFIG_MTK_AHCI) += mtk_ahci.o
> diff --git a/drivers/ata/mtk_ahci.c b/drivers/ata/mtk_ahci.c
> new file mode 100644
> index 0000000000..8e09c5f9e6
> --- /dev/null
> +++ b/drivers/ata/mtk_ahci.c
> @@ -0,0 +1,130 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * MTK SATA platform driver
> + *
> + * (C) Copyright 2020
> + *     Mediatek

Please make copyright in the same line.
Copyright (C) 2020 MediaTek Inc.

> + *
> + * Author: Frank Wunderlich <frank-w@public-files.de>
> + * based on https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/ata/ahci_mtk.c

Don't place this line between the Author tags

> + * Author: Ryder Lee <ryder.lee@mediatek.com>
> + */



Thanks,
Best Regards,
Sam Shih