public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Weijie Gao <weijie.gao@mediatek.com>
To: u-boot@lists.denx.de
Subject: [PATCH 08/18] serial: add uart driver for MediaTek MT7620 SoC
Date: Thu, 29 Oct 2020 17:47:17 +0800	[thread overview]
Message-ID: <1603964837.18736.26.camel@mcddlt001> (raw)
In-Reply-To: <CAPnjgZ3P0_rTOhgwQgAGWcwbteFwpOpD1NU8iKy83B9srafAhw@mail.gmail.com>

On Mon, 2020-10-26 at 22:51 -0600, Simon Glass wrote:
> Hi Weijie,
> 
> On Fri, 16 Oct 2020 at 01:36, Weijie Gao <weijie.gao@mediatek.com> wrote:
> >
> > This patch adds uart support for MediaTek MT7620 and earlier SoCs.
> >
> > The UART used by MT7620 is incompatible with the ns16550a driver.
> > All registers of this UART have different addresses. A special 16-bit
> > register for Divisor Latch is used to set the baudrate instead of the
> > original two 8-bit registers (DLL and DLM).
> >
> > The driver can be built without DM which is useful for tiny SPL.
> >
> > Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>
> > ---
> >  drivers/serial/Kconfig         |  20 ++
> >  drivers/serial/Makefile        |   1 +
> >  drivers/serial/serial.c        |   2 +
> >  drivers/serial/serial_mt7620.c | 350 +++++++++++++++++++++++++++++++++
> >  4 files changed, 373 insertions(+)
> >  create mode 100644 drivers/serial/serial_mt7620.c
> 
> Why do you need to build without DM? We have of-platdata which
> provides for smaller images. What is the SRAM size available?
> 

Actually it's the total size (spl+u-boot-lzma.img) that matters.
mt7620_rfb_defconfig is configured to be compatible with the original
u-boot from MTK SDK, and the maximum size is 192KiB.

Currently without SPL_DM, the final image u-boot-with-spl.bin is about
170KiB, the u-boot-spl.bin is only 20KiB.

If SPL_DM is enabled, the total size is 189KiB, which is very close to
the limit 192KiB, and the size of spl is almost doubled, 39KiB.
(Without DM, only serial_mt7620 is needed. However with DM, both
serial_mt7620, clk-mt7620 and misc are needed)

Considering that we may still add some feature to mt7620_rfb_defconfig
in the future, only 3KiB left is not enough. Building without DM is
apparently better.

I believe using of-platdata can only reduce few KiBs of SPL, because the
DM itself is the largest overhead.

> Regards,
> Simon

  reply	other threads:[~2020-10-29  9:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16  7:35 [PATCH 08/18] serial: add uart driver for MediaTek MT7620 SoC Weijie Gao
2020-10-27  4:51 ` Simon Glass
2020-10-29  9:47   ` Weijie Gao [this message]
2020-10-29 14:30     ` Simon Glass
2020-10-30  3:20       ` Weijie Gao
2020-10-30 18:15         ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1603964837.18736.26.camel@mcddlt001 \
    --to=weijie.gao@mediatek.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox