public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Weijie Gao <weijie.gao@mediatek.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 17/21] phy: add USB PHY driver for MediaTek MT7620 SoC
Date: Mon, 9 Nov 2020 10:14:04 +0800	[thread overview]
Message-ID: <1604888044.18736.42.camel@mcddlt001> (raw)
In-Reply-To: <CAMty3ZCqKyfsyn1mDSccg+XfbvxFHpL7BGSqs7WzwJ90s1C5+Q@mail.gmail.com>

On Mon, 2020-11-02 at 11:41 +0530, Jagan Teki wrote:
> On Fri, Oct 30, 2020 at 3:05 PM Weijie Gao <weijie.gao@mediatek.com> wrote:
> >
> > This patch adds USB PHY driver for MediaTek MT7620 SoC
> >
> > Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>
> > ---
> > v2 changes: none
> > ---
> >  drivers/phy/Kconfig          |   7 +++
> >  drivers/phy/Makefile         |   1 +
> >  drivers/phy/mt7620-usb-phy.c | 113 +++++++++++++++++++++++++++++++++++
> >  3 files changed, 121 insertions(+)
> >  create mode 100644 drivers/phy/mt7620-usb-phy.c
> >
> > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> > index d12a6b02ad..ab638f0e7d 100644
> > --- a/drivers/phy/Kconfig
> > +++ b/drivers/phy/Kconfig
> > @@ -218,6 +218,13 @@ config KEYSTONE_USB_PHY
> >
> >           This PHY is found on some Keystone (K2) devices supporting USB.
> >
> > +config MT7620_USB_PHY
> > +       bool "MediaTek MT7620 USB PHY support"
> > +       depends on PHY
> > +       depends on SOC_MT7620
> > +       help
> > +          Support the intergated USB PHY in MediaTek MT7620 SoC
> > +
> >  config MT76X8_USB_PHY
> >         bool "MediaTek MT76x8 (7628/88) USB PHY support"
> >         depends on PHY
> > diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
> > index 45a7fe5b56..6b3761b8c8 100644
> > --- a/drivers/phy/Makefile
> > +++ b/drivers/phy/Makefile
> > @@ -24,6 +24,7 @@ obj-$(CONFIG_MESON_G12A_USB_PHY) += meson-g12a-usb2.o meson-g12a-usb3-pcie.o
> >  obj-$(CONFIG_MSM8916_USB_PHY) += msm8916-usbh-phy.o
> >  obj-$(CONFIG_OMAP_USB2_PHY) += omap-usb2-phy.o
> >  obj-$(CONFIG_KEYSTONE_USB_PHY) += keystone-usb-phy.o
> > +obj-$(CONFIG_MT7620_USB_PHY) += mt7620-usb-phy.o
> >  obj-$(CONFIG_MT76X8_USB_PHY) += mt76x8-usb-phy.o
> >  obj-$(CONFIG_PHY_DA8XX_USB) += phy-da8xx-usb.o
> >  obj-$(CONFIG_PHY_MTK_TPHY) += phy-mtk-tphy.o
> > diff --git a/drivers/phy/mt7620-usb-phy.c b/drivers/phy/mt7620-usb-phy.c
> > new file mode 100644
> > index 0000000000..59ac32f327
> > --- /dev/null
> > +++ b/drivers/phy/mt7620-usb-phy.c
> > @@ -0,0 +1,113 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (C) 2020 MediaTek Inc. All Rights Reserved.
> > + *
> > + * Author: Weijie Gao <weijie.gao@mediatek.com>
> > + */
> > +
> > +#include <clk.h>
> > +#include <dm.h>
> > +#include <generic-phy.h>
> > +#include <misc.h>
> > +#include <reset.h>
> > +#include <dm/device_compat.h>
> > +#include <linux/delay.h>
> > +#include <mach/mt7620-sysc.h>
> > +
> > +struct mt7620_usb_phy {
> > +       struct udevice *dev;
> 
> Why this explicit dev required here? generic_phy_get_ calls will assign phy->dev

I didn't notice that. This will be modified in next series.

  reply	other threads:[~2020-11-09  2:14 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30  9:33 [PATCH v2 00/21] Add support for MediaTek MT7620 SoC Weijie Gao
2020-10-30  9:33 ` [PATCH v2 01/21] mips: dts: switch to board defines for dtb for mtmips Weijie Gao
2020-10-30  9:33 ` [PATCH v2 02/21] mips: mtmips: move mt7628 related Kconfig into mt7628 subdirectory Weijie Gao
2020-10-30  9:33 ` [PATCH v2 03/21] mips: mtmips: select SYSRESET for mt7628 only Weijie Gao
2020-10-30  9:33 ` [PATCH v2 04/21] mips: mtmips: fix dram size detection in dram_init Weijie Gao
2020-10-30  9:33 ` [PATCH v2 05/21] mips: enable _machine_restart for spl Weijie Gao
2020-11-03 15:12   ` Simon Glass
2020-10-30  9:34 ` [PATCH v2 06/21] mips: mtmips: add support to initialize SDRAM Weijie Gao
2020-10-30  9:34 ` [PATCH v2 07/21] mips: mtmips: add support for MediaTek MT7620 SoC Weijie Gao
2020-10-30  9:34 ` [PATCH v2 08/21] mips: mtmips: add two reference boards for mt7620 Weijie Gao
2020-10-30  9:34 ` [PATCH v2 09/21] configs: mtmips: refresh for mt7628 based boards Weijie Gao
2020-10-30  9:34 ` [PATCH v2 10/21] serial: add uart driver for MediaTek MT7620 SoC Weijie Gao
2020-11-03 15:12   ` Simon Glass
2020-10-30  9:34 ` [PATCH v2 11/21] clk: add clock " Weijie Gao
2020-10-30  9:34 ` [PATCH v2 12/21] reset: mtmips: add reset controller support " Weijie Gao
2020-10-30  9:34 ` [PATCH v2 13/21] pinctrl: mtmips: add " Weijie Gao
2020-10-30  9:34 ` [PATCH v2 14/21] watchdog: add watchdog driver " Weijie Gao
2020-11-02  6:02   ` Jagan Teki
2020-11-09  2:13     ` Weijie Gao
2020-10-30  9:34 ` [PATCH v2 15/21] gpio: add GPIO controller " Weijie Gao
2020-10-30  9:35 ` [PATCH v2 16/21] spi: add spi controller support " Weijie Gao
2020-11-02  6:00   ` Jagan Teki
2020-11-09  2:10     ` Weijie Gao
2020-10-30  9:35 ` [PATCH v2 17/21] phy: add USB PHY driver " Weijie Gao
2020-11-02  6:11   ` Jagan Teki
2020-11-09  2:14     ` Weijie Gao [this message]
2020-10-30  9:35 ` [PATCH v2 18/21] net: add ethernet " Weijie Gao
2020-10-30  9:35 ` [PATCH v2 19/21] mmc: mtk-sd: add pad control settings for MediaTek MT7620/MT76x8 SoCs Weijie Gao
2020-10-30  9:35 ` [PATCH v2 20/21] reset: reset-mtmips: add DM_FLAG_PRE_RELOC flag Weijie Gao
2020-10-30  9:35 ` [PATCH v2 21/21] MAINTAINERS: add maintainer for MediaTek MIPS platform Weijie Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1604888044.18736.42.camel@mcddlt001 \
    --to=weijie.gao@mediatek.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox