From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Meng Date: Mon, 1 Feb 2021 12:20:32 +0800 Subject: [PATCH 1/3] mmc: mmc_spi: Move argument check to the beginning of mmc_spi_sendcmd() In-Reply-To: <1612153234-7061-1-git-send-email-bmeng.cn@gmail.com> References: <1612153234-7061-1-git-send-email-bmeng.cn@gmail.com> Message-ID: <1612153234-7061-2-git-send-email-bmeng.cn@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de From: Bin Meng The argument check should happen before any transfer on the SPI lines. Signed-off-by: Bin Meng --- drivers/mmc/mmc_spi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/mmc_spi.c b/drivers/mmc/mmc_spi.c index b1edb6a..85a2818 100644 --- a/drivers/mmc/mmc_spi.c +++ b/drivers/mmc/mmc_spi.c @@ -83,6 +83,9 @@ static int mmc_spi_sendcmd(struct udevice *dev, __func__, cmdidx, cmdarg, resp_type, resp_size, resp_match, resp_match_value); + if (!resp || !resp_size) + return 0; + cmdo[0] = 0xff; cmdo[1] = MMC_SPI_CMD(cmdidx); cmdo[2] = cmdarg >> 24; @@ -98,9 +101,6 @@ static int mmc_spi_sendcmd(struct udevice *dev, if (ret) return ret; - if (!resp || !resp_size) - return 0; - debug("%s: cmd%d", __func__, cmdidx); if (resp_match) { -- 2.7.4