[U-Boot] [PATCH v4 5/7] usb_storage: Adjust time-outs

Benoît Thébaudeau
2012-08-10T18:39:28Z

Hi Ilya,

On Fri, Aug 10, 2012 at 8:03:12 PM, Ilya Yanok wrote:
> Hi Benoit,

> On Fri, Aug 10, 2012 at 8:23 PM, Beno?t Th?baudeau <
> benoit.thebaudeau at advansee.com > wrote:

> > Adjust time-out value for the new EHCI mechanism.
>

> Could you please be a bit more specific? ;)

> How this timeout is related to the new mechanism? Is it really EHCI
> specific? If it is, that's hardcoding of lower layer details again,
> I think that's undesirable...

Well, I did this specific patch a very long time ago, and I don't remember the
details. I know that things did not work without it in my test conditions at
that time. I've just run again all my tests with the current code on all my
platforms without this patch, and everything works fine. So it was perhaps a
device-related issue rather than an EHCI-related one. Since the rationale for
this patch is no longer clear and things work fine without it, we can probably
drop it. I let you and Marek decide.

> But generally this series looks really good. Thanks a lot!

Great. You're welcome.

Best regards,
Beno?t