From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 455DAC11F68 for ; Fri, 2 Jul 2021 13:40:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 693036142C for ; Fri, 2 Jul 2021 13:40:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 693036142C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DB36282916; Fri, 2 Jul 2021 15:40:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Ohp1nDdH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 45CBE82979; Fri, 2 Jul 2021 15:40:46 +0200 (CEST) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F3A0D82916 for ; Fri, 2 Jul 2021 15:40:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qk1-x729.google.com with SMTP id 19so9319207qky.13 for ; Fri, 02 Jul 2021 06:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=tur1rvLeXEObyb59yQqoEDL88/Z2l6xSDGmG6HHfn/4=; b=Ohp1nDdHq7eZ2VY0d0XoFqh+rKhqgFdr9T0LU77mBL/VdMx/yZVq4JktnWvq8e1J6T xK0VKKFZTe4FKk32miMJLq6t66HLPyXlXqxtLJgVuoYwSq+/AchuLkAqxkhrbmNWKasB wRXkibVeV126EwwosK+al1Sj1MWeCJAqlHf9GEihqV9GK8ksJOwIt7UJ+oWykUtXQMyb mQghTENrFFFo7qk2cpQAu4qR8ZW8VNXihOfN8HlSzBNa2lTira86A0rFMokTPfzCGj6a tYu7BGgdU4/fGmTsSXLEmUFQyYydX+cWpbqJMXPg2F+4dFzcgMA5boKBboa0cPFFoLvs E+CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tur1rvLeXEObyb59yQqoEDL88/Z2l6xSDGmG6HHfn/4=; b=GAgVRK19yYBC5sxLE0KDD15e31FM49lZTS7Fx6b6ZjEOV62MIzwalZANMJgulT4YXF jAuthC0QAJZPOVbVwFChSdMXYozs3tvMaYHQh6yyzMH6na8Tg3dO/dbuFZZj0ST/JxJ4 qusqchete7NXaxfqHTzgyixKfShDI88PwvBx5bYZbRRWWdR+J/fv0QMNv1D7UQ9cCSrz BHKTMkePlo+0uozHF4XBgN37wzoqV/tJse5CwngMXkD1VggO3G/GTIfYFsZ98TqyZmd2 3LSXV9zw9z5FB7V9YFtiR5Sg0AwlB6CAH+BLsonJG5lSYPo2rfQP2KJwc7Z5V2xBfgfL bmGg== X-Gm-Message-State: AOAM531KUUNdFJgFogV6Sxbhd20irlxNr565ISYVLxb5OPEu5KTeYZHj 6Dzj3HygoyccIjOHS1GGjVg= X-Google-Smtp-Source: ABdhPJx/uASOFjwBds1/ph6FfwLeKfheauQENnYUswGJ6Fm3QZo2nue45hkAhFodosEtgTJsIcVS/Q== X-Received: by 2002:a05:620a:12f3:: with SMTP id f19mr5581190qkl.306.1625233241917; Fri, 02 Jul 2021 06:40:41 -0700 (PDT) Received: from [192.168.1.201] (pool-74-96-87-9.washdc.fios.verizon.net. [74.96.87.9]) by smtp.googlemail.com with ESMTPSA id p187sm1369285qkd.57.2021.07.02.06.40.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jul 2021 06:40:41 -0700 (PDT) Subject: Re: [RFC PATCH 13/28] cli: lil: Wire up LIL to the rest of U-Boot To: Rasmus Villemoes , u-boot@lists.denx.de, Tom Rini Cc: =?UTF-8?Q?Marek_Beh=c3=ban?= , Wolfgang Denk , Simon Glass , Roland Gaudig , Heinrich Schuchardt , Kostas Michalopoulos References: <20210701061611.957918-1-seanga2@gmail.com> <20210701061611.957918-14-seanga2@gmail.com> From: Sean Anderson Message-ID: <16c7e58f-5ba1-8ae6-d72e-4205e9615e1a@gmail.com> Date: Fri, 2 Jul 2021 09:40:40 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 7/2/21 4:18 AM, Rasmus Villemoes wrote: > On 01/07/2021 08.15, Sean Anderson wrote: >> This sets the shell to LIL when CONFIG_LIL is enabled. Repeated commands >> are not supporteed. Neither are partial commands a la Hush's secondary >> prompt. Setting and getting environmental variables is done through >> callbacks to assist with testing. > > This all looks very interesting, thanks for doing this! > > Re this patch, is there some way LIL and HUSH could coexist, with HUSH > then being the initial shell, and one could then enter a "lil shell" > with the command "lil", just as I can start a busybox shell from bash by > saying "busybox sh". That could make it a bit easier for playing around > with initially. > > I have no idea how hard that is to do with Kconfig. Perhaps make LIL > selectable by itself, then have a hidden symbol LIL_SHELL which is > "default y if LIL && !HUSH_PARSER" or something like that. Yeah, I wanted to do this anyway for unit testing at least. --Sean