[U-Boot-Users] Link problem when CONFIG_NET_MULTI not set

[U-Boot-Users] Link problem when CONFIG_NET_MULTI not set

[Stephen Williams]

The latest CVS doesn't link if CONFIG_NET_MULTI is *not* set.
The problem is NetLoop calls eth_set_current() unconditionally,
but the implementation of that function (in net/eth.c) is not
included if CONFIG_NET_MULTI is undefined.

The attached patch fixes NetLoop to not use eth_set_current if
CONFIG_NET_MULTI is not included. I presume that the function
is compiled to save space and is really not needed in this
case.

CHANGELOG ENTRY:

* Patch by Stephen Williams, 16 April 2004:
   link of eth_set_current fails when CONFIG_NET_MULTI not used.

-- 
Steve Williams                "The woods are lovely, dark and deep.
steve at XXXXXXXXXX           But I have promises to keep,
http://www.XXXXXXXXXX         and lines to code before I sleep,
http://www.picturel.com       And lines to code before I sleep."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot-set_current_missing.patch.gz
Type: application/x-gzip
Size: 308 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040416/d4622dcd/attachment.bin 

[U-Boot-Users] Link problem when CONFIG_NET_MULTI not set

[Wolfgang Denk]

In message <17034-97771@sneakemail.com> you wrote:
> 
> The latest CVS doesn't link if CONFIG_NET_MULTI is *not* set.
> The problem is NetLoop calls eth_set_current() unconditionally,
> but the implementation of that function (in net/eth.c) is not
> included if CONFIG_NET_MULTI is undefined.
> 
> The attached patch fixes NetLoop to not use eth_set_current if
> CONFIG_NET_MULTI is not included. I presume that the function
> is compiled to save space and is really not needed in this
> case.

Already fixed in current CVS. Patch ignored.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
The idea of male and female are universal constants.
	-- Kirk, "Metamorphosis", stardate 3219.8