public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Pavel Herrmann <morpheus.ibis@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fix linker generated lists on non-C locales
Date: Sun, 02 Dec 2012 19:26:02 +0100	[thread overview]
Message-ID: <1719959.kseee5kzIQ@bloomfield> (raw)
In-Reply-To: <201212021912.17415.marex@denx.de>

On Sunday 02 of December 2012 19:12:17 Marek Vasut wrote:
> Dear Pavel Herrmann,
> 
> > On Sunday 02 of December 2012 18:50:53 Marek Vasut wrote:
> > > Dear Pavel Herrmann,
> > > 
> > > > Setting LC_COLLATE=C is not enough if LC_ALL=en_US.utf8. The result is
> > > > a build that has no available commands. Setting LC_ALL=C for the
> > > > generator script helps.
> > > > 
> > > > Signed-off-by: Pavel Herrmann <morpheus.ibis@gmail.com>
> > > > ---
> > > > 
> > > >  helper.mk | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/helper.mk b/helper.mk
> > > > index 79a1da0..2b75182 100644
> > > > --- a/helper.mk
> > > > +++ b/helper.mk
> > > > @@ -35,7 +35,7 @@
> > > > 
> > > >  #    line. Next, append "@" at the end and print the line. Finally,
> > > >  #    append "~" at the end of line. This will make sense in
> > > >  conjunction #    with 6) and 7).
> > > > 
> > > > -# 7) Sort the lines. It is imperative to use LC_COLLATE=C here
> > > > because
> > > > +# 7) Sort the lines. It is imperative to use LC_ALL=C here because
> > > > 
> > > >  #    with this, the "\a" symbol is first and "~" symbol is last. Any
> > > >  #    other symbols fall inbetween. Symbols like "@", which marks the
> > > >  #    end of current line (representing current section) and ".",
> > > >  which
> > > > 
> > > > @@ -57,7 +57,7 @@ $(1): $(2)
> > > > 
> > > >  		-e 's/\.[^\.]\+$$$$//' \
> > > >  		-e ':s /^.\+$$$$/ { p;s/^\(.*\)\.[^\.]*$$$$/\1/;b s }' | \
> > > >  	
> > > >  	sed -n -e 'h;s/$$$$/\a/p;g;s/$$$$/@/p;g;s/$$$$/~/p;' | \
> > > > 
> > > > -	LC_COLLATE=C sort -u | \
> > > > +	LC_ALL=C sort -u | \
> > > 
> > > How will this work? LC_COLLATE is supposed to adjust the behavior of
> > > "sort" command, without it, "sort" will not behave as expected.
> > 
> > Clearly, LC_COLLATE is not enough for it to behave correctly, as seen on
> > my
> > setup.
> > This works because LC_ALL sets LC_COLLATE, as well as all other LC_*
> > environment variables.
> 
> Do you have any reference where I can verify this claim please?

Which claim? that this helps, or that LC_ALL sets LC_COLLATE as well?

  reply	other threads:[~2012-12-02 18:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-02 17:43 [U-Boot] [PATCH] fix linker generated lists on non-C locales Pavel Herrmann
2012-12-02 17:50 ` Marek Vasut
2012-12-02 18:00   ` Pavel Herrmann
2012-12-02 18:12     ` Marek Vasut
2012-12-02 18:26       ` Pavel Herrmann [this message]
2012-12-02 19:13         ` Marek Vasut
2012-12-02 19:39           ` Wolfgang Denk
2012-12-02 18:34       ` Pavel Herrmann
2012-12-02 19:15         ` Marek Vasut
2012-12-02 19:36 ` Wolfgang Denk
2012-12-03  3:57   ` Marek Vasut
2012-12-03 12:26     ` Wolfgang Denk
2012-12-03 14:36       ` Marek Vasut
     [not found] <CAHLo1HsRKfyWhXoEDY4wBZCCjMRQVmhXa2aq3RFx2qQh3M+ZFg@mail.gmail.com>
2013-01-13 20:54 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1719959.kseee5kzIQ@bloomfield \
    --to=morpheus.ibis@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox