From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= <benoit.thebaudeau@advansee.com>
Date: Sat, 11 Aug 2012 16:17:04 +0200 (CEST)
Subject: [U-Boot] [PATCH] mtest: Disable dcache during test
In-Reply-To: <201208102318.46671.vapier@gentoo.org>
Message-ID: <1725235724.2300239.1344694624384.JavaMail.root@advansee.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Mike,

On 08/11/2012 05:18 AM, Mike Frysinger wrote:
> On Friday 10 August 2012 15:16:15 Beno?t Th?baudeau wrote:
> > mtest is supposed to test many types of memory accesses in many
> > different
> > conditions. If dcache is enabled, memory accesses are likely
> > bursts, and
> > some memory accesses are simply skipped. Hence, dcache should be
> > disabled
> > during mtest operation so that what mtest actually tests is not
> > masked by
> > dcache.
> 
> if you want dcache disabled, then why don't you run `dcache off`
> first ?  i
> think it's useful to be able to do both, and forcing it one way is
> wrong.
> 
> thus, NAK from me.
> -mike

Because you will very likely trust mtest and forget about running `dcache off`
first, so you may then be happy about falsely positive mtest results. Moreover,
I can't find any sense or usefulness in running mtest with dcache enabled.

If there is really a need for running mtest with dcache enabled, an option
(disabled by default) could be added to the command line to tell mtest not to
disable dcache.

Best regards,
Beno?t