public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] [PATCH]:arm926ejs: Regression to remove inappropriate LED control code from arch init start.S
@ 2008-05-19 21:26 Daniel Allred
  2008-05-20  5:58 ` Hebbar
  2008-07-05 22:32 ` Wolfgang Denk
  0 siblings, 2 replies; 3+ messages in thread
From: Daniel Allred @ 2008-05-19 21:26 UTC (permalink / raw)
  To: u-boot

cpu/arm926ejs/start.S:

Removed code to LED init since it is not specific to the ARM CPU, but
rather should go in the board/platform specific files.

Signed-off-by: Daniel Allred <djallred <at> gmail...>

--- u-boot-1.3.2/cpu/arm926ejs/start.S.orig	2008-05-19 16:06:06.567184000 -0500
+++ u-boot-1.3.2/cpu/arm926ejs/start.S	2008-05-19 16:06:37.491651200 -0500
@@ -182,9 +182,6 @@ clbss_l:str	r2, [r0]		/* clear loop...
 	cmp	r0, r1
 	ble	clbss_l

-	bl coloured_LED_init
-	bl red_LED_on
-
 	ldr	pc, _start_armboot

 _start_armboot:

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot-Users] [PATCH]:arm926ejs: Regression to remove inappropriate LED control code from arch init start.S
  2008-05-19 21:26 [U-Boot-Users] [PATCH]:arm926ejs: Regression to remove inappropriate LED control code from arch init start.S Daniel Allred
@ 2008-05-20  5:58 ` Hebbar
  2008-07-05 22:32 ` Wolfgang Denk
  1 sibling, 0 replies; 3+ messages in thread
From: Hebbar @ 2008-05-20  5:58 UTC (permalink / raw)
  To: u-boot


Hi,

>>Removed code to LED init since it is not specific to the ARM CPU, but 
>>rather should go in the board/platform specific files. 


I second that

Regards
Gururaja

-- 
View this message in context: http://www.nabble.com/-PATCH-%3Aarm926ejs%3A-Regression-to-remove-inappropriate-LED-control-code-from-arch-init-start.S-tp17328568p17333758.html
Sent from the Uboot - Users mailing list archive at Nabble.com.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot-Users] [PATCH]:arm926ejs: Regression to remove inappropriate LED control code from arch init start.S
  2008-05-19 21:26 [U-Boot-Users] [PATCH]:arm926ejs: Regression to remove inappropriate LED control code from arch init start.S Daniel Allred
  2008-05-20  5:58 ` Hebbar
@ 2008-07-05 22:32 ` Wolfgang Denk
  1 sibling, 0 replies; 3+ messages in thread
From: Wolfgang Denk @ 2008-07-05 22:32 UTC (permalink / raw)
  To: u-boot

In message <fbb4d9c70805191426i3b2ea441r44f442d1fea31607@mail.gmail.com> you wrote:
> cpu/arm926ejs/start.S:
> 
> Removed code to LED init since it is not specific to the ARM CPU, but
> rather should go in the board/platform specific files.
> 
> Signed-off-by: Daniel Allred <djallred <at> gmail...>

Please provide a non-garbled, working mail address in your
Signed-off-by line.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He is truly wise who gains wisdom from another's mishap.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-07-05 22:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-19 21:26 [U-Boot-Users] [PATCH]:arm926ejs: Regression to remove inappropriate LED control code from arch init start.S Daniel Allred
2008-05-20  5:58 ` Hebbar
2008-07-05 22:32 ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox