From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pascal PAILLET-LME <p.paillet@st.com>
Date: Thu, 2 Apr 2020 13:43:04 +0000
Subject: [PATCH V3 12/14] ARM: dts: stm32: Repair PMIC configuration on
 AV96
In-Reply-To: <16c92a9a-1122-5568-dce9-75b13e8946f6@denx.de>
References: <20200331175136.205020-1-marex@denx.de>
 <20200331175136.205020-13-marex@denx.de>
 <845efdc0f66841e98c2af649c36203fd@SFHDAG6NODE3.st.com>
 <7920cb9f-ab01-2a67-83ef-d65119dafff8@denx.de>
 <c86799b6-a418-6e63-b945-f91653be892f@st.com>
 <5c22aef5-cefb-d755-7178-d6a2775a244f@denx.de>
 <73a57dafcc704481aeddd0471cd7f56c@SFHDAG6NODE3.st.com>
 <57c1666e219e4d189714d426359478d0@SFHDAG6NODE2.st.com>
 <16c92a9a-1122-5568-dce9-75b13e8946f6@denx.de>
Message-ID: <17382e354aca45868b866385ea034a2e@SFHDAG6NODE2.st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


> -----Original Message-----
> From: Marek Vasut <marex@denx.de>
> Sent: jeudi 2 avril 2020 15:07
> To: Pascal PAILLET-LME <p.paillet@st.com>; Patrick DELAUNAY
> <patrick.delaunay@st.com>; Patrice CHOTARD <patrice.chotard@st.com>; u-
> boot at lists.denx.de
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>;
> Alexandre TORGUE <alexandre.torgue@st.com>
> Subject: Re: [PATCH V3 12/14] ARM: dts: stm32: Repair PMIC configuration
> on AV96
> 
> On 4/2/20 2:53 PM, Pascal PAILLET-LME wrote:
> > Hi Marek,
> 
> Hi,
> [...]
> >>>>>>>  			vdd: buck3 {
> >>>>>>>  				regulator-name = "vdd";
> >>>>>>> -				regulator-min-microvolt = <3300000>;
> >>>>>>> -				regulator-max-microvolt = <3300000>;
> >>>>>>> +				regulator-min-microvolt = <2900000>;
> >>>>>>> +				regulator-max-microvolt = <2900000>;
> >>>>>>>  				regulator-always-on;
> >>>>>>>  				st,mask_reset;
> >>>>>>>  				regulator-initial-mode = <0>; @@ -
> >> 268,6 +279,7 @@
> >>>>>>>  				regulator-name = "vbus_otg";
> >>>>>>>  				interrupts = <IT_OCP_OTG 0>;
> >>>>>>>  				interrupt-parent = <&pmic>;
> >>>>>>> +				regulator-active-discharge = <1>;
> >>>>>> It seems this setting introduced other-consumption, it should not be
> >> used.
> >>>>> Other-consumption ? What does that mean ?
> >>>>
> >>>> It's a typo, Patrick means over-consumption.
> >>>
> >>> Ah. Do you have any details on that ?
> >>
> >> Sorry for typo.
> >>
> >> No details on my side, it was a Pascal Paillet's direct feedback (Maintainer
> of
> >> STPMIC1 driver in Linux).
> > You can enable the active discharge on the STPMIC1's VBUSOTG. But, as
> soon as a USB host peripheral (such as laptop) will attach and provide VBUS,
> there will be a ~8mA continuous power consumption on VBUS through this
> OTG active discharge. There is no functional issue behind this 8mA; but you
> need to know that 8mA is not compliant with the USB suspend constraint
> (2.5mA max).
> 
> So why is it in there ?
Sorry, I'm not sure to catch your point... The property is available because the stpmic1
Propose this feature (enable a pull down resistor when VBUS_OTG is disabled). We have
Found during some test that it is better to not enable active discharge on vbus_otg.
I hope it answers,
pascal