From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A1CCC433F5 for ; Tue, 16 Nov 2021 14:51:53 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A45A661B3A for ; Tue, 16 Nov 2021 14:51:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A45A661B3A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A9AF983856; Tue, 16 Nov 2021 15:51:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1637074310; bh=It1EQxd7CQNyCZguoOfPqQZJ6BjWkaOxdSQAMafgTxg=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fuiswySDUNN3/zIbSQS1s+4OCG+UIuvl6J5HXjhYesrqjCrzuqIYd9WVXU/h1Kw+U B6iD6A5ANFmJEVKA1cSbwPN5ZTWlGzu5sBf4Qn11+s78D8FYAZ6BgSi17M3rLTuQg+ NFipgNP9aE0Adz3lE/EkfbrsvvuEIVD0M9XxwCCDm2dztD7RNxh5rF/U/epc9iddpd rYZv+hGWdv3d3ZHxC4AAXy+BVv4OD5h34zpoijGeW+S7kTrzVIW6f2ADILeH7VP1te ptsw4YXwZbsWicjrnyNzqj2AuXWnVlC/pcJNgiTeb0Rogild04gtFEuSlRalbmjFi4 wWb55L7MFEyJw== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 7FD7783856 for ; Tue, 16 Nov 2021 15:51:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1637074308; bh=It1EQxd7CQNyCZguoOfPqQZJ6BjWkaOxdSQAMafgTxg=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=y14VVlqbS7VluepAv+nsf4sEUQsaKNqY+Ub8MfTTaIIT+9dpTZbUVw9tSOyoxSMd7 LOOYJ9DPfOA4INMSs15ABXVti0zroxqjsxahZTtcjLSaq6U1xqBxvUau+OUCwpONYj f0QYocK6L4vJFV2iJg+AOlHfVD21WWyRLobeLHyRVeHid3toyEltXCtReXVB+UhlOo /enGyhGRgMP9ZtbBs82gQlE4Rf1wEddkcKfBexjialV7u+M+6gqPeNcrwES1jSZ09P MBakwmG/f8VFGw0bfHas1bVk1SXQCJJHO0Ig1Yb14ETCCryrmMZOGoSDSADYVyKFCO ROPdy2e9ZJ7rg== Received: by janitor.denx.de (Postfix, from userid 108) id A7C67A0120; Tue, 16 Nov 2021 15:51:47 +0100 (CET) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id F2DF9A005E; Tue, 16 Nov 2021 15:51:39 +0100 (CET) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 91A411E0CB7; Tue, 16 Nov 2021 15:51:39 +0100 (CET) To: Tom Rini cc: Ramon Fried , Marek Vasut , Michael Walle , U-Boot Mailing List , Grygorii Strashko , Michal Simek , fried.dev@gmail.com, Joe Hershberger , Simon Glass From: Wolfgang Denk Subject: Re: [PATCH RFC] cmd: fix net list command MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20211116141030.GC24579@bill-the-cat> References: <257391f0-9d69-62cc-2353-8f4fc0751d7d@denx.de> <1646331.1636986670@gemini.denx.de> <1649428.1636989301@gemini.denx.de> <3dd9bee3879377db10e3398ab7aeb46c@walle.cc> <1732641.1637069581@gemini.denx.de> <20211116141030.GC24579@bill-the-cat> Comments: In-reply-to Tom Rini message dated "Tue, 16 Nov 2021 09:10:30 -0500." Date: Tue, 16 Nov 2021 15:51:39 +0100 Message-ID: <1738949.1637074299@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Tom, In message <20211116141030.GC24579@bill-the-cat> you wrote: > > One thing I'm not totally sure on yet is, looking at the README I see: > "If Ethernet drivers implement the 'write_hwaddr' function, valid MAC > addresses will be programmed into hardware as part of the initialization > process. This may be skipped by setting the appropriate 'ethmacskip' > environment variable. The naming convention is as follows: "ethmacskip" > (=>eth0), "eth1macskip" (=>eth1) etc." I have to admit that until now I was not even aware of these variables... > As I'm sure that predates device trees being used to the extent they are > now, should 'ethmacskip' be involved in the "fixup the device tree" > logic, and appropriate rST / Kconfig help text updated? My first > reaction is that in spirit, this is how to solve Michael's use case and > README / doc/README.enetaddr do not specify when/why the "also fixup the > device tree if it exists" is done. Apparently this logic was added more than 10 years ago in commit ecee9324d "Program net device MAC addresses after initializing". I think it does not change anything to the logic that Linux uses the MAC address passed by U-Boot. Whether U-Boot also writes some MAC address to the device's persistent storage is an independent act. If there already was an addressed stored there befoire it would not have been read by Linux, so the same should happen here. [Here it is even less problematic as U-Boot has the very same MAC address in it's environment.] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Everyting looks interesting until you do it. Then you find it's just another job. - Terry Pratchett, _Moving Pictures_