From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEA5EC433F5 for ; Tue, 16 Nov 2021 14:57:00 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABCA861B3A for ; Tue, 16 Nov 2021 14:56:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ABCA861B3A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BF6CB838F3; Tue, 16 Nov 2021 15:56:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1637074618; bh=0+GKyjKXD9q5LvcqXaHAMf68Z/SJwyMDvht9HcD2yWo=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=eV71kTaZ8F6BpaVggjzrcMj3sE+6RD2zvUqAFduuwSPBoM7CWmLz/lJ73z5Sw07zY TnOQIQ2MRE14cn7+/cT5pTIJlZVkHqYpGVVi2diN2Sl9TAyi9GhIi7yH4vjiOvVSP+ FcgwoOxGOfWwhO+C/6yc/z0BH+HuzGcx11yeqHAfb8LnOYQXEofs1GSVgp+dZPrdRz nU6BKehUEcZD29ufwuZ0gEBLuJFmp4bWe+zlX5oixLu3Ek3YXptJ3UpWSEKMi1z9MY LRLKQCT9YVHwm16P38oauLdPd6KqaHaYth1LlMIpDiJKQh+coOe3osmn279CaKmMbl okfj99hBqhVnw== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 83A4B838F3 for ; Tue, 16 Nov 2021 15:56:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1637074615; bh=0+GKyjKXD9q5LvcqXaHAMf68Z/SJwyMDvht9HcD2yWo=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=yvQ/7v3hLNdFx/2nXpydxnmSQfifBt2K/nG9HuAhUrwnetpN29YcEMBDPt+cqhatM 3r7xbkIGkm8ehLZyX3ygXJNTVp/4/qSxLi9fLfRuwxdLMj2sB2Gr8fXHH5dTRlxHGS 6rnDjTFqTY5sr9GTgXmCuxdwesTNUbg3X9FRBoIBBBSXWFbmSzb5SjeMD8+4cf7WsX qcXUnL1y5b2QxDCS4hZXoFYmq8d73cEB9MJX5fM4m71a9jHl3xLYo6unvSfdstufak ESs/KEmqo5pykEbcqfqbU+Zh+HQVirvdeCU+9jsKQbd0pTegBeYkfqqH4znY0r1mJp aa6AiIl2/stVA== Received: by janitor.denx.de (Postfix, from userid 108) id 2E558A0275; Tue, 16 Nov 2021 15:56:55 +0100 (CET) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 8F4B0A005E; Tue, 16 Nov 2021 15:56:45 +0100 (CET) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 7D54D1E0CB7; Tue, 16 Nov 2021 15:56:45 +0100 (CET) To: Tom Rini cc: Michael Walle , Ramon Fried , Michal Simek , Grygorii Strashko , git , Joe Hershberger , Simon Glass , U-Boot Mailing List From: Wolfgang Denk Subject: Re: [PATCH] net: uclass: Save ethernet MAC address when generated MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20211116141855.GD24579@bill-the-cat> References: <20211102090015.2395446-1-michael@walle.cc> <1d5f84ab-e481-8779-4b5b-adfbc4ff3bf3@ti.com> <07b688d8-f05f-d11e-5e3e-e5454e1c9af0@xilinx.com> <5fd1c7f2-d37d-3008-06d3-877958aa9757@xilinx.com> <610dcc295f1f9f8eb609269ac5a2e0d8@walle.cc> <97cbcf456d2fa9572ef0d0c9adc7380b@walle.cc> <20211116141855.GD24579@bill-the-cat> Comments: In-reply-to Tom Rini message dated "Tue, 16 Nov 2021 09:18:55 -0500." Date: Tue, 16 Nov 2021 15:56:45 +0100 Message-ID: <1739526.1637074605@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Tom, In message <20211116141855.GD24579@bill-the-cat> you wrote: > > So, to quote lib/Kconfig: > config NET_RANDOM_ETHADDR > bool "Random ethaddr if unset" > help > Selecting this will allow the Ethernet interface to function > even when the ethaddr variable for that interface is unset. > A new MAC address will be generated on every boot and it will > not be added to the environment. This description is at least incomplete, because it makes no difference between the persistent copy of the environment and it's in-memory copy. For network to function, I think the MAC address must be stored in the in-memory copy of the environment. > We need either a re-spin or follow-up as we're changing the documented > behavior. And as I mentioned in the other thread related on-going > thread, perhaps "ethmacskip" should play a role in preserving existing > behavior? We have way too many ways to do the same thing - nearly, just a little different :-( Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de "A little knowledge is a dangerous thing." - Doug Gwyn