[PATCH] i2c: davinci: drop unnecessary parentheses in REG(&…)

[PATCH] i2c: davinci: drop unnecessary parentheses in REG(&…)

[Bhimeswararao Matsa]

Signed-off-by: Bhimeswararao Matsa <bhimeswararao.matsa@gmail.com>
---
 drivers/i2c/davinci_i2c.c | 118 +++++++++++++++++++-------------------
 1 file changed, 59 insertions(+), 59 deletions(-)

diff --git a/drivers/i2c/davinci_i2c.c b/drivers/i2c/davinci_i2c.c
index ffd0dd0b282..caf5fbcc346 100644
--- a/drivers/i2c/davinci_i2c.c
+++ b/drivers/i2c/davinci_i2c.c
@@ -41,20 +41,20 @@ static int _wait_for_bus(struct i2c_regs *i2c_base)
 {
 	int	stat, timeout;
 
-	REG(&(i2c_base->i2c_stat)) = 0xffff;
+	REG(&i2c_base->i2c_stat) = 0xffff;
 
 	for (timeout = 0; timeout < 10; timeout++) {
-		stat = REG(&(i2c_base->i2c_stat));
+		stat = REG(&i2c_base->i2c_stat);
 		if (!((stat) & I2C_STAT_BB)) {
-			REG(&(i2c_base->i2c_stat)) = 0xffff;
+			REG(&i2c_base->i2c_stat) = 0xffff;
 			return 0;
 		}
 
-		REG(&(i2c_base->i2c_stat)) = stat;
+		REG(&i2c_base->i2c_stat) = stat;
 		mdelay(50);
 	}
 
-	REG(&(i2c_base->i2c_stat)) = 0xffff;
+	REG(&i2c_base->i2c_stat) = 0xffff;
 	return 1;
 }
 
@@ -64,23 +64,23 @@ static int _poll_i2c_irq(struct i2c_regs *i2c_base, int mask)
 
 	for (timeout = 0; timeout < 10; timeout++) {
 		mdelay(1);
-		stat = REG(&(i2c_base->i2c_stat));
+		stat = REG(&i2c_base->i2c_stat);
 		if (stat & mask)
 			return stat;
 	}
 
-	REG(&(i2c_base->i2c_stat)) = 0xffff;
+	REG(&i2c_base->i2c_stat) = 0xffff;
 	return stat | I2C_TIMEOUT;
 }
 
 static void _flush_rx(struct i2c_regs *i2c_base)
 {
 	while (1) {
-		if (!(REG(&(i2c_base->i2c_stat)) & I2C_STAT_RRDY))
+		if (!(REG(&i2c_base->i2c_stat) & I2C_STAT_RRDY))
 			break;
 
-		REG(&(i2c_base->i2c_drr));
-		REG(&(i2c_base->i2c_stat)) = I2C_STAT_RRDY;
+		REG(&i2c_base->i2c_drr);
+		REG(&i2c_base->i2c_stat) = I2C_STAT_RRDY;
 		mdelay(1);
 	}
 }
@@ -93,9 +93,9 @@ static uint _davinci_i2c_setspeed(struct i2c_regs *i2c_base,
 	psc = 2;
 	/* SCLL + SCLH */
 	div = (CFG_SYS_HZ_CLOCK / ((psc + 1) * speed)) - 10;
-	REG(&(i2c_base->i2c_psc)) = psc; /* 27MHz / (2 + 1) = 9MHz */
-	REG(&(i2c_base->i2c_scll)) = (div * 50) / 100; /* 50% Duty */
-	REG(&(i2c_base->i2c_sclh)) = div - REG(&(i2c_base->i2c_scll));
+	REG(&i2c_base->i2c_psc) = psc; /* 27MHz / (2 + 1) = 9MHz */
+	REG(&i2c_base->i2c_scll) = (div * 50) / 100; /* 50% Duty */
+	REG(&i2c_base->i2c_sclh) = div - REG(&i2c_base->i2c_scll);
 
 	return 0;
 }
@@ -103,22 +103,22 @@ static uint _davinci_i2c_setspeed(struct i2c_regs *i2c_base,
 static void _davinci_i2c_init(struct i2c_regs *i2c_base,
 			      uint speed, int slaveadd)
 {
-	if (REG(&(i2c_base->i2c_con)) & I2C_CON_EN) {
-		REG(&(i2c_base->i2c_con)) = 0;
+	if (REG(&i2c_base->i2c_con) & I2C_CON_EN) {
+		REG(&i2c_base->i2c_con) = 0;
 		mdelay(50);
 	}
 
 	_davinci_i2c_setspeed(i2c_base, speed);
 
-	REG(&(i2c_base->i2c_oa)) = slaveadd;
-	REG(&(i2c_base->i2c_cnt)) = 0;
+	REG(&i2c_base->i2c_oa) = slaveadd;
+	REG(&i2c_base->i2c_cnt) = 0;
 
 	/* Interrupts must be enabled or I2C module won't work */
-	REG(&(i2c_base->i2c_ie)) = I2C_IE_SCD_IE | I2C_IE_XRDY_IE |
+	REG(&i2c_base->i2c_ie) = I2C_IE_SCD_IE | I2C_IE_XRDY_IE |
 		I2C_IE_RRDY_IE | I2C_IE_ARDY_IE | I2C_IE_NACK_IE;
 
 	/* Now enable I2C controller (get it out of reset) */
-	REG(&(i2c_base->i2c_con)) = I2C_CON_EN;
+	REG(&i2c_base->i2c_con) = I2C_CON_EN;
 
 	mdelay(1);
 }
@@ -140,9 +140,9 @@ static int _davinci_i2c_read(struct i2c_regs *i2c_base, u8 chip,
 	if (alen != 0) {
 		/* Start address phase */
 		tmp = I2C_CON_EN | I2C_CON_MST | I2C_CON_STT | I2C_CON_TRX;
-		REG(&(i2c_base->i2c_cnt)) = alen;
-		REG(&(i2c_base->i2c_sa)) = chip;
-		REG(&(i2c_base->i2c_con)) = tmp;
+		REG(&i2c_base->i2c_cnt) = alen;
+		REG(&i2c_base->i2c_sa) = chip;
+		REG(&i2c_base->i2c_con) = tmp;
 
 		tmp = _poll_i2c_irq(i2c_base, I2C_STAT_XRDY | I2C_STAT_NACK);
 
@@ -152,9 +152,9 @@ static int _davinci_i2c_read(struct i2c_regs *i2c_base, u8 chip,
 		case 2:
 			/* Send address MSByte */
 			if (tmp & I2C_STAT_XRDY) {
-				REG(&(i2c_base->i2c_dxr)) = (addr >> 8) & 0xff;
+				REG(&i2c_base->i2c_dxr) = (addr >> 8) & 0xff;
 			} else {
-				REG(&(i2c_base->i2c_con)) = 0;
+				REG(&i2c_base->i2c_con) = 0;
 				return 1;
 			}
 
@@ -166,9 +166,9 @@ static int _davinci_i2c_read(struct i2c_regs *i2c_base, u8 chip,
 		case 1:
 			/* Send address LSByte */
 			if (tmp & I2C_STAT_XRDY) {
-				REG(&(i2c_base->i2c_dxr)) = addr & 0xff;
+				REG(&i2c_base->i2c_dxr) = addr & 0xff;
 			} else {
-				REG(&(i2c_base->i2c_con)) = 0;
+				REG(&i2c_base->i2c_con) = 0;
 				return 1;
 			}
 
@@ -178,7 +178,7 @@ static int _davinci_i2c_read(struct i2c_regs *i2c_base, u8 chip,
 			CHECK_NACK();
 
 			if (!(tmp & I2C_STAT_ARDY)) {
-				REG(&(i2c_base->i2c_con)) = 0;
+				REG(&i2c_base->i2c_con) = 0;
 				return 1;
 			}
 		}
@@ -186,9 +186,9 @@ static int _davinci_i2c_read(struct i2c_regs *i2c_base, u8 chip,
 
 	/* Address phase is over, now read 'len' bytes and stop */
 	tmp = I2C_CON_EN | I2C_CON_MST | I2C_CON_STT | I2C_CON_STP;
-	REG(&(i2c_base->i2c_cnt)) = len & 0xffff;
-	REG(&(i2c_base->i2c_sa)) = chip;
-	REG(&(i2c_base->i2c_con)) = tmp;
+	REG(&i2c_base->i2c_cnt) = len & 0xffff;
+	REG(&i2c_base->i2c_sa) = chip;
+	REG(&i2c_base->i2c_con) = tmp;
 
 	for (i = 0; i < len; i++) {
 		tmp = _poll_i2c_irq(i2c_base, I2C_STAT_RRDY | I2C_STAT_NACK |
@@ -197,9 +197,9 @@ static int _davinci_i2c_read(struct i2c_regs *i2c_base, u8 chip,
 		CHECK_NACK();
 
 		if (tmp & I2C_STAT_RRDY) {
-			buf[i] = REG(&(i2c_base->i2c_drr));
+			buf[i] = REG(&i2c_base->i2c_drr);
 		} else {
-			REG(&(i2c_base->i2c_con)) = 0;
+			REG(&i2c_base->i2c_con) = 0;
 			return 1;
 		}
 	}
@@ -209,14 +209,14 @@ static int _davinci_i2c_read(struct i2c_regs *i2c_base, u8 chip,
 	CHECK_NACK();
 
 	if (!(tmp & I2C_STAT_SCD)) {
-		REG(&(i2c_base->i2c_con)) = 0;
+		REG(&i2c_base->i2c_con) = 0;
 		return 1;
 	}
 
 	_flush_rx(i2c_base);
-	REG(&(i2c_base->i2c_stat)) = 0xffff;
-	REG(&(i2c_base->i2c_cnt)) = 0;
-	REG(&(i2c_base->i2c_con)) = 0;
+	REG(&i2c_base->i2c_stat) = 0xffff;
+	REG(&i2c_base->i2c_cnt) = 0;
+	REG(&i2c_base->i2c_con) = 0;
 
 	return 0;
 }
@@ -242,10 +242,10 @@ static int _davinci_i2c_write(struct i2c_regs *i2c_base, u8 chip,
 	/* Start address phase */
 	tmp = I2C_CON_EN | I2C_CON_MST | I2C_CON_STT |
 		I2C_CON_TRX | I2C_CON_STP;
-	REG(&(i2c_base->i2c_cnt)) = (alen == 0) ?
+	REG(&i2c_base->i2c_cnt) = (alen == 0) ?
 		len & 0xffff : (len & 0xffff) + alen;
-	REG(&(i2c_base->i2c_sa)) = chip;
-	REG(&(i2c_base->i2c_con)) = tmp;
+	REG(&i2c_base->i2c_sa) = chip;
+	REG(&i2c_base->i2c_con) = tmp;
 
 	switch (alen) {
 	case 2:
@@ -255,9 +255,9 @@ static int _davinci_i2c_write(struct i2c_regs *i2c_base, u8 chip,
 		CHECK_NACK();
 
 		if (tmp & I2C_STAT_XRDY) {
-			REG(&(i2c_base->i2c_dxr)) = (addr >> 8) & 0xff;
+			REG(&i2c_base->i2c_dxr) = (addr >> 8) & 0xff;
 		} else {
-			REG(&(i2c_base->i2c_con)) = 0;
+			REG(&i2c_base->i2c_con) = 0;
 			return 1;
 		}
 		/* No break, fall through */
@@ -268,9 +268,9 @@ static int _davinci_i2c_write(struct i2c_regs *i2c_base, u8 chip,
 		CHECK_NACK();
 
 		if (tmp & I2C_STAT_XRDY) {
-			REG(&(i2c_base->i2c_dxr)) = addr & 0xff;
+			REG(&i2c_base->i2c_dxr) = addr & 0xff;
 		} else {
-			REG(&(i2c_base->i2c_con)) = 0;
+			REG(&i2c_base->i2c_con) = 0;
 			return 1;
 		}
 	}
@@ -281,7 +281,7 @@ static int _davinci_i2c_write(struct i2c_regs *i2c_base, u8 chip,
 		CHECK_NACK();
 
 		if (tmp & I2C_STAT_XRDY)
-			REG(&(i2c_base->i2c_dxr)) = buf[i];
+			REG(&i2c_base->i2c_dxr) = buf[i];
 		else
 			return 1;
 	}
@@ -291,14 +291,14 @@ static int _davinci_i2c_write(struct i2c_regs *i2c_base, u8 chip,
 	CHECK_NACK();
 
 	if (!(tmp & I2C_STAT_SCD)) {
-		REG(&(i2c_base->i2c_con)) = 0;
+		REG(&i2c_base->i2c_con) = 0;
 		return 1;
 	}
 
 	_flush_rx(i2c_base);
-	REG(&(i2c_base->i2c_stat)) = 0xffff;
-	REG(&(i2c_base->i2c_cnt)) = 0;
-	REG(&(i2c_base->i2c_con)) = 0;
+	REG(&i2c_base->i2c_stat) = 0xffff;
+	REG(&i2c_base->i2c_cnt) = 0;
+	REG(&i2c_base->i2c_con) = 0;
 
 	return 0;
 }
@@ -307,35 +307,35 @@ static int _davinci_i2c_probe_chip(struct i2c_regs *i2c_base, u8 chip)
 {
 	int	rc = 1;
 
-	if (chip == REG(&(i2c_base->i2c_oa)))
+	if (chip == REG(&i2c_base->i2c_oa))
 		return rc;
 
-	REG(&(i2c_base->i2c_con)) = 0;
+	REG(&i2c_base->i2c_con) = 0;
 	if (_wait_for_bus(i2c_base))
 		return 1;
 
 	/* try to read one byte from current (or only) address */
-	REG(&(i2c_base->i2c_cnt)) = 1;
-	REG(&(i2c_base->i2c_sa))  = chip;
-	REG(&(i2c_base->i2c_con)) = (I2C_CON_EN | I2C_CON_MST | I2C_CON_STT |
+	REG(&i2c_base->i2c_cnt) = 1;
+	REG(&i2c_base->i2c_sa)  = chip;
+	REG(&i2c_base->i2c_con) = (I2C_CON_EN | I2C_CON_MST | I2C_CON_STT |
 				     I2C_CON_STP);
 	mdelay(50);
 
-	if (!(REG(&(i2c_base->i2c_stat)) & I2C_STAT_NACK)) {
+	if (!(REG(&i2c_base->i2c_stat) & I2C_STAT_NACK)) {
 		rc = 0;
 		_flush_rx(i2c_base);
-		REG(&(i2c_base->i2c_stat)) = 0xffff;
+		REG(&i2c_base->i2c_stat) = 0xffff;
 	} else {
-		REG(&(i2c_base->i2c_stat)) = 0xffff;
-		REG(&(i2c_base->i2c_con)) |= I2C_CON_STP;
+		REG(&i2c_base->i2c_stat) = 0xffff;
+		REG(&i2c_base->i2c_con) |= I2C_CON_STP;
 		mdelay(20);
 		if (_wait_for_bus(i2c_base))
 			return 1;
 	}
 
 	_flush_rx(i2c_base);
-	REG(&(i2c_base->i2c_stat)) = 0xffff;
-	REG(&(i2c_base->i2c_cnt)) = 0;
+	REG(&i2c_base->i2c_stat) = 0xffff;
+	REG(&i2c_base->i2c_cnt) = 0;
 	return rc;
 }
 
-- 
2.43.0

[PATCH] i2c: davinci: prefer kernel types (u8/u32)

[Bhimeswararao Matsa]

Replace uint8_t/uint32_t with u8/u32 to match U-Boot style
(checkpatch PREFER_KERNEL_TYPES). No functional change.

Signed-off-by: Bhimeswararao Matsa <bhimeswararao.matsa@gmail.com>
---
 drivers/i2c/davinci_i2c.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/drivers/i2c/davinci_i2c.c b/drivers/i2c/davinci_i2c.c
index 39132747208..9bba0600e3e 100644
--- a/drivers/i2c/davinci_i2c.c
+++ b/drivers/i2c/davinci_i2c.c
@@ -19,6 +19,7 @@
 #include <asm/arch/i2c_defs.h>
 #include <asm/io.h>
 #include <linux/delay.h>
+#include <linux/types.h>
 #include "davinci_i2c.h"
 
 /* Information about i2c controller */
@@ -87,7 +88,7 @@ static void _flush_rx(struct i2c_regs *i2c_base)
 static uint _davinci_i2c_setspeed(struct i2c_regs *i2c_base,
 				  uint speed)
 {
-	uint32_t	div, psc;
+	u32	div, psc;
 
 	psc = 2;
 	/* SCLL + SCLH */
@@ -122,10 +123,10 @@ static void _davinci_i2c_init(struct i2c_regs *i2c_base,
 	udelay(1000);
 }
 
-static int _davinci_i2c_read(struct i2c_regs *i2c_base, uint8_t chip,
-			     uint32_t addr, int alen, uint8_t *buf, int len)
+static int _davinci_i2c_read(struct i2c_regs *i2c_base, u8 chip,
+			     u32 addr, int alen, u8 *buf, int len)
 {
-	uint32_t	tmp;
+	u32	tmp;
 	int		i;
 
 	if ((alen < 0) || (alen > 2)) {
@@ -220,10 +221,10 @@ static int _davinci_i2c_read(struct i2c_regs *i2c_base, uint8_t chip,
 	return 0;
 }
 
-static int _davinci_i2c_write(struct i2c_regs *i2c_base, uint8_t chip,
-			      uint32_t addr, int alen, uint8_t *buf, int len)
+static int _davinci_i2c_write(struct i2c_regs *i2c_base, u8 chip,
+			      u32 addr, int alen, u8 *buf, int len)
 {
-	uint32_t	tmp;
+	u32	tmp;
 	int		i;
 
 	if ((alen < 0) || (alen > 2)) {
@@ -302,7 +303,7 @@ static int _davinci_i2c_write(struct i2c_regs *i2c_base, uint8_t chip,
 	return 0;
 }
 
-static int _davinci_i2c_probe_chip(struct i2c_regs *i2c_base, uint8_t chip)
+static int _davinci_i2c_probe_chip(struct i2c_regs *i2c_base, u8 chip)
 {
 	int	rc = 1;
 
-- 
2.43.0

[PATCH] i2c: davinci: use mdelay() for multi-millisecond waits

[Bhimeswararao Matsa]

Signed-off-by: Bhimeswararao Matsa <bhimeswararao.matsa@gmail.com>
---
 drivers/i2c/davinci_i2c.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/i2c/davinci_i2c.c b/drivers/i2c/davinci_i2c.c
index 9bba0600e3e..ffd0dd0b282 100644
--- a/drivers/i2c/davinci_i2c.c
+++ b/drivers/i2c/davinci_i2c.c
@@ -51,7 +51,7 @@ static int _wait_for_bus(struct i2c_regs *i2c_base)
 		}
 
 		REG(&(i2c_base->i2c_stat)) = stat;
-		udelay(50000);
+		mdelay(50);
 	}
 
 	REG(&(i2c_base->i2c_stat)) = 0xffff;
@@ -63,7 +63,7 @@ static int _poll_i2c_irq(struct i2c_regs *i2c_base, int mask)
 	int	stat, timeout;
 
 	for (timeout = 0; timeout < 10; timeout++) {
-		udelay(1000);
+		mdelay(1);
 		stat = REG(&(i2c_base->i2c_stat));
 		if (stat & mask)
 			return stat;
@@ -81,7 +81,7 @@ static void _flush_rx(struct i2c_regs *i2c_base)
 
 		REG(&(i2c_base->i2c_drr));
 		REG(&(i2c_base->i2c_stat)) = I2C_STAT_RRDY;
-		udelay(1000);
+		mdelay(1);
 	}
 }
 
@@ -105,7 +105,7 @@ static void _davinci_i2c_init(struct i2c_regs *i2c_base,
 {
 	if (REG(&(i2c_base->i2c_con)) & I2C_CON_EN) {
 		REG(&(i2c_base->i2c_con)) = 0;
-		udelay(50000);
+		mdelay(50);
 	}
 
 	_davinci_i2c_setspeed(i2c_base, speed);
@@ -120,7 +120,7 @@ static void _davinci_i2c_init(struct i2c_regs *i2c_base,
 	/* Now enable I2C controller (get it out of reset) */
 	REG(&(i2c_base->i2c_con)) = I2C_CON_EN;
 
-	udelay(1000);
+	mdelay(1);
 }
 
 static int _davinci_i2c_read(struct i2c_regs *i2c_base, u8 chip,
@@ -319,7 +319,7 @@ static int _davinci_i2c_probe_chip(struct i2c_regs *i2c_base, u8 chip)
 	REG(&(i2c_base->i2c_sa))  = chip;
 	REG(&(i2c_base->i2c_con)) = (I2C_CON_EN | I2C_CON_MST | I2C_CON_STT |
 				     I2C_CON_STP);
-	udelay(50000);
+	mdelay(50);
 
 	if (!(REG(&(i2c_base->i2c_stat)) & I2C_STAT_NACK)) {
 		rc = 0;
@@ -328,7 +328,7 @@ static int _davinci_i2c_probe_chip(struct i2c_regs *i2c_base, u8 chip)
 	} else {
 		REG(&(i2c_base->i2c_stat)) = 0xffff;
 		REG(&(i2c_base->i2c_con)) |= I2C_CON_STP;
-		udelay(20000);
+		mdelay(20);
 		if (_wait_for_bus(i2c_base))
 			return 1;
 	}
-- 
2.43.0

[PATCH] mmc: core: drop space before newline in trace printf

[Bhimeswararao Matsa]

Remove unnecessary whitespace before '\n' in trace printf
format strings (checkpatch warning QUOTED_WHITESPACE_BEFORE_NEWLINE).

No functional change intended.

Signed-off-by: Bhimeswararao Matsa <bhimeswararao.matsa@gmail.com>
---
 drivers/mmc/mmc.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index 5f2efbe6df9..20afcffde3d 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -125,21 +125,21 @@ void mmmc_trace_after_send(struct mmc *mmc, struct mmc_cmd *cmd, int ret)
 			printf("\t\tMMC_RSP_NONE\n");
 			break;
 		case MMC_RSP_R1:
-			printf("\t\tMMC_RSP_R1,5,6,7 \t 0x%08x \n",
+			printf("\t\tMMC_RSP_R1,5,6,7 \t 0x%08x\n",
 				cmd->response[0]);
 			break;
 		case MMC_RSP_R1b:
-			printf("\t\tMMC_RSP_R1b\t\t 0x%08x \n",
+			printf("\t\tMMC_RSP_R1b\t\t 0x%08x\n",
 				cmd->response[0]);
 			break;
 		case MMC_RSP_R2:
-			printf("\t\tMMC_RSP_R2\t\t 0x%08x \n",
+			printf("\t\tMMC_RSP_R2\t\t 0x%08x\n",
 				cmd->response[0]);
-			printf("\t\t          \t\t 0x%08x \n",
+			printf("\t\t          \t\t 0x%08x\n",
 				cmd->response[1]);
-			printf("\t\t          \t\t 0x%08x \n",
+			printf("\t\t          \t\t 0x%08x\n",
 				cmd->response[2]);
-			printf("\t\t          \t\t 0x%08x \n",
+			printf("\t\t          \t\t 0x%08x\n",
 				cmd->response[3]);
 			printf("\n");
 			printf("\t\t\t\t\tDUMPING DATA\n");
@@ -154,7 +154,7 @@ void mmmc_trace_after_send(struct mmc *mmc, struct mmc_cmd *cmd, int ret)
 			}
 			break;
 		case MMC_RSP_R3:
-			printf("\t\tMMC_RSP_R3,4\t\t 0x%08x \n",
+			printf("\t\tMMC_RSP_R3,4\t\t 0x%08x\n",
 				cmd->response[0]);
 			break;
 		default:
-- 
2.43.0

Re: [PATCH] mmc: core: drop space before newline in trace printf

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>


On Fri, 29 Aug 2025 07:41:31 +0530, Bhimeswararao Matsa wrote:
> Remove unnecessary whitespace before '\n' in trace printf
> format strings (checkpatch warning QUOTED_WHITESPACE_BEFORE_NEWLINE).
> 
> No functional change intended.
> 
> 

Applied, thanks!

[1/1] mmc: core: drop space before newline in trace printf
      commit: 140562d3a2b447079499d773a7d21ec1728692cb

Best regards,
-- 
Peng Fan <peng.fan@nxp.com>