From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ajay Bhargav Date: Fri, 7 Oct 2011 10:19:48 +0530 (IST) Subject: [U-Boot] [PATCH] mmc: CMD7:MMC_CMD_SELECT_CARD response fix In-Reply-To: <1317820403-27846-1-git-send-email-ajay.bhargav@einfochips.com> Message-ID: <1775205980.174905.1317962988131.JavaMail.root@ahm.einfochips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de ----- "Ajay Bhargav" wrote: > As per JEDEC document JESD84-A441 (page 105) response for CMD7 > (MMC_CMD_SELECT_CARD) response should be R1 instead of R1b. In uboot > we > never take MMC to disconnected state and on powerup its always ideal > state which later goes to stand-by state. > > from document footnote: > R1 while selecting from Stand-By State to Transfer State; R1b while > selecting from Disconnected State to Programming State. > > Signed-off-by: Ajay Bhargav > --- > drivers/mmc/mmc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c > index e384399..79d00f6 100644 > --- a/drivers/mmc/mmc.c > +++ b/drivers/mmc/mmc.c > @@ -987,7 +987,7 @@ int mmc_startup(struct mmc *mmc) > /* Select the card, and put it into Transfer Mode */ > if (!mmc_host_is_spi(mmc)) { /* cmd not supported in spi */ > cmd.cmdidx = MMC_CMD_SELECT_CARD; > - cmd.resp_type = MMC_RSP_R1b; > + cmd.resp_type = MMC_RSP_R1; > cmd.cmdarg = mmc->rca << 16; > cmd.flags = 0; > err = mmc_send_cmd(mmc, &cmd, NULL); > -- > 1.7.0.4 any comments on this patch?? Regards, Ajay Bhargav