From: "Heiko Stübner" <heiko@sntech.de>
To: u-boot@lists.denx.de
Subject: [PATCH v2 7/7] rockchip: make_fit_atf: add signature handling
Date: Wed, 06 May 2020 10:55:57 +0200 [thread overview]
Message-ID: <1796995.eNl2sZyQD1@diego> (raw)
In-Reply-To: <7fba924d-ad6b-8397-34ed-53609fb8892a@rock-chips.com>
Hi Kever,
Am Freitag, 1. Mai 2020, 12:32:23 CEST schrieb Kever Yang:
>
> On 2020/4/21 ??8:23, Heiko Stuebner wrote:
> > From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> >
> > If the newly added fit-generator key-options are found, append needed
> > signature nodes to all generated image blocks, so that they can get
> > signed when mkimage later compiles the .itb from the generated .its.
> >
> > Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> > ---
> > arch/arm/mach-rockchip/make_fit_atf.py | 51 +++++++++++++++++++++++++-
> > 1 file changed, 50 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-rockchip/make_fit_atf.py b/arch/arm/mach-rockchip/make_fit_atf.py
> > index d15c32b303..5b353f9d0a 100755
> > --- a/arch/arm/mach-rockchip/make_fit_atf.py
> > +++ b/arch/arm/mach-rockchip/make_fit_atf.py
> > @@ -14,6 +14,8 @@ import sys
> > import getopt
> > import logging
> > import struct
> > +import Crypto
> > +from Crypto.PublicKey import RSA
> >
>
> +Traceback (most recent call last):
> 1395
> <https://gitlab.denx.de/u-boot/custodians/u-boot-rockchip/-/jobs/86952#L1395>+
> File "arch/arm/mach-rockchip/make_fit_atf.py", line 17, in <module>
> 1396
> <https://gitlab.denx.de/u-boot/custodians/u-boot-rockchip/-/jobs/86952#L1396>+
> import Crypto
> 1397
> <https://gitlab.denx.de/u-boot/custodians/u-boot-rockchip/-/jobs/86952#L1397>+ModuleNotFoundError:
> No module named 'Crypto'
>
>
> Please help to update .gitlab-ci.yml, or else it will report the error.
I'm not sure, how ... i.e. the missing package is
"pycrypto" (or "python-crypto" when installing from a distribution package)
So I guess it's about adding that dependency to both .travis.yml and
.gitlab-ci.yml, but is it enough to just do a
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index beaf9b9042..863c3dea51 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -68,6 +68,7 @@ build all 64bit ARM platforms:
- virtualenv -p /usr/bin/python3 /tmp/venv
- . /tmp/venv/bin/activate
- pip install pyelftools
+ - pip install pycrypto
- ret=0;
./tools/buildman/buildman -o /tmp -P -E -W aarch64 || ret=$?;
if [[ $ret -ne 0 ]]; then
prev parent reply other threads:[~2020-05-06 8:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 0:23 [PATCH v2 0/7] rockchip: make it possible to sign the u-boot.itb Heiko Stuebner
2020-04-21 0:23 ` [PATCH v2 1/7] spl: fit: select SPL_HASH_SUPPORT for SPL_FIT_SIGNATURE Heiko Stuebner
2020-04-28 13:45 ` Kever Yang
2020-04-21 0:23 ` [PATCH v2 2/7] spl: fit: select SPL_CRYPTO_SUPPORT " Heiko Stuebner
2020-04-28 13:46 ` Kever Yang
2020-04-21 0:23 ` [PATCH v2 3/7] lib: rsa: distinguish between tpl and spl for CONFIG_RSA_VERIFY Heiko Stuebner
2020-04-28 13:47 ` Kever Yang
2020-04-21 0:23 ` [PATCH v2 4/7] mkimage: fit_image: handle multiple errors when writing signatures Heiko Stuebner
2020-04-28 13:48 ` Kever Yang
2020-04-21 0:23 ` [PATCH v2 5/7] spl: fit: enable signing a generated u-boot.itb Heiko Stuebner
2020-04-28 13:48 ` Kever Yang
2020-04-30 9:03 ` Kever Yang
2020-04-30 12:18 ` Heiko Stübner
2020-04-30 12:32 ` [PATCH v2.1 " Heiko Stuebner
2020-04-21 0:23 ` [PATCH v2 6/7] spl: fit: add Kconfig option to specify key-hint for fit_generator Heiko Stuebner
2020-04-21 17:37 ` Simon Glass
2020-04-28 13:53 ` Kever Yang
2020-04-21 0:23 ` [PATCH v2 7/7] rockchip: make_fit_atf: add signature handling Heiko Stuebner
2020-04-21 17:37 ` Simon Glass
2020-04-28 13:53 ` Kever Yang
2020-05-01 10:32 ` Kever Yang
2020-05-04 0:33 ` Heiko Stübner
2020-05-06 8:55 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1796995.eNl2sZyQD1@diego \
--to=heiko@sntech.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox