From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?ISO-8859-1?Q?Roh=E1r?= Date: Sun, 04 Mar 2012 22:12:20 +0100 Subject: [U-Boot] Bug in cfb_console driver In-Reply-To: <2106642.O3MCknmZKH@pali-elitebook> References: <2106642.O3MCknmZKH@pali-elitebook> Message-ID: <1815857.Df8ir0xyPp@pali> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday 14 January 2012 04:32:04 Pali Roh?r wrote: > Hello, > > commit 03d31fcf4c37d90a00e66f06b38742960139f090 break video framebuffer > output on Nokia N900. After this commit is video output garbaged and not > readable on display. Problem is in function video_invertchar() - when I > commented it, video output is OK, but without cursor. Problem is only on > real N900 device, not in qemu. This is simple preview how to fix output on N900 display: diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c index eb013b8..7cd3cc5 100644 --- a/drivers/video/cfb_console.c +++ b/drivers/video/cfb_console.c @@ -624,6 +624,7 @@ static void video_set_cursor(void) static void video_invertchar(int xx, int yy) { + /* Disabled on RX51 int firstx = xx * VIDEO_PIXEL_SIZE; int lastx = (xx + VIDEO_FONT_WIDTH) * VIDEO_PIXEL_SIZE; int firsty = yy * VIDEO_LINE_LEN; @@ -635,6 +636,7 @@ static void video_invertchar(int xx, int yy) *dest = ~*dest; } } + */ } void console_cursor(int state) But I think that function video_invertchar which is needed for rendering cursor should be fixed properly. Can somebody check if current implementaion of function video_invertchar is correct? I do not properly understand that code, so I cannot debug it. -- Pali Roh?r pali.rohar at gmail.com -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part. URL: