From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21F71C433EF for ; Mon, 20 Sep 2021 12:35:30 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CEBA60F50 for ; Mon, 20 Sep 2021 12:35:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1CEBA60F50 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B537282BE5; Mon, 20 Sep 2021 14:35:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1632141327; bh=CpQTTKbB1watC30bSivGPk3CboMSZsNHyAXywID+xHc=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=e2buxs/0Kduaq75fqen5NcTw8Q0PkM+00QPSUPX3cnZTgQ7hjB1ZB1KskdRp2PwRr 9YFMpkCe79B0tgzQwyLObY+UyiAp31bVzivSmY7c6hKtL557l0XKFmAw7d2yRf+FXZ 2r8IgbX1+HZ8Cgyrjqe/peNJj/dIKHSI5E89/ibH0z3b9H68yBMsQex0uDAR/VsQYA k0Zbj3ydXcrKyNG7rDI+J3iZcquVED+ysk1b6Mkh9E3aeWCp9fs6rZxd1h/FtnqmHZ Un2fsW74qoX2dxm1y7U54rJFfU+ifsN92W8odbJxeZjbz21CJWUltn6KtDcMACYF6a ZPfOijXFJlDfg== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 348B483257 for ; Mon, 20 Sep 2021 14:35:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1632141325; bh=CpQTTKbB1watC30bSivGPk3CboMSZsNHyAXywID+xHc=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=oZb36S10+VR6lMZ3P+jvrGU23pzoPJcrnrxZPBXoXwY1FIopkeUciu5HGzimWM2oI NC4yUDXeCkCweaVu5VfBVu73ifVOTU8Sir8QBOy/5bivcHPKME6Sa3pXmCltDYTzpT mak9LF2Tsbi2XcgzlGIaw57gao5d1bQQ3JhsCBi6DxdycioujIXplOMs7PuKb1DJBN s71VzZite9yOsdz9Mi8Rq8QqcXDY9cPT1IIQV4mDybf138Jy2SsKgb296ARIFsaMxw J5vSGgA/YaO1GXlq2haNepyLdAfYxLii5rXnHUFOdXFfEs91Pho2588XujG8VmV2DA yK6ubrRNnN0+Q== Received: by janitor.denx.de (Postfix, from userid 108) id AC441A0277; Mon, 20 Sep 2021 14:35:24 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 18AFBA0058; Mon, 20 Sep 2021 14:35:18 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id EA30A1E0F1B; Mon, 20 Sep 2021 14:35:17 +0200 (CEST) To: Simon Glass cc: U-Boot Mailing List , Tom Rini , Bin Meng , Joe Hershberger , =?UTF-8?q?Marek=20Beh=C3=BAn?= , =?UTF-8?q?Pali=20Roh=C3=A1r?= From: Wolfgang Denk Subject: Re: [PATCH v4 4/5] env: Allow environment files to use the C preprocessor MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20210919125937.v4.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> References: <20210919185950.3813952-1-sjg@chromium.org> <20210919125937.v4.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> Comments: In-reply-to Simon Glass message dated "Sun, 19 Sep 2021 12:59:49 -0600." Date: Mon, 20 Sep 2021 14:35:17 +0200 Message-ID: <1819808.1632141317@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Simon, In message <20210919125937.v4.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you wrote: > > +To add additional text to a variable you can use var+=value. This text is > +merged into the variable during the make process and made available as a > +single value to U-Boot. Explained after use. Move documentation to previous patch? > + # Deal with += > + if (match(var, "(.*)[+]$", var_arr)) { > + var = var_arr[1] > + env = vars[var] env > + } Hm... this is (so far) a legal command: => setenv foobar+ foo+=bar Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de "Summit meetings tend to be like panda matings. The expectations are always high, and the results usually disappointing." - Robert Orben