From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rohan Garg Date: Fri, 19 Jul 2019 16:56:45 +0200 Subject: [U-Boot] [PATCH v2 1/3] rockchip: rk3399: derive ethaddr from cpuid In-Reply-To: <05a83223-6f23-d363-f70b-4459ca6313a3@rock-chips.com> References: <20190712142228.13201-1-rohan.garg@collabora.com> <05a83223-6f23-d363-f70b-4459ca6313a3@rock-chips.com> Message-ID: <1824154.9tn3IIiJ8K@solembum> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hey Kever > > This should be depends on CONFIG_MISC_INIT_R. > Ack. > > It's great to make these code as common code so that other SoCs > > can share it, is it possible to also make this function common? > > Not every SoC have efuse driver, so for those SoCs, we need a random > > serial No. > Do you think we can merge this as is for now and then move onto making it more generic for other devices at a later date? > > + const u32 cpuid_offset = 0x7; > > + const u32 cpuid_length = 0x10; > > + u8 cpuid[cpuid_length]; > > + > > + rockchip_cpuid_from_efuse(cpuid_offset, cpuid_length, cpuid); > > + rockchip_cpuid_set(cpuid, cpuid_length); > > + rockchip_setup_macaddr(); > > It will be better for these function calls with return value. > > There should be a blank line before 'return'; Ack. Cheers Rohan Garg -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: This is a digitally signed message part. URL: