[U-Boot-Users] [PATCH] : Remove unused code from uboot-1.3.3/lib_arm/bootm.c

[U-Boot-Users] [PATCH] : Remove unused code from uboot-1.3.3/lib_arm/bootm.c

[Gururaja Hebbar K R]

Hi,

This patch removes an unused part of the code. 

This code is only used in lib_avr32/bootm.c and in lib_arm/bootm.c it is
under #if 0

Comments are welcome.
 
Regards
Gururaja
 
Signed off by: Gururaja Hebbar <gururajakr@sanyo.co.in>

--- bootm_orig.c	2008-07-15 16:51:03.296875000 -0700
+++ bootm.c	2008-07-15 16:51:38.250000000 -0700
@@ -43,9 +43,6 @@ static void setup_memory_tags (bd_t *bd)
 # endif
 static void setup_commandline_tag (bd_t *bd, char *commandline);
 
-#if 0
-static void setup_ramdisk_tag (bd_t *bd);
-#endif
 # ifdef CONFIG_INITRD_TAG
 static void setup_initrd_tag (bd_t *bd, ulong initrd_start,
 			      ulong initrd_end);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove_disabled_code.patch
Type: application/octet-stream
Size: 412 bytes
Desc: remove_disabled_code.patch
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080715/a82f3359/attachment.obj 

[U-Boot-Users] [PATCH] : Remove unused code from uboot-1.3.3/lib_arm/bootm.c

[Wolfgang Denk]

In message <5BF78BCE8D9BF14A83F836BD9E3916BA23C0AB@blrms.slti.sanyo.co.in> you wrote:
> 
> This patch removes an unused part of the code. 

Sorry, this patch cannot be applied.

> --- bootm_orig.c	2008-07-15 16:51:03.296875000 -0700
> +++ bootm.c	2008-07-15 16:51:38.250000000 -0700
...

error: bootm.c: does not exist in index
fatal: sha1 information is lacking or useless (bootm.c).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
...


Please read http://www.denx.de/wiki/UBoot/Patches for instructions how
to prepare patches. I strongly recommend to use git0format-patch .

Please fix and resubmit

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Once upon a time, "PC" meant "personal computer".  Now  it  seems  to
only  mean  "Prisoner  of Bill". Alas! All my PCs run Unix, and those
include Intel, Sparc, and other processors.
          -- Tom "Bring back the non-PC meaning of `PC'" Christiansen

[U-Boot-Users] [PATCH] : Remove unused code from uboot-1.3.3/lib_arm/bootm.c

[Hebbar]

Hi,

Sorry i had generated the patch from with uboot/lib_arm directory and hence
i think it failed. now i have created the diff for the root directory where
the uboot-1.3.3 folder resides. sorry for the trouble.

Thanks in advance.

Regards
Gururaja

Signed off by: Gururaja Hebbar <gururajakr@...> 

diff -purN uboot/lib_arm_orig/bootm.c uboot/lib_arm/bootm.c
--- uboot/lib_arm_orig/bootm.c	2008-05-19 03:47:11.000000000 -0700
+++ uboot/lib_arm/bootm.c	2008-07-15 16:51:38.250000000 -0700
@@ -43,9 +43,6 @@ static void setup_memory_tags (bd_t *bd)
 # endif
 static void setup_commandline_tag (bd_t *bd, char *commandline);
 
-#if 0
-static void setup_ramdisk_tag (bd_t *bd);
-#endif
 # ifdef CONFIG_INITRD_TAG
 static void setup_initrd_tag (bd_t *bd, ulong initrd_start,
 			      ulong initrd_end);

http://www.nabble.com/file/p18477587/removed_unused_code_lib_arm_bootm.patch
removed_unused_code_lib_arm_bootm.patch 
-- 
View this message in context: http://www.nabble.com/-PATCH--%3A-Remove-unused-code-from-uboot-1.3.3-lib_arm-bootm.c-tp18460213p18477587.html
Sent from the Uboot - Users mailing list archive at Nabble.com.

[U-Boot-Users] [PATCH] : Remove unused code from uboot-1.3.3/lib_arm/bootm.c

[Wolfgang Denk]

In message <18477587.post@talk.nabble.com> you wrote:
> 
> Sorry i had generated the patch from with uboot/lib_arm directory and hence
> i think it failed. now i have created the diff for the root directory where
> the uboot-1.3.3 folder resides. sorry for the trouble.

Please use git tools (git-format-patch) to create the patch.
Otherwise, at least put comments that are not intended to go into the
commit message belo a line containing only three dashes:

---

> Signed off by: Gururaja Hebbar <gururajakr@...> 

Please provide a valid mail address, and write "Signed-off-by:"

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"No problem is so formidable that you can't walk away from it."
- C. Schulz