public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Josua Mayer <josua@solid-run.com>
To: Stefan Roese <sr@denx.de>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/2] arm: mvebu: clearfog gtr: add config option to select serdes0 interface
Date: Fri, 12 Jan 2024 13:32:25 +0000	[thread overview]
Message-ID: <185971d3-4e75-44f7-b4f7-64af236b7f0e@solid-run.com> (raw)
In-Reply-To: <34ed0778-78a0-4a29-b329-638e9e24967a@denx.de>

Hi Stefan,

Am 09.01.24 um 12:45 schrieb Stefan Roese:
>>   +choice CLEARFOG_GTR_SERDES0
>> +    prompt "Select Clearfog GTR SerDes 0 Function"
>> +    help
>> +      Select function for SerDes 0 which is shared between CON3 and CON18
>> +      for either pci-e or sata.
>> +
>> +config CLEARFOG_GTR_SERDES0_PCIE
>> +    bool "PCI-E on CON3"
>> +    default y
>
> After applying this patch I get this warning:
>
> board/solidrun/clearfog/Kconfig:50:warning: defaults for choice values not supported
>
> Could you please take a look? 
Thank you, I was mistaken about where the default setting belongs,  apparently it belongs to the "choice" - not its elements.
Will send v2 soon.

  reply	other threads:[~2024-01-12 13:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-06 17:29 [PATCH 0/2] board: solidrun: clearfog gtr: add serdes configuration Josua Mayer
2024-01-06 17:29 ` [PATCH 1/2] arm: mvebu: clearfog gtr: add config option to select serdes0 interface Josua Mayer
2024-01-09 11:45   ` Stefan Roese
2024-01-12 13:32     ` Josua Mayer [this message]
2024-01-06 17:29 ` [PATCH 2/2] board: solidrun: clearfog: fix serdes 1 / eth2 speed for clearfog gtr Josua Mayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=185971d3-4e75-44f7-b4f7-64af236b7f0e@solid-run.com \
    --to=josua@solid-run.com \
    --cc=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox