From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ajay Bhargav Date: Wed, 2 Nov 2011 11:08:07 +0530 (IST) Subject: [U-Boot] [PATCH] mmc: mv_sdhci: Fix host version read for Armada100 In-Reply-To: Message-ID: <1876746588.290118.1320212287548.JavaMail.root@ahm.einfochips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de ----- "Lei Wen" wrote: > Hi Ajay, > > On Tue, Nov 1, 2011 at 5:39 PM, Ajay Bhargav > wrote: > > sdhci_readw does not work for host version read in Armada100 series > > SoCs. This patch fix this issue by making a sdhci_readl call to get > host > > version. > > > > Signed-off-by: Ajay Bhargav > > --- > > ?drivers/mmc/mv_sdhci.c | ? ?6 ++++++ > > ?1 files changed, 6 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/mmc/mv_sdhci.c b/drivers/mmc/mv_sdhci.c > > index f92caeb..c7fd287 100644 > > --- a/drivers/mmc/mv_sdhci.c > > +++ b/drivers/mmc/mv_sdhci.c > > @@ -30,6 +30,7 @@ static inline void mv_sdhci_writeb(struct > sdhci_host *host, u8 val, int reg) > > ?#endif /* CONFIG_MMC_SDHCI_IO_ACCESSORS */ > > > > ?static char *MVSDH_NAME = "mv_sdh"; > > + > > ?int mv_sdh_init(u32 regbase, u32 max_clk, u32 min_clk, u32 quirks) > > ?{ > > ? ? ? ?struct sdhci_host *host = NULL; > > @@ -48,7 +49,12 @@ int mv_sdh_init(u32 regbase, u32 max_clk, u32 > min_clk, u32 quirks) > > ? ? ? ? ? ? ? ?mv_ops.write_b = mv_sdhci_writeb; > > ? ? ? ?host->ops = &mv_ops; > > ?#endif > > +#ifdef CONFIG_ARMADA100 > > You should following my previous fixing sample to add the workaround: > http://patchwork.ozlabs.org/patch/117575/ > Patches acked? I didn't know it. Or I should wait for your patches to get mainlined first. > Just keep in mind that, it is generic driver and don't put private > fixing there. :) > > Thanks, > Lei > Any good way to put that fix? Or else I can simply follow Marek's solution to add a quirk for this instead of defining it for a CPU. What you say? Regards, Ajay Bhargav