From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hebbar <gururajakr@sanyo.co.in>
Date: Thu, 31 Jul 2008 20:15:12 -0700 (PDT)
Subject: [U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTC Support
In-Reply-To: <5BF78BCE8D9BF14A83F836BD9E3916BA23C1F0@blrms.slti.sanyo.co.in>
References: <5BF78BCE8D9BF14A83F836BD9E3916BA23C0C5@blrms.slti.sanyo.co.in>
	<20080717213953.GE28526@game.jcrosoft.org>
	<5BF78BCE8D9BF14A83F836BD9E3916BA23C0DA@blrms.slti.sanyo.co.in>
	<5BF78BCE8D9BF14A83F836BD9E3916BA23C12D@blrms.slti.sanyo.co.in>
	<20080721201954.GB16567@game.jcrosoft.org>
	<5BF78BCE8D9BF14A83F836BD9E3916BA23C134@blrms.slti.sanyo.co.in>
	<18582594.post@talk.nabble.com>
	<20080722062124.0F138248B9@gemini.denx.de>
	<18583543.post@talk.nabble.com>
	<20080729205450.7ED7D248B9@gemini.denx.de>
	<5BF78BCE8D9BF14A83F836BD9E3916BA23C1F0@blrms.slti.sanyo.co.in>
Message-ID: <18767539.post@talk.nabble.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


Hi,

>Why do we need the #ifdef's here? It seems this is a board specific
>configuration anyway, i. e. we don't expect for example other RTC chips
>to be used on this board, or do we?

Also I Just Checked u-boot-1.3.3/board/bc3450/bc3450.c. Even here it has 
a declaration for RTC @ line 47

#ifdef CONFIG_RTC_MPC5200
#include <rtc.h>
#endif

@ line 371

#ifdef CONFIG_RTC_MPC5200
	struct rtc_time t;

	/* set to Wed Dec 31 19:00:00 1969 */
	t.tm_sec = t.tm_min = 0;
	t.tm_hour = 19;
	t.tm_mday = 31;
	t.tm_mon = 12;
	t.tm_year = 1969;
	t.tm_wday = 3;

	rtc_set(&t);
#endif /* CONFIG_RTC_MPC5200 */


So i think its correct. Please Update me if i am wrong


Regards
Gururaja

-- 
View this message in context: http://www.nabble.com/-PATCH--%28Resubmit%29-ADD-ARM-AMBA-PL031-RTC-Support-tp18499969p18767539.html
Sent from the Uboot - Users mailing list archive at Nabble.com.