[U-Boot] [PATCH v5 2/3] Armada100: Enable Ethernet support for GplugD

[Ajay Bhargav <ajay.bhargav@einfochips.com>]

----- "Prafulla Wadaskar" <prafulla@marvell.com> wrote:

> > -----Original Message-----
> > From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> > Sent: Friday, September 02, 2011 10:49 AM
> > To: Prafulla Wadaskar
> > Cc: u-boot at lists.denx.de; vapier at gentoo.org; marek.vasut at gmail.com;
> Ajay
> > Bhargav
> > Subject: [PATCH v5 2/3] Armada100: Enable Ethernet support for
> GplugD
> > 

[...]

> >  #define CONFIG_CMD_I2C
> >  #define CONFIG_CMD_AUTOSCRIPT
> >  #undef CONFIG_CMD_FPGA
> > -#undef CONFIG_CMD_NET
> > -#undef CONFIG_CMD_NFS
> > +
> > +/* Disable DCACHE */
> > +#define CONFIG_SYS_DCACHE_OFF
> > +
> 
> Put below definition encapsulated in #ifdef CONFIG_CMD_NET
> 
> > +/* Network configuration */
> > +#define CONFIG_CMD_PING
> > +#define CONFIG_NET_MULTI
> > +#define CONFIG_ARMADA100_FEC
> > +
> > +/* DHCP Support */
> > +#define CONFIG_CMD_DHCP
> > +#define CONFIG_BOOTP_DHCP_REQUEST_DELAY		50000
> > +#define CONFIG_BOOTP_SERVERIP
> 
> You should remove this also during this commit. There should not be
> any hard coding for serverip and ipaddr
>  
> > +
> > +/* Default Boot Parameters */
> > +#define CONFIG_ROOTPATH				"/tftpboot"
> > +#define CONFIG_SYS_IMG_NAME			"uImage"
> 
> Similarly these are also not necessary, you may remove those too.
> 
> Ack for rest of the code.
> 
> Regards..
> Prafulla . .
> 

Hi Prafulla,

Thanks for reply, I will do the required changes and submit back..

Regards,
Ajay Bhargav

> > 
> >  /*
> >   * mv-common.h should be defined after CMD configs since it used
> them
> > --
> > 1.7.0.4
> 
>