[U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL

Benoît Thébaudeau
2013-04-03T06:30:12Z

Hi Albert,

On Monday, April 1, 2013 5:53:55 PM, Albert ARIBAUD wrote:
> Hi Beno?t,
>
> On Mon, 1 Apr 2013 15:13:05 +0200 (CEST), Beno?t Th?baudeau
> <benoit.thebaudeau@advansee.com> wrote:
>
> > OK, then it's probably better if I send v10 ASAP. I may not have access to
> > my
> > repo before this date, and I have not kept my v9 bundle in my outbox, so
> > can you
> > just send me back this bundle please? I will try to send a v10 during this
> > week.
>
> Sent off-list as this bundle is V9 and thus should not be tested by
> people, only V10 should.

Here is the v10 bundle for those who want to test:
http://dl.free.fr/vdXBGExyq

The resulting HEAD is identical to yours, except for
board/freescale/mx31ads/u-boot.lds in which you had removed the following
unrelated line for 30/30:
__bss_end = .;

Regarding this line, it is also present in a few other .lds, as well as the
following ones:
KEEP(*(.__bss_start));
KEEP(*(__bss_end));

However, the end section is named .__bss_end in arch/arm/lib/bss.c, so there is
perhaps something wrong here, unless you did that on purpose because of the
__bss_end test at the end of the linker script. I had noticed that, but I let
you handle it. If something needs to be changed here, please do it after my
series if possible in order to avoid a v11 because of newer rebase conflicts. ;)

I have also noticed that patman is broken in u-boot-arm/master. I don't know if
this has already been fixed somewhere, but it fails with an internal error while
running checkpatch, as if an incompatible API change had been made to checkpatch
recently, and not propagated to patman.

Best regards,
Beno?t