[U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL

Albert ARIBAUD
2013-04-04T14:16:11Z

Hi Beno?t,

On Thu, 4 Apr 2013 16:05:27 +0200 (CEST), Beno?t Th?baudeau
<benoit.thebaudeau@advansee.com> wrote:

> Hi Albert,
>
> On Thursday, April 4, 2013 11:07:23 AM, Albert ARIBAUD wrote:
> > Hi Beno?t,
> >
> > On Wed, 3 Apr 2013 08:30:12 +0200 (CEST), Beno?t Th?baudeau
> > <benoit.thebaudeau@advansee.com> wrote:
> >
> > > The resulting HEAD is identical to yours, except for
> > > board/freescale/mx31ads/u-boot.lds in which you had removed the following
> > > unrelated line for 30/30:
> > > __bss_end = .;
> > >
> > > Regarding this line, it is also present in a few other .lds, as well as the
> > > following ones:
> > > KEEP(*(.__bss_start));
> > > KEEP(*(__bss_end));
> > >
> > > However, the end section is named .__bss_end in arch/arm/lib/bss.c, so
> > > there is
> > > perhaps something wrong here, unless you did that on purpose because of the
> > > __bss_end test at the end of the linker script. I had noticed that, but I
> > > let
> > > you handle it. If something needs to be changed here, please do it after my
> > > series if possible in order to avoid a v11 because of newer rebase
> > > conflicts. ;)
> >
> > I have a patch ready and currently undergoing build and run tests. As
> > per http://www.denx.de/wiki/view/U-Boot/Patches#Review_Process_Git_Tags,
> > I must ask your permission to add your 'Reported-By:' in my patch. Can I?
>
> Sure:
> Reported-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>

Actually, I think you've just stated to our patchwork that your patch v9
18/30 fixes a bug reported by you... But never mind, v9 is superseded
now anyway, and I'll put your Reported-By manually in my BSS fix patch.

> Best regards,
> Beno?t

Amicalement,
--
Albert.