* [U-Boot] [PATCH v4 01/16] tegra: Use const for pinmux_config_pingroup/table()
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
@ 2012-09-28 0:44 ` Simon Glass
2012-09-28 0:44 ` [U-Boot] [PATCH v4 02/16] tegra: Add display support to funcmux Simon Glass
` (16 subsequent siblings)
17 siblings, 0 replies; 40+ messages in thread
From: Simon Glass @ 2012-09-28 0:44 UTC (permalink / raw)
To: u-boot
These two functions don't actually modify their arguments so add a const
keyword.
Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Mike Frysinger <vapier@gentoo.org>
---
Changes in v2:
- Add new patch to use const in pinmux_config_pingroup/table()
arch/arm/cpu/tegra20-common/pinmux.c | 4 ++--
arch/arm/include/asm/arch-tegra20/pinmux.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/cpu/tegra20-common/pinmux.c b/arch/arm/cpu/tegra20-common/pinmux.c
index 08b8305..a2a0916 100644
--- a/arch/arm/cpu/tegra20-common/pinmux.c
+++ b/arch/arm/cpu/tegra20-common/pinmux.c
@@ -554,7 +554,7 @@ void pinmux_set_func(enum pmux_pingrp pin, enum pmux_func func)
writel(reg, muxctl);
}
-void pinmux_config_pingroup(struct pingroup_config *config)
+void pinmux_config_pingroup(const struct pingroup_config *config)
{
enum pmux_pingrp pin = config->pingroup;
@@ -563,7 +563,7 @@ void pinmux_config_pingroup(struct pingroup_config *config)
pinmux_set_tristate(pin, config->tristate);
}
-void pinmux_config_table(struct pingroup_config *config, int len)
+void pinmux_config_table(const struct pingroup_config *config, int len)
{
int i;
diff --git a/arch/arm/include/asm/arch-tegra20/pinmux.h b/arch/arm/include/asm/arch-tegra20/pinmux.h
index 03fa7ca..797e158 100644
--- a/arch/arm/include/asm/arch-tegra20/pinmux.h
+++ b/arch/arm/include/asm/arch-tegra20/pinmux.h
@@ -339,7 +339,7 @@ void pinmux_set_pullupdown(enum pmux_pingrp pin, enum pmux_pull pupd);
void pinmux_set_func(enum pmux_pingrp pin, enum pmux_func func);
/* Set the complete configuration for a pin group */
-void pinmux_config_pingroup(struct pingroup_config *config);
+void pinmux_config_pingroup(const struct pingroup_config *config);
void pinmux_set_tristate(enum pmux_pingrp pin, int enable);
@@ -349,6 +349,6 @@ void pinmux_set_tristate(enum pmux_pingrp pin, int enable);
* @param config List of config items
* @param len Number of config items in list
*/
-void pinmux_config_table(struct pingroup_config *config, int len);
+void pinmux_config_table(const struct pingroup_config *config, int len);
#endif /* PINMUX_H */
--
1.7.7.3
^ permalink raw reply related [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 02/16] tegra: Add display support to funcmux
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
2012-09-28 0:44 ` [U-Boot] [PATCH v4 01/16] tegra: Use const for pinmux_config_pingroup/table() Simon Glass
@ 2012-09-28 0:44 ` Simon Glass
2012-09-28 0:44 ` [U-Boot] [PATCH v4 03/16] tegra: fdt: Add pwm binding and node Simon Glass
` (15 subsequent siblings)
17 siblings, 0 replies; 40+ messages in thread
From: Simon Glass @ 2012-09-28 0:44 UTC (permalink / raw)
To: u-boot
Add support for a default pin mapping for display1.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v2:
- Use const where possible in funcmux
Changes in v3:
- Remove LPW1 pin which is not needed by display
arch/arm/cpu/tegra20-common/funcmux.c | 37 +++++++++++++++++++++++++++++++++
1 files changed, 37 insertions(+), 0 deletions(-)
diff --git a/arch/arm/cpu/tegra20-common/funcmux.c b/arch/arm/cpu/tegra20-common/funcmux.c
index b2129ad..ca20f93 100644
--- a/arch/arm/cpu/tegra20-common/funcmux.c
+++ b/arch/arm/cpu/tegra20-common/funcmux.c
@@ -25,6 +25,30 @@
#include <asm/arch/funcmux.h>
#include <asm/arch/pinmux.h>
+/*
+ * The PINMUX macro is used to set up pinmux tables.
+ */
+#define PINMUX(grp, mux, pupd, tri) \
+ {PINGRP_##grp, PMUX_FUNC_##mux, PMUX_PULL_##pupd, PMUX_TRI_##tri}
+
+static const struct pingroup_config disp1_default[] = {
+ PINMUX(LDI, DISPA, NORMAL, NORMAL),
+ PINMUX(LHP0, DISPA, NORMAL, NORMAL),
+ PINMUX(LHP1, DISPA, NORMAL, NORMAL),
+ PINMUX(LHP2, DISPA, NORMAL, NORMAL),
+ PINMUX(LHS, DISPA, NORMAL, NORMAL),
+ PINMUX(LM0, RSVD4, NORMAL, NORMAL),
+ PINMUX(LPP, DISPA, NORMAL, NORMAL),
+ PINMUX(LPW0, DISPA, NORMAL, NORMAL),
+ PINMUX(LPW2, DISPA, NORMAL, NORMAL),
+ PINMUX(LSC0, DISPA, NORMAL, NORMAL),
+ PINMUX(LSPI, DISPA, NORMAL, NORMAL),
+ PINMUX(LVP1, DISPA, NORMAL, NORMAL),
+ PINMUX(LVS, DISPA, NORMAL, NORMAL),
+ PINMUX(SLXD, SPDIF, NORMAL, NORMAL),
+};
+
+
int funcmux_select(enum periph_id id, int config)
{
int bad_config = config != FUNCMUX_DEFAULT;
@@ -240,6 +264,19 @@ int funcmux_select(enum periph_id id, int config)
pinmux_tristate_disable(PINGRP_ATC);
}
break;
+ case PERIPH_ID_DISP1:
+ if (config == FUNCMUX_DEFAULT) {
+ int i;
+
+ for (i = PINGRP_LD0; i <= PINGRP_LD17; i++) {
+ pinmux_set_func(i, PMUX_FUNC_DISPA);
+ pinmux_tristate_disable(i);
+ pinmux_set_pullupdown(i, PMUX_PULL_NORMAL);
+ }
+ pinmux_config_table(disp1_default,
+ ARRAY_SIZE(disp1_default));
+ }
+ break;
default:
debug("%s: invalid periph_id %d", __func__, id);
--
1.7.7.3
^ permalink raw reply related [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 03/16] tegra: fdt: Add pwm binding and node
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
2012-09-28 0:44 ` [U-Boot] [PATCH v4 01/16] tegra: Use const for pinmux_config_pingroup/table() Simon Glass
2012-09-28 0:44 ` [U-Boot] [PATCH v4 02/16] tegra: Add display support to funcmux Simon Glass
@ 2012-09-28 0:44 ` Simon Glass
2012-09-28 20:08 ` Thierry Reding
2012-09-28 0:44 ` [U-Boot] [PATCH v4 04/16] tegra: fdt: Add LCD definitions for Tegra Simon Glass
` (14 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Simon Glass @ 2012-09-28 0:44 UTC (permalink / raw)
To: u-boot
This binding will apparently soon be in linux-next. Bring it in now
since we need to do something, and may as well try to target what
Linux will have.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v3:
- Add new commit for pwm binding and node
arch/arm/dts/tegra20.dtsi | 7 +++++++
doc/device-tree-bindings/pwm/tegra20-pwm.txt | 18 ++++++++++++++++++
2 files changed, 25 insertions(+), 0 deletions(-)
create mode 100644 doc/device-tree-bindings/pwm/tegra20-pwm.txt
diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
index d936b1e..3221bc9 100644
--- a/arch/arm/dts/tegra20.dtsi
+++ b/arch/arm/dts/tegra20.dtsi
@@ -211,4 +211,11 @@
compatible = "nvidia,tegra20-nand";
reg = <0x70008000 0x100>;
};
+
+ pwm: pwm at 7000a000 {
+ compatible = "nvidia,tegra20-pwm";
+ reg = <0x7000a000 0x100>;
+ #pwm-cells = <2>;
+ };
+
};
diff --git a/doc/device-tree-bindings/pwm/tegra20-pwm.txt b/doc/device-tree-bindings/pwm/tegra20-pwm.txt
new file mode 100644
index 0000000..bbbeedb
--- /dev/null
+++ b/doc/device-tree-bindings/pwm/tegra20-pwm.txt
@@ -0,0 +1,18 @@
+Tegra SoC PWFM controller
+
+Required properties:
+- compatible: should be one of:
+ - "nvidia,tegra20-pwm"
+ - "nvidia,tegra30-pwm"
+- reg: physical base address and length of the controller's registers
+- #pwm-cells: On Tegra the number of cells used to specify a PWM is 2. The
+ first cell specifies the per-chip index of the PWM to use and the second
+ cell is the duty cycle in nanoseconds.
+
+Example:
+
+ pwm: pwm at 7000a000 {
+ compatible = "nvidia,tegra20-pwm";
+ reg = <0x7000a000 0x100>;
+ #pwm-cells = <2>;
+ };
--
1.7.7.3
^ permalink raw reply related [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 03/16] tegra: fdt: Add pwm binding and node
2012-09-28 0:44 ` [U-Boot] [PATCH v4 03/16] tegra: fdt: Add pwm binding and node Simon Glass
@ 2012-09-28 20:08 ` Thierry Reding
2012-10-08 21:22 ` Simon Glass
0 siblings, 1 reply; 40+ messages in thread
From: Thierry Reding @ 2012-09-28 20:08 UTC (permalink / raw)
To: u-boot
On Thu, Sep 27, 2012 at 05:44:24PM -0700, Simon Glass wrote:
> This binding will apparently soon be in linux-next. Bring it in now
> since we need to do something, and may as well try to target what
> Linux will have.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> Changes in v3:
> - Add new commit for pwm binding and node
>
> arch/arm/dts/tegra20.dtsi | 7 +++++++
> doc/device-tree-bindings/pwm/tegra20-pwm.txt | 18 ++++++++++++++++++
> 2 files changed, 25 insertions(+), 0 deletions(-)
> create mode 100644 doc/device-tree-bindings/pwm/tegra20-pwm.txt
>
> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
> index d936b1e..3221bc9 100644
> --- a/arch/arm/dts/tegra20.dtsi
> +++ b/arch/arm/dts/tegra20.dtsi
> @@ -211,4 +211,11 @@
> compatible = "nvidia,tegra20-nand";
> reg = <0x70008000 0x100>;
> };
> +
> + pwm: pwm at 7000a000 {
> + compatible = "nvidia,tegra20-pwm";
> + reg = <0x7000a000 0x100>;
> + #pwm-cells = <2>;
> + };
> +
> };
> diff --git a/doc/device-tree-bindings/pwm/tegra20-pwm.txt b/doc/device-tree-bindings/pwm/tegra20-pwm.txt
> new file mode 100644
> index 0000000..bbbeedb
> --- /dev/null
> +++ b/doc/device-tree-bindings/pwm/tegra20-pwm.txt
> @@ -0,0 +1,18 @@
> +Tegra SoC PWFM controller
> +
> +Required properties:
> +- compatible: should be one of:
> + - "nvidia,tegra20-pwm"
> + - "nvidia,tegra30-pwm"
> +- reg: physical base address and length of the controller's registers
> +- #pwm-cells: On Tegra the number of cells used to specify a PWM is 2. The
> + first cell specifies the per-chip index of the PWM to use and the second
> + cell is the duty cycle in nanoseconds.
This is a mistake in the Linux kernel documentation. The second cell
specifies the period in nanoseconds, not the duty cycle. I'll fix this
up in the kernel.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120928/fe215af9/attachment.pgp>
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 03/16] tegra: fdt: Add pwm binding and node
2012-09-28 20:08 ` Thierry Reding
@ 2012-10-08 21:22 ` Simon Glass
0 siblings, 0 replies; 40+ messages in thread
From: Simon Glass @ 2012-10-08 21:22 UTC (permalink / raw)
To: u-boot
Hi Thierry,
On Fri, Sep 28, 2012 at 1:08 PM, Thierry Reding
<thierry.reding@avionic-design.de> wrote:
> On Thu, Sep 27, 2012 at 05:44:24PM -0700, Simon Glass wrote:
>> This binding will apparently soon be in linux-next. Bring it in now
>> since we need to do something, and may as well try to target what
>> Linux will have.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> ---
>> Changes in v3:
>> - Add new commit for pwm binding and node
>>
>> arch/arm/dts/tegra20.dtsi | 7 +++++++
>> doc/device-tree-bindings/pwm/tegra20-pwm.txt | 18 ++++++++++++++++++
>> 2 files changed, 25 insertions(+), 0 deletions(-)
>> create mode 100644 doc/device-tree-bindings/pwm/tegra20-pwm.txt
>>
>> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
>> index d936b1e..3221bc9 100644
>> --- a/arch/arm/dts/tegra20.dtsi
>> +++ b/arch/arm/dts/tegra20.dtsi
>> @@ -211,4 +211,11 @@
>> compatible = "nvidia,tegra20-nand";
>> reg = <0x70008000 0x100>;
>> };
>> +
>> + pwm: pwm at 7000a000 {
>> + compatible = "nvidia,tegra20-pwm";
>> + reg = <0x7000a000 0x100>;
>> + #pwm-cells = <2>;
>> + };
>> +
>> };
>> diff --git a/doc/device-tree-bindings/pwm/tegra20-pwm.txt b/doc/device-tree-bindings/pwm/tegra20-pwm.txt
>> new file mode 100644
>> index 0000000..bbbeedb
>> --- /dev/null
>> +++ b/doc/device-tree-bindings/pwm/tegra20-pwm.txt
>> @@ -0,0 +1,18 @@
>> +Tegra SoC PWFM controller
>> +
>> +Required properties:
>> +- compatible: should be one of:
>> + - "nvidia,tegra20-pwm"
>> + - "nvidia,tegra30-pwm"
>> +- reg: physical base address and length of the controller's registers
>> +- #pwm-cells: On Tegra the number of cells used to specify a PWM is 2. The
>> + first cell specifies the per-chip index of the PWM to use and the second
>> + cell is the duty cycle in nanoseconds.
>
> This is a mistake in the Linux kernel documentation. The second cell
> specifies the period in nanoseconds, not the duty cycle. I'll fix this
> up in the kernel.
Oh ok, thanks. I will update this patch.
Regards,
Simon
>
> Thierry
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot] [PATCH v4 04/16] tegra: fdt: Add LCD definitions for Tegra
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
` (2 preceding siblings ...)
2012-09-28 0:44 ` [U-Boot] [PATCH v4 03/16] tegra: fdt: Add pwm binding and node Simon Glass
@ 2012-09-28 0:44 ` Simon Glass
2012-10-03 22:54 ` Stephen Warren
2012-10-03 22:58 ` Stephen Warren
2012-09-28 0:44 ` [U-Boot] [PATCH v4 05/16] tegra: Add support for PWM Simon Glass
` (13 subsequent siblings)
17 siblings, 2 replies; 40+ messages in thread
From: Simon Glass @ 2012-09-28 0:44 UTC (permalink / raw)
To: u-boot
Add LCD definitions and also a proposed binding for LCD displays.
The PWM is as per what will likely be committed to linux-next soon.
The displaymode binding comes from a proposal here:
http://lists.freedesktop.org/archives/dri-devel/2012-July/024875.html
The panel binding is new, and fills a need to specify the panel
timings and other tegra-specific information. Should a binding appear
that allows the pwm to handle this automatically, we can revisit
this.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v2:
- Add nvidia prefix to device tree properties
Changes in v3:
- Use displaymode binding for fdt
- Bring in proposed tegra display controller binding
- Add new panel binding to fit with tegra display controller binding
Changes in v4:
- Moved panel information into panel node (was in rgb node)
- Remove LCD frame buffer address property hack
arch/arm/dts/tegra20.dtsi | 89 ++++++++++++++++++++++++
doc/device-tree-bindings/video/displaymode.txt | 42 +++++++++++
doc/device-tree-bindings/video/tegra20-dc.txt | 82 ++++++++++++++++++++++
3 files changed, 213 insertions(+), 0 deletions(-)
create mode 100644 doc/device-tree-bindings/video/displaymode.txt
create mode 100644 doc/device-tree-bindings/video/tegra20-dc.txt
diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
index 3221bc9..5fb1fd7 100644
--- a/arch/arm/dts/tegra20.dtsi
+++ b/arch/arm/dts/tegra20.dtsi
@@ -218,4 +218,93 @@
#pwm-cells = <2>;
};
+ host1x {
+ compatible = "nvidia,tegra20-host1x", "simple-bus";
+ reg = <0x50000000 0x00024000>;
+ interrupts = <0 65 0x04 /* mpcore syncpt */
+ 0 67 0x04>; /* mpcore general */
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ ranges = <0x54000000 0x54000000 0x04000000>;
+
+ /* video-encoding/decoding */
+ mpe {
+ reg = <0x54040000 0x00040000>;
+ interrupts = <0 68 0x04>;
+ };
+
+ /* video input */
+ vi {
+ reg = <0x54080000 0x00040000>;
+ interrupts = <0 69 0x04>;
+ };
+
+ /* EPP */
+ epp {
+ reg = <0x540c0000 0x00040000>;
+ interrupts = <0 70 0x04>;
+ };
+
+ /* ISP */
+ isp {
+ reg = <0x54100000 0x00040000>;
+ interrupts = <0 71 0x04>;
+ };
+
+ /* 2D engine */
+ gr2d {
+ reg = <0x54140000 0x00040000>;
+ interrupts = <0 72 0x04>;
+ };
+
+ /* 3D engine */
+ gr3d {
+ reg = <0x54180000 0x00040000>;
+ };
+
+ /* display controllers */
+ dc at 54200000 {
+ compatible = "nvidia,tegra20-dc";
+ reg = <0x54200000 0x00040000>;
+ interrupts = <0 73 0x04>;
+
+ rgb {
+ status = "disabled";
+ };
+ };
+
+ dc at 54240000 {
+ compatible = "nvidia,tegra20-dc";
+ reg = <0x54240000 0x00040000>;
+ interrupts = <0 74 0x04>;
+
+ rgb {
+ status = "disabled";
+ };
+ };
+
+ /* outputs */
+ hdmi {
+ compatible = "nvidia,tegra20-hdmi";
+ reg = <0x54280000 0x00040000>;
+ interrupts = <0 75 0x04>;
+ status = "disabled";
+ };
+
+ tvo {
+ compatible = "nvidia,tegra20-tvo";
+ reg = <0x542c0000 0x00040000>;
+ interrupts = <0 76 0x04>;
+ status = "disabled";
+ };
+
+ dsi {
+ compatible = "nvidia,tegra20-dsi";
+ reg = <0x54300000 0x00040000>;
+ status = "disabled";
+ };
+ };
+
};
diff --git a/doc/device-tree-bindings/video/displaymode.txt b/doc/device-tree-bindings/video/displaymode.txt
new file mode 100644
index 0000000..45ca42d
--- /dev/null
+++ b/doc/device-tree-bindings/video/displaymode.txt
@@ -0,0 +1,42 @@
+videomode bindings
+==================
+
+(from http://lists.freedesktop.org/archives/dri-devel/2012-July/024875.html)
+
+Required properties:
+ - xres, yres: Display resolution
+ - left-margin, right-margin, hsync-len: Horizontal Display timing
+ parameters in pixels
+ - upper-margin, lower-margin, vsync-len: Vertical display timing
+ parameters in lines
+ - clock: display clock in Hz
+
+Optional properties:
+ - width-mm, height-mm: Display dimensions in mm
+ - hsync-active-high (bool): Hsync pulse is active high
+ - vsync-active-high (bool): Vsync pulse is active high
+ - interlaced (bool): This is an interlaced mode
+ - doublescan (bool): This is a doublescan mode
+
+There are different ways of describing a display mode. The devicetree
+representation corresponds to the one used by the Linux Framebuffer
+framework described here in Documentation/fb/framebuffer.txt. This
+representation has been chosen because it's the only format which does
+not allow for inconsistent parameters. Unlike the Framebuffer framework
+the devicetree has the clock in Hz instead of ps.
+
+Example:
+
+ display at 0 {
+ /* 1920x1080p24 */
+ clock = <52000000>;
+ xres = <1920>;
+ yres = <1080>;
+ left-margin = <25>;
+ right-margin = <25>;
+ hsync-len = <25>;
+ lower-margin = <2>;
+ upper-margin = <2>;
+ vsync-len = <2>;
+ hsync-active-high;
+ };
diff --git a/doc/device-tree-bindings/video/tegra20-dc.txt b/doc/device-tree-bindings/video/tegra20-dc.txt
new file mode 100644
index 0000000..769cb98
--- /dev/null
+++ b/doc/device-tree-bindings/video/tegra20-dc.txt
@@ -0,0 +1,82 @@
+Display Controller
+------------------
+
+(there isn't yet a generic binding in Linux, so this describes what is in
+U-Boot, and may change based on Linux activity)
+
+The device node for a display device is as described in the document
+"Open Firmware Recommended Practice : Universal Serial Bus" with the
+following modifications and additions :
+
+Required properties :
+ - compatible : Should be "nvidia,tegra20-dc"
+
+Required subnode 'rgb' is as follows:
+
+Required properties (rgb) :
+ - nvidia,panel : phandle of LCD panel information
+
+
+The panel node describes the panel itself. This has the properties listed in
+displaymode.txt as well as:
+
+Required properties (panel) :
+ - nvidia,bits-per-pixel: number of bits per pixel (depth)
+ - nvidia,pwm : pwm to use to set display contrast (see tegra20-pwm.txt)
+ - nvidia,panel-timings: 4 cells containing required timings in ms:
+ * delay between panel_vdd-rise and data-rise
+ * delay between data-rise and backlight_vdd-rise
+ * delay between backlight_vdd and pwm-rise
+ * delay between pwm-rise and backlight_en-rise
+
+Optional GPIO properies all have (phandle, GPIO number, flags):
+ - nvidia,backlight-enable-gpios: backlight enable GPIO
+ - nvidia,lvds-shutdown-gpios: LVDS power shutdown GPIO
+ - nvidia,backlight-vdd-gpios: backlight power GPIO
+ - nvidia,panel-vdd-gpios: panel power GPIO
+
+Example:
+
+host1x {
+ compatible = "nvidia,tegra20-host1x", "simple-bus";
+ reg = <0x50000000 0x00024000>;
+ interrupts = <0 65 0x04 /* mpcore syncpt */
+ 0 67 0x04>; /* mpcore general */
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ ranges = <0x54000000 0x54000000 0x04000000>;
+
+ dc at 54200000 {
+ compatible = "nvidia,tegra20-dc";
+ reg = <0x54200000 0x00040000>;
+ interrupts = <0 73 0x04>;
+
+ rgb {
+ status = "okay";
+ nvidia,panel = <&lcd_panel>;
+ };
+ };
+};
+
+lcd_panel: panel {
+ /* Seaboard has 1366x768 */
+ clock = <70600000>;
+ xres = <1366>;
+ yres = <768>;
+ left-margin = <58>;
+ right-margin = <58>;
+ hsync-len = <58>;
+ lower-margin = <4>;
+ upper-margin = <4>;
+ vsync-len = <4>;
+ hsync-active-high;
+ nvidia,bits-per-pixel = <16>;
+ nvidia,pwm = <&pwm 2 0>;
+ nvidia,backlight-enable-gpios = <&gpio 28 0>; /* PD4 */
+ nvidia,lvds-shutdown-gpios = <&gpio 10 0>; /* PB2 */
+ nvidia,backlight-vdd-gpios = <&gpio 176 0>; /* PW0 */
+ nvidia,panel-vdd-gpios = <&gpio 22 0>; /* PC6 */
+ nvidia,panel-timings = <4 203 17 15>;
+};
--
1.7.7.3
^ permalink raw reply related [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 04/16] tegra: fdt: Add LCD definitions for Tegra
2012-09-28 0:44 ` [U-Boot] [PATCH v4 04/16] tegra: fdt: Add LCD definitions for Tegra Simon Glass
@ 2012-10-03 22:54 ` Stephen Warren
2012-10-03 22:58 ` Stephen Warren
1 sibling, 0 replies; 40+ messages in thread
From: Stephen Warren @ 2012-10-03 22:54 UTC (permalink / raw)
To: u-boot
On 09/27/2012 06:44 PM, Simon Glass wrote:
> Add LCD definitions and also a proposed binding for LCD displays.
>
> The PWM is as per what will likely be committed to linux-next soon.
>
> The displaymode binding comes from a proposal here:
>
> http://lists.freedesktop.org/archives/dri-devel/2012-July/024875.html
>
> The panel binding is new, and fills a need to specify the panel
> timings and other tegra-specific information. Should a binding appear
> that allows the pwm to handle this automatically, we can revisit
> this.
> diff --git a/doc/device-tree-bindings/video/displaymode.txt b/doc/device-tree-bindings/video/displaymode.txt
> +Example:
> +
> + display at 0 {
That should really be "mode" or "timing", since it's describing a
display mode/timing not a display. I believe the latest messages in that
thread indicate a similar change will be made to the proposed Linux binding.
> diff --git a/doc/device-tree-bindings/video/tegra20-dc.txt b/doc/device-tree-bindings/video/tegra20-dc.txt
> +Required properties (rgb) :
> + - nvidia,panel : phandle of LCD panel information
> +
> +
> +The panel node describes the panel itself. This has the properties listed in
> +displaymode.txt as well as:
It should really be a sub-node; like:
panel {
... all the panel-specific stuff from this binding ...
modes {
default {
... all the stuff from displaymode.txt ...
};
};
};
Since the panel itself and the (potentially, list of) modes it can
support are separate things.
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 04/16] tegra: fdt: Add LCD definitions for Tegra
2012-09-28 0:44 ` [U-Boot] [PATCH v4 04/16] tegra: fdt: Add LCD definitions for Tegra Simon Glass
2012-10-03 22:54 ` Stephen Warren
@ 2012-10-03 22:58 ` Stephen Warren
2012-10-08 20:01 ` Simon Glass
1 sibling, 1 reply; 40+ messages in thread
From: Stephen Warren @ 2012-10-03 22:58 UTC (permalink / raw)
To: u-boot
On 09/27/2012 06:44 PM, Simon Glass wrote:
> Add LCD definitions and also a proposed binding for LCD displays.
>
> The PWM is as per what will likely be committed to linux-next soon.
>
> The displaymode binding comes from a proposal here:
>
> http://lists.freedesktop.org/archives/dri-devel/2012-July/024875.html
>
> The panel binding is new, and fills a need to specify the panel
> timings and other tegra-specific information. Should a binding appear
> that allows the pwm to handle this automatically, we can revisit
> this.
> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
> + host1x {
> + compatible = "nvidia,tegra20-host1x", "simple-bus";
> + reg = <0x50000000 0x00024000>;
> + interrupts = <0 65 0x04 /* mpcore syncpt */
> + 0 67 0x04>; /* mpcore general */
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + ranges = <0x54000000 0x54000000 0x04000000>;
> +
> + /* video-encoding/decoding */
> + mpe {
> + reg = <0x54040000 0x00040000>;
> + interrupts = <0 68 0x04>;
> + };
Shouldn't all of these nodes have status="disabled", since in general
boards will want to opt-in to these modules. In fact, many of these
nodes won't end up (ever?) being used in U-Boot; perhaps we should only
add the nodes we care about.
> + /* display controllers */
> + dc at 54200000 {
> + compatible = "nvidia,tegra20-dc";
> + reg = <0x54200000 0x00040000>;
> + interrupts = <0 73 0x04>;
> +
> + rgb {
> + status = "disabled";
> + };
> + };
I think we definitely want status="disabled" in the dc nodes themselves,
since we definitely want boards in U-Boot to control whether to enable
the dc.
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 04/16] tegra: fdt: Add LCD definitions for Tegra
2012-10-03 22:58 ` Stephen Warren
@ 2012-10-08 20:01 ` Simon Glass
0 siblings, 0 replies; 40+ messages in thread
From: Simon Glass @ 2012-10-08 20:01 UTC (permalink / raw)
To: u-boot
Hi Stephen,
On Wed, Oct 3, 2012 at 3:58 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 09/27/2012 06:44 PM, Simon Glass wrote:
>> Add LCD definitions and also a proposed binding for LCD displays.
>>
>> The PWM is as per what will likely be committed to linux-next soon.
>>
>> The displaymode binding comes from a proposal here:
>>
>> http://lists.freedesktop.org/archives/dri-devel/2012-July/024875.html
>>
>> The panel binding is new, and fills a need to specify the panel
>> timings and other tegra-specific information. Should a binding appear
>> that allows the pwm to handle this automatically, we can revisit
>> this.
>
>> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
>
>> + host1x {
>> + compatible = "nvidia,tegra20-host1x", "simple-bus";
>> + reg = <0x50000000 0x00024000>;
>> + interrupts = <0 65 0x04 /* mpcore syncpt */
>> + 0 67 0x04>; /* mpcore general */
>> +
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + ranges = <0x54000000 0x54000000 0x04000000>;
>> +
>> + /* video-encoding/decoding */
>> + mpe {
>> + reg = <0x54040000 0x00040000>;
>> + interrupts = <0 68 0x04>;
>> + };
>
> Shouldn't all of these nodes have status="disabled", since in general
> boards will want to opt-in to these modules. In fact, many of these
> nodes won't end up (ever?) being used in U-Boot; perhaps we should only
> add the nodes we care about.
>
>> + /* display controllers */
>> + dc at 54200000 {
>> + compatible = "nvidia,tegra20-dc";
>> + reg = <0x54200000 0x00040000>;
>> + interrupts = <0 73 0x04>;
>> +
>> + rgb {
>> + status = "disabled";
>> + };
>> + };
>
> I think we definitely want status="disabled" in the dc nodes themselves,
> since we definitely want boards in U-Boot to control whether to enable
> the dc.
>
OK I will update these, thanks.
Regards,
Simon
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot] [PATCH v4 05/16] tegra: Add support for PWM
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
` (3 preceding siblings ...)
2012-09-28 0:44 ` [U-Boot] [PATCH v4 04/16] tegra: fdt: Add LCD definitions for Tegra Simon Glass
@ 2012-09-28 0:44 ` Simon Glass
2012-09-28 0:44 ` [U-Boot] [PATCH v4 06/16] tegra: Add SOC support for display/lcd Simon Glass
` (12 subsequent siblings)
17 siblings, 0 replies; 40+ messages in thread
From: Simon Glass @ 2012-09-28 0:44 UTC (permalink / raw)
To: u-boot
The pulse width/frequency modulation peripheral supports generating
a repeating pulse. It is useful for controlling LCD brightness.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v3:
- Rename pwfm driver to pwm
- Use new proposed upstream pwm binding
- Decode fdt node within the pwm driver
- Introduce concept of a pwm channel, rather than separate peripherals
Changes in v4:
- Add CONFIG_PWM_TEGRA to control inclusion of PWM support
- Add a little more debugging to the PWM driver
- Move code to set up PWM into the PWM commit
arch/arm/cpu/armv7/tegra20/Makefile | 1 +
arch/arm/cpu/armv7/tegra20/pwm.c | 101 +++++++++++++++++++++++++++++++
arch/arm/include/asm/arch-tegra20/pwm.h | 75 +++++++++++++++++++++++
board/nvidia/common/board.c | 5 ++
include/fdtdec.h | 1 +
lib/fdtdec.c | 1 +
6 files changed, 184 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/cpu/armv7/tegra20/pwm.c
create mode 100644 arch/arm/include/asm/arch-tegra20/pwm.h
diff --git a/arch/arm/cpu/armv7/tegra20/Makefile b/arch/arm/cpu/armv7/tegra20/Makefile
index 09a0314..77cb4d1 100644
--- a/arch/arm/cpu/armv7/tegra20/Makefile
+++ b/arch/arm/cpu/armv7/tegra20/Makefile
@@ -28,6 +28,7 @@ include $(TOPDIR)/config.mk
LIB = $(obj)lib$(SOC).o
COBJS-$(CONFIG_USB_EHCI_TEGRA) += usb.o
+COBJS-$(CONFIG_PWM_TEGRA) += pwm.o
COBJS := $(COBJS-y)
SRCS := $(COBJS:.o=.c)
diff --git a/arch/arm/cpu/armv7/tegra20/pwm.c b/arch/arm/cpu/armv7/tegra20/pwm.c
new file mode 100644
index 0000000..b655c5c
--- /dev/null
+++ b/arch/arm/cpu/armv7/tegra20/pwm.c
@@ -0,0 +1,101 @@
+/*
+ * Tegra2 pulse width frequency modulator definitions
+ *
+ * Copyright (c) 2011 The Chromium OS Authors.
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <common.h>
+#include <fdtdec.h>
+#include <asm/io.h>
+#include <asm/arch/clock.h>
+#include <asm/arch/pwm.h>
+
+struct pwm_info {
+ struct pwm_ctlr *pwm; /* Registers for our pwm controller */
+ int pwm_node; /* PWM device tree node */
+} local;
+
+void pwm_enable(unsigned channel, int rate, int pulse_width, int freq_divider)
+{
+ u32 reg;
+
+ assert(channel < PWM_NUM_CHANNELS);
+
+ /* TODO: Can we use clock_adjust_periph_pll_div() here? */
+ clock_start_periph_pll(PERIPH_ID_PWM, CLOCK_ID_SFROM32KHZ, rate);
+
+ reg = PWM_ENABLE_MASK;
+ reg |= pulse_width << PWM_WIDTH_SHIFT;
+ reg |= freq_divider << PWM_DIVIDER_SHIFT;
+ writel(reg, &local.pwm[channel].control);
+ debug("%s: channel=%d, rate=%d\n", __func__, channel, rate);
+}
+
+int pwm_request(const void *blob, int node, const char *prop_name)
+{
+ int pwm_node;
+ u32 data[3];
+
+ if (fdtdec_get_int_array(blob, node, prop_name, data,
+ ARRAY_SIZE(data))) {
+ debug("%s: Cannot decode PWM property '%s'\n", __func__,
+ prop_name);
+ return -1;
+ }
+
+ pwm_node = fdt_node_offset_by_phandle(blob, data[0]);
+ if (pwm_node != local.pwm_node) {
+ debug("%s: PWM property '%s' phandle %d not recognised"
+ "- expecting %d\n", __func__, prop_name, data[0],
+ local.pwm_node);
+ return -1;
+ }
+ if (data[1] >= PWM_NUM_CHANNELS) {
+ debug("%s: PWM property '%s': invalid channel %u\n", __func__,
+ prop_name, data[1]);
+ return -1;
+ }
+
+ /*
+ * TODO: We could maintain a list of requests, but it might not be
+ * worth it for U-Boot.
+ */
+ return data[1];
+}
+
+int pwm_init(const void *blob)
+{
+ local.pwm_node = fdtdec_next_compatible(blob, 0,
+ COMPAT_NVIDIA_TEGRA20_PWM);
+ if (local.pwm_node < 0) {
+ debug("%s: Cannot find device tree node\n", __func__);
+ return -1;
+ }
+
+ local.pwm = (struct pwm_ctlr *)fdtdec_get_addr(blob, local.pwm_node,
+ "reg");
+ if (local.pwm == (struct pwm_ctlr *)FDT_ADDR_T_NONE) {
+ debug("%s: Cannot find pwm reg address\n", __func__);
+ return -1;
+ }
+ debug("Tegra PWM@%p, node %d\n", local.pwm, local.pwm_node);
+
+ return 0;
+}
diff --git a/arch/arm/include/asm/arch-tegra20/pwm.h b/arch/arm/include/asm/arch-tegra20/pwm.h
new file mode 100644
index 0000000..9e03837
--- /dev/null
+++ b/arch/arm/include/asm/arch-tegra20/pwm.h
@@ -0,0 +1,75 @@
+/*
+ * Tegra pulse width frequency modulator definitions
+ *
+ * Copyright (c) 2011 The Chromium OS Authors.
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __ASM_ARCH_TEGRA_PWM_H
+#define __ASM_ARCH_TEGRA_PWM_H
+
+/* This is a single PWM channel */
+struct pwm_ctlr {
+ uint control; /* Control register */
+ uint reserved[3]; /* Space space */
+};
+
+#define PWM_NUM_CHANNELS 4
+
+/* PWM_CONTROLLER_PWM_CSR_0/1/2/3_0 */
+#define PWM_ENABLE_SHIFT 31
+#define PWM_ENABLE_MASK (0x1 << PWM_ENABLE_SHIFT)
+
+#define PWM_WIDTH_SHIFT 16
+#define PWM_WIDTH_MASK (0x7FFF << PWM_WIDTH_SHIFT)
+
+#define PWM_DIVIDER_SHIFT 0
+#define PWM_DIVIDER_MASK (0x1FFF << PWM_DIVIDER_SHIFT)
+
+/**
+ * Program the PWM with the given parameters.
+ *
+ * @param channel PWM channel to update
+ * @param rate Clock rate to use for PWM
+ * @param pulse_width high pulse width: 0=always low, 1=1/256 pulse high,
+ * n = n/256 pulse high
+ * @param freq_divider frequency divider value (1 to use rate as is)
+ */
+void pwm_enable(unsigned channel, int rate, int pulse_width, int freq_divider);
+
+/**
+ * Request a pwm channel as referenced by a device tree node.
+ *
+ * This channel can then be passed to pwm_enable().
+ *
+ * @param blob Device tree blob
+ * @param node Node containing reference to pwm
+ * @param prop_name Property name of pwm reference
+ * @return channel number, if ok, else -1
+ */
+int pwm_request(const void *blob, int node, const char *prop_name);
+
+/**
+ * Set up the pwm controller, by looking it up in the fdt.
+ *
+ * @return 0 if ok, -1 if the device tree node was not found or invalid.
+ */
+int pwm_init(const void *blob);
+
+#endif /* __ASM_ARCH_TEGRA_PWM_H */
diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c
index 8821fdf..7a7d55c 100644
--- a/board/nvidia/common/board.c
+++ b/board/nvidia/common/board.c
@@ -29,6 +29,7 @@
#include <asm/arch/emc.h>
#include <asm/arch/pinmux.h>
#include <asm/arch/pmu.h>
+#include <asm/arch/pwm.h>
#include <asm/arch/tegra.h>
#include <asm/arch/usb.h>
#include <asm/arch-tegra/board.h>
@@ -105,6 +106,10 @@ int board_init(void)
pin_mux_spi();
spi_init();
#endif
+#ifdef CONFIG_PWM_TEGRA
+ if (pwm_init(gd->fdt_blob))
+ debug("%s: Failed to init pwm\n", __func__);
+#endif
/* boot param addr */
gd->bd->bi_boot_params = (NV_PA_SDRAM_BASE + 0x100);
diff --git a/include/fdtdec.h b/include/fdtdec.h
index 0b14075..cdc87eb 100644
--- a/include/fdtdec.h
+++ b/include/fdtdec.h
@@ -66,6 +66,7 @@ enum fdt_compat_id {
COMPAT_NVIDIA_TEGRA20_EMC_TABLE, /* Tegra20 memory timing table */
COMPAT_NVIDIA_TEGRA20_KBC, /* Tegra20 Keyboard */
COMPAT_NVIDIA_TEGRA20_NAND, /* Tegra2 NAND controller */
+ COMPAT_NVIDIA_TEGRA20_PWM, /* Tegra 2 PWM controller */
COMPAT_COUNT,
};
diff --git a/lib/fdtdec.c b/lib/fdtdec.c
index 4c23f45..947f7c0 100644
--- a/lib/fdtdec.c
+++ b/lib/fdtdec.c
@@ -43,6 +43,7 @@ static const char * const compat_names[COMPAT_COUNT] = {
COMPAT(NVIDIA_TEGRA20_EMC_TABLE, "nvidia,tegra20-emc-table"),
COMPAT(NVIDIA_TEGRA20_KBC, "nvidia,tegra20-kbc"),
COMPAT(NVIDIA_TEGRA20_NAND, "nvidia,tegra20-nand"),
+ COMPAT(NVIDIA_TEGRA20_PWM, "nvidia,tegra20-pwm"),
};
const char *fdtdec_get_compatible(enum fdt_compat_id id)
--
1.7.7.3
^ permalink raw reply related [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 06/16] tegra: Add SOC support for display/lcd
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
` (4 preceding siblings ...)
2012-09-28 0:44 ` [U-Boot] [PATCH v4 05/16] tegra: Add support for PWM Simon Glass
@ 2012-09-28 0:44 ` Simon Glass
2012-09-28 0:44 ` [U-Boot] [PATCH v4 07/16] tegra: Add LCD driver Simon Glass
` (11 subsequent siblings)
17 siblings, 0 replies; 40+ messages in thread
From: Simon Glass @ 2012-09-28 0:44 UTC (permalink / raw)
To: u-boot
From: Wei Ni <wni@nvidia.com>
Add support for the LCD peripheral at the Tegra2 SOC level. A separate
LCD driver will use this functionality to configure the display.
Signed-off-by: Mayuresh Kulkarni <mkulkarni@nvidia.com>
Mayuresh Kulkarni:
- changes to remove bitfields and clean up for submission
Signed-off-by: Simon Glass <sjg@chromium.org>
Simon Glass:
- simplify code, move clock control into here, clean-up
---
Changes in v3:
- Separate display driver and LCD driver more in fdt
- Add probe function to read in fdt parameters in display driver
Changes in v4:
- Rebase on top of new tegra common directory structure
- Adjust fdt binding according to Thierry and Stephen's comments
- Remove LCD frame buffer address property hack
arch/arm/cpu/armv7/tegra20/Makefile | 1 +
arch/arm/cpu/armv7/tegra20/display.c | 409 ++++++++++++++++++++
arch/arm/include/asm/arch-tegra20/dc.h | 545 +++++++++++++++++++++++++++
arch/arm/include/asm/arch-tegra20/display.h | 152 ++++++++
include/fdtdec.h | 1 +
lib/fdtdec.c | 1 +
6 files changed, 1109 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/cpu/armv7/tegra20/display.c
create mode 100644 arch/arm/include/asm/arch-tegra20/dc.h
create mode 100644 arch/arm/include/asm/arch-tegra20/display.h
diff --git a/arch/arm/cpu/armv7/tegra20/Makefile b/arch/arm/cpu/armv7/tegra20/Makefile
index 77cb4d1..54ed8c4 100644
--- a/arch/arm/cpu/armv7/tegra20/Makefile
+++ b/arch/arm/cpu/armv7/tegra20/Makefile
@@ -29,6 +29,7 @@ LIB = $(obj)lib$(SOC).o
COBJS-$(CONFIG_USB_EHCI_TEGRA) += usb.o
COBJS-$(CONFIG_PWM_TEGRA) += pwm.o
+COBJS-$(CONFIG_VIDEO_TEGRA) += display.o
COBJS := $(COBJS-y)
SRCS := $(COBJS:.o=.c)
diff --git a/arch/arm/cpu/armv7/tegra20/display.c b/arch/arm/cpu/armv7/tegra20/display.c
new file mode 100644
index 0000000..031f9a8
--- /dev/null
+++ b/arch/arm/cpu/armv7/tegra20/display.c
@@ -0,0 +1,409 @@
+/*
+ * (C) Copyright 2010
+ * NVIDIA Corporation <www.nvidia.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <common.h>
+#include <asm/io.h>
+#include <asm/arch/clock.h>
+#include <asm/arch/tegra.h>
+#include <asm/arch/display.h>
+#include <asm/arch/dc.h>
+#include <asm/arch-tegra/clk_rst.h>
+#include <asm/arch-tegra/timer.h>
+
+static struct fdt_disp_config config;
+
+static void update_window(struct dc_ctlr *dc, struct disp_ctl_win *win)
+{
+ unsigned h_dda, v_dda;
+ unsigned long val;
+
+ val = readl(&dc->cmd.disp_win_header);
+ val |= WINDOW_A_SELECT;
+ writel(val, &dc->cmd.disp_win_header);
+
+ writel(win->fmt, &dc->win.color_depth);
+
+ clrsetbits_le32(&dc->win.byte_swap, BYTE_SWAP_MASK,
+ BYTE_SWAP_NOSWAP << BYTE_SWAP_SHIFT);
+
+ val = win->out_x << H_POSITION_SHIFT;
+ val |= win->out_y << V_POSITION_SHIFT;
+ writel(val, &dc->win.pos);
+
+ val = win->out_w << H_SIZE_SHIFT;
+ val |= win->out_h << V_SIZE_SHIFT;
+ writel(val, &dc->win.size);
+
+ val = (win->w * win->bpp / 8) << H_PRESCALED_SIZE_SHIFT;
+ val |= win->h << V_PRESCALED_SIZE_SHIFT;
+ writel(val, &dc->win.prescaled_size);
+
+ writel(0, &dc->win.h_initial_dda);
+ writel(0, &dc->win.v_initial_dda);
+
+ h_dda = (win->w * 0x1000) / max(win->out_w - 1, 1);
+ v_dda = (win->h * 0x1000) / max(win->out_h - 1, 1);
+
+ val = h_dda << H_DDA_INC_SHIFT;
+ val |= v_dda << V_DDA_INC_SHIFT;
+ writel(val, &dc->win.dda_increment);
+
+ writel(win->stride, &dc->win.line_stride);
+ writel(0, &dc->win.buf_stride);
+
+ val = WIN_ENABLE;
+ if (win->bpp < 24)
+ val |= COLOR_EXPAND;
+ writel(val, &dc->win.win_opt);
+
+ writel((unsigned long)win->phys_addr, &dc->winbuf.start_addr);
+ writel(win->x, &dc->winbuf.addr_h_offset);
+ writel(win->y, &dc->winbuf.addr_v_offset);
+
+ writel(0xff00, &dc->win.blend_nokey);
+ writel(0xff00, &dc->win.blend_1win);
+
+ val = GENERAL_ACT_REQ | WIN_A_ACT_REQ;
+ val |= GENERAL_UPDATE | WIN_A_UPDATE;
+ writel(val, &dc->cmd.state_ctrl);
+}
+
+static void write_pair(struct fdt_disp_config *config, int item, u32 *reg)
+{
+ writel(config->horiz_timing[item] |
+ (config->vert_timing[item] << 16), reg);
+}
+
+static int update_display_mode(struct dc_disp_reg *disp,
+ struct fdt_disp_config *config)
+{
+ unsigned long val;
+ unsigned long rate;
+ unsigned long div;
+
+ writel(0x0, &disp->disp_timing_opt);
+ write_pair(config, FDT_LCD_TIMING_REF_TO_SYNC, &disp->ref_to_sync);
+ write_pair(config, FDT_LCD_TIMING_SYNC_WIDTH, &disp->sync_width);
+ write_pair(config, FDT_LCD_TIMING_BACK_PORCH, &disp->back_porch);
+ write_pair(config, FDT_LCD_TIMING_FRONT_PORCH, &disp->front_porch);
+
+ writel(config->width | (config->height << 16), &disp->disp_active);
+
+ val = DE_SELECT_ACTIVE << DE_SELECT_SHIFT;
+ val |= DE_CONTROL_NORMAL << DE_CONTROL_SHIFT;
+ writel(val, &disp->data_enable_opt);
+
+ val = DATA_FORMAT_DF1P1C << DATA_FORMAT_SHIFT;
+ val |= DATA_ALIGNMENT_MSB << DATA_ALIGNMENT_SHIFT;
+ val |= DATA_ORDER_RED_BLUE << DATA_ORDER_SHIFT;
+ writel(val, &disp->disp_interface_ctrl);
+
+ /*
+ * The pixel clock divider is in 7.1 format (where the bottom bit
+ * represents 0.5). Here we calculate the divider needed to get from
+ * the display clock (typically 600MHz) to the pixel clock. We round
+ * up or down as requried.
+ */
+ rate = clock_get_periph_rate(PERIPH_ID_DISP1, CLOCK_ID_CGENERAL);
+ div = ((rate * 2 + config->pixel_clock / 2) / config->pixel_clock) - 2;
+ debug("Display clock %lu, divider %lu\n", rate, div);
+
+ writel(0x00010001, &disp->shift_clk_opt);
+
+ val = PIXEL_CLK_DIVIDER_PCD1 << PIXEL_CLK_DIVIDER_SHIFT;
+ val |= div << SHIFT_CLK_DIVIDER_SHIFT;
+ writel(val, &disp->disp_clk_ctrl);
+
+ return 0;
+}
+
+/* Start up the display and turn on power to PWMs */
+static void basic_init(struct dc_cmd_reg *cmd)
+{
+ u32 val;
+
+ writel(0x00000100, &cmd->gen_incr_syncpt_ctrl);
+ writel(0x0000011a, &cmd->cont_syncpt_vsync);
+ writel(0x00000000, &cmd->int_type);
+ writel(0x00000000, &cmd->int_polarity);
+ writel(0x00000000, &cmd->int_mask);
+ writel(0x00000000, &cmd->int_enb);
+
+ val = PW0_ENABLE | PW1_ENABLE | PW2_ENABLE;
+ val |= PW3_ENABLE | PW4_ENABLE | PM0_ENABLE;
+ val |= PM1_ENABLE;
+ writel(val, &cmd->disp_pow_ctrl);
+
+ val = readl(&cmd->disp_cmd);
+ val |= CTRL_MODE_C_DISPLAY << CTRL_MODE_SHIFT;
+ writel(val, &cmd->disp_cmd);
+}
+
+static void basic_init_timer(struct dc_disp_reg *disp)
+{
+ writel(0x00000020, &disp->mem_high_pri);
+ writel(0x00000001, &disp->mem_high_pri_timer);
+}
+
+static const u32 rgb_enb_tab[PIN_REG_COUNT] = {
+ 0x00000000,
+ 0x00000000,
+ 0x00000000,
+ 0x00000000,
+};
+
+static const u32 rgb_polarity_tab[PIN_REG_COUNT] = {
+ 0x00000000,
+ 0x01000000,
+ 0x00000000,
+ 0x00000000,
+};
+
+static const u32 rgb_data_tab[PIN_REG_COUNT] = {
+ 0x00000000,
+ 0x00000000,
+ 0x00000000,
+ 0x00000000,
+};
+
+static const u32 rgb_sel_tab[PIN_OUTPUT_SEL_COUNT] = {
+ 0x00000000,
+ 0x00000000,
+ 0x00000000,
+ 0x00000000,
+ 0x00210222,
+ 0x00002200,
+ 0x00020000,
+};
+
+static void rgb_enable(struct dc_com_reg *com)
+{
+ int i;
+
+ for (i = 0; i < PIN_REG_COUNT; i++) {
+ writel(rgb_enb_tab[i], &com->pin_output_enb[i]);
+ writel(rgb_polarity_tab[i], &com->pin_output_polarity[i]);
+ writel(rgb_data_tab[i], &com->pin_output_data[i]);
+ }
+
+ for (i = 0; i < PIN_OUTPUT_SEL_COUNT; i++)
+ writel(rgb_sel_tab[i], &com->pin_output_sel[i]);
+}
+
+int setup_window(struct disp_ctl_win *win, struct fdt_disp_config *config)
+{
+ win->x = 0;
+ win->y = 0;
+ win->w = config->width;
+ win->h = config->height;
+ win->out_x = 0;
+ win->out_y = 0;
+ win->out_w = config->width;
+ win->out_h = config->height;
+ win->phys_addr = config->frame_buffer;
+ win->stride = config->width * (1 << config->log2_bpp) / 8;
+ debug("%s: depth = %d\n", __func__, config->log2_bpp);
+ switch (config->log2_bpp) {
+ case 5:
+ case 24:
+ win->fmt = COLOR_DEPTH_R8G8B8A8;
+ win->bpp = 32;
+ break;
+ case 4:
+ win->fmt = COLOR_DEPTH_B5G6R5;
+ win->bpp = 16;
+ break;
+
+ default:
+ debug("Unsupported LCD bit depth");
+ return -1;
+ }
+
+ return 0;
+}
+
+struct fdt_disp_config *tegra_display_get_config(void)
+{
+ return config.valid ? &config : NULL;
+}
+
+static void debug_timing(const char *name, unsigned int timing[])
+{
+#ifdef DEBUG
+ int i;
+
+ debug("%s timing: ", name);
+ for (i = 0; i < FDT_LCD_TIMING_COUNT; i++)
+ debug("%d ", timing[i]);
+ debug("\n");
+#endif
+}
+
+/**
+ * Decode panel information from the fdt, according to a standard binding
+ *
+ * @param blob fdt blob
+ * @param node offset of fdt node to read from
+ * @param config structure to store fdt config into
+ * @return 0 if ok, -ve on error
+ */
+static int tegra_decode_panel(const void *blob, int node,
+ struct fdt_disp_config *config)
+{
+ int front, back, ref;
+
+ config->width = fdtdec_get_int(blob, node, "xres", -1);
+ config->height = fdtdec_get_int(blob, node, "yres", -1);
+ config->pixel_clock = fdtdec_get_int(blob, node, "clock", 0);
+ if (!config->pixel_clock || config->width == -1 ||
+ config->height == -1) {
+ debug("%s: Pixel parameters missing\n", __func__);
+ return -FDT_ERR_NOTFOUND;
+ }
+
+ back = fdtdec_get_int(blob, node, "left-margin", -1);
+ front = fdtdec_get_int(blob, node, "right-margin", -1);
+ ref = fdtdec_get_int(blob, node, "hsync-len", -1);
+ if ((back | front | ref) == -1) {
+ debug("%s: Horizontal parameters missing\n", __func__);
+ return -FDT_ERR_NOTFOUND;
+ }
+
+ /* Use a ref-to-sync of 1 always, and take this from the front porch */
+ config->horiz_timing[FDT_LCD_TIMING_REF_TO_SYNC] = 1;
+ config->horiz_timing[FDT_LCD_TIMING_SYNC_WIDTH] = ref;
+ config->horiz_timing[FDT_LCD_TIMING_BACK_PORCH] = back;
+ config->horiz_timing[FDT_LCD_TIMING_FRONT_PORCH] = front -
+ config->horiz_timing[FDT_LCD_TIMING_REF_TO_SYNC];
+ debug_timing("horiz", config->horiz_timing);
+
+ back = fdtdec_get_int(blob, node, "upper-margin", -1);
+ front = fdtdec_get_int(blob, node, "lower-margin", -1);
+ ref = fdtdec_get_int(blob, node, "vsync-len", -1);
+ if ((back | front | ref) == -1) {
+ debug("%s: Vertical parameters missing\n", __func__);
+ return -FDT_ERR_NOTFOUND;
+ }
+
+ config->vert_timing[FDT_LCD_TIMING_REF_TO_SYNC] = 1;
+ config->vert_timing[FDT_LCD_TIMING_SYNC_WIDTH] = ref;
+ config->vert_timing[FDT_LCD_TIMING_BACK_PORCH] = back;
+ config->vert_timing[FDT_LCD_TIMING_FRONT_PORCH] = front -
+ config->vert_timing[FDT_LCD_TIMING_REF_TO_SYNC];
+ debug_timing("vert", config->vert_timing);
+
+ return 0;
+}
+
+/**
+ * Decode the display controller information from the fdt.
+ *
+ * @param blob fdt blob
+ * @param config structure to store fdt config into
+ * @return 0 if ok, -ve on error
+ */
+static int tegra_display_decode_config(const void *blob,
+ struct fdt_disp_config *config)
+{
+ int node, rgb;
+ int bpp, bit;
+
+ /* TODO: Support multiple controllers */
+ node = fdtdec_next_compatible(blob, 0, COMPAT_NVIDIA_TEGRA20_DC);
+ if (node < 0) {
+ debug("%s: Cannot find display controller node in fdt\n",
+ __func__);
+ return node;
+ }
+ config->disp = (struct disp_ctlr *)fdtdec_get_addr(blob, node, "reg");
+ if (!config->disp) {
+ debug("%s: No display controller address\n", __func__);
+ return -1;
+ }
+
+ rgb = fdt_subnode_offset(blob, node, "rgb");
+
+ config->panel_node = fdtdec_lookup_phandle(blob, rgb, "nvidia,panel");
+ if (!config->panel_node < 0) {
+ debug("%s: Cannot find panel information\n", __func__);
+ return -1;
+ }
+
+ if (tegra_decode_panel(blob, config->panel_node, config)) {
+ debug("%s: Failed to decode panel information\n", __func__);
+ return -1;
+ }
+
+ bpp = fdtdec_get_int(blob, config->panel_node, "nvidia,bits-per-pixel",
+ -1);
+ bit = ffs(bpp) - 1;
+ if (bpp == (1 << bit))
+ config->log2_bpp = bit;
+ else
+ config->log2_bpp = bpp;
+ if (bpp == -1) {
+ debug("%s: Pixel bpp parameters missing\n", __func__);
+ return -FDT_ERR_NOTFOUND;
+ }
+ config->bpp = bpp;
+
+ config->valid = 1; /* we have a valid configuration */
+
+ return 0;
+}
+
+int tegra_display_probe(const void *blob, void *default_lcd_base)
+{
+ struct disp_ctl_win window;
+ struct dc_ctlr *dc;
+
+ if (tegra_display_decode_config(blob, &config))
+ return -1;
+
+ config.frame_buffer = (u32)default_lcd_base;
+
+ dc = (struct dc_ctlr *)config.disp;
+
+ /*
+ * A header file for clock constants was NAKed upstream.
+ * TODO: Put this into the FDT and fdt_lcd struct when we have clock
+ * support there
+ */
+ clock_start_periph_pll(PERIPH_ID_HOST1X, CLOCK_ID_PERIPH,
+ 144 * 1000000);
+ clock_start_periph_pll(PERIPH_ID_DISP1, CLOCK_ID_CGENERAL,
+ 600 * 1000000);
+ basic_init(&dc->cmd);
+ basic_init_timer(&dc->disp);
+ rgb_enable(&dc->com);
+
+ if (config.pixel_clock)
+ update_display_mode(&dc->disp, &config);
+
+ if (setup_window(&window, &config))
+ return -1;
+
+ update_window(dc, &window);
+
+ return 0;
+}
diff --git a/arch/arm/include/asm/arch-tegra20/dc.h b/arch/arm/include/asm/arch-tegra20/dc.h
new file mode 100644
index 0000000..37934e1
--- /dev/null
+++ b/arch/arm/include/asm/arch-tegra20/dc.h
@@ -0,0 +1,545 @@
+/*
+ * (C) Copyright 2010
+ * NVIDIA Corporation <www.nvidia.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __ASM_ARCH_TEGRA_DC_H
+#define __ASM_ARCH_TEGRA_DC_H
+
+/* Register definitions for the Tegra display controller */
+
+/* CMD register 0x000 ~ 0x43 */
+struct dc_cmd_reg {
+ /* Address 0x000 ~ 0x002 */
+ uint gen_incr_syncpt; /* _CMD_GENERAL_INCR_SYNCPT_0 */
+ uint gen_incr_syncpt_ctrl; /* _CMD_GENERAL_INCR_SYNCPT_CNTRL_0 */
+ uint gen_incr_syncpt_err; /* _CMD_GENERAL_INCR_SYNCPT_ERROR_0 */
+
+ uint reserved0[5]; /* reserved_0[5] */
+
+ /* Address 0x008 ~ 0x00a */
+ uint win_a_incr_syncpt; /* _CMD_WIN_A_INCR_SYNCPT_0 */
+ uint win_a_incr_syncpt_ctrl; /* _CMD_WIN_A_INCR_SYNCPT_CNTRL_0 */
+ uint win_a_incr_syncpt_err; /* _CMD_WIN_A_INCR_SYNCPT_ERROR_0 */
+
+ uint reserved1[5]; /* reserved_1[5] */
+
+ /* Address 0x010 ~ 0x012 */
+ uint win_b_incr_syncpt; /* _CMD_WIN_B_INCR_SYNCPT_0 */
+ uint win_b_incr_syncpt_ctrl; /* _CMD_WIN_B_INCR_SYNCPT_CNTRL_0 */
+ uint win_b_incr_syncpt_err; /* _CMD_WIN_B_INCR_SYNCPT_ERROR_0 */
+
+ uint reserved2[5]; /* reserved_2[5] */
+
+ /* Address 0x018 ~ 0x01a */
+ uint win_c_incr_syncpt; /* _CMD_WIN_C_INCR_SYNCPT_0 */
+ uint win_c_incr_syncpt_ctrl; /* _CMD_WIN_C_INCR_SYNCPT_CNTRL_0 */
+ uint win_c_incr_syncpt_err; /* _CMD_WIN_C_INCR_SYNCPT_ERROR_0 */
+
+ uint reserved3[13]; /* reserved_3[13] */
+
+ /* Address 0x028 */
+ uint cont_syncpt_vsync; /* _CMD_CONT_SYNCPT_VSYNC_0 */
+
+ uint reserved4[7]; /* reserved_4[7] */
+
+ /* Address 0x030 ~ 0x033 */
+ uint ctxsw; /* _CMD_CTXSW_0 */
+ uint disp_cmd_opt0; /* _CMD_DISPLAY_COMMAND_OPTION0_0 */
+ uint disp_cmd; /* _CMD_DISPLAY_COMMAND_0 */
+ uint sig_raise; /* _CMD_SIGNAL_RAISE_0 */
+
+ uint reserved5[2]; /* reserved_0[2] */
+
+ /* Address 0x036 ~ 0x03e */
+ uint disp_pow_ctrl; /* _CMD_DISPLAY_POWER_CONTROL_0 */
+ uint int_stat; /* _CMD_INT_STATUS_0 */
+ uint int_mask; /* _CMD_INT_MASK_0 */
+ uint int_enb; /* _CMD_INT_ENABLE_0 */
+ uint int_type; /* _CMD_INT_TYPE_0 */
+ uint int_polarity; /* _CMD_INT_POLARITY_0 */
+ uint sig_raise1; /* _CMD_SIGNAL_RAISE1_0 */
+ uint sig_raise2; /* _CMD_SIGNAL_RAISE2_0 */
+ uint sig_raise3; /* _CMD_SIGNAL_RAISE3_0 */
+
+ uint reserved6; /* reserved_6 */
+
+ /* Address 0x040 ~ 0x043 */
+ uint state_access; /* _CMD_STATE_ACCESS_0 */
+ uint state_ctrl; /* _CMD_STATE_CONTROL_0 */
+ uint disp_win_header; /* _CMD_DISPLAY_WINDOW_HEADER_0 */
+ uint reg_act_ctrl; /* _CMD_REG_ACT_CONTROL_0 */
+};
+
+enum {
+ PIN_REG_COUNT = 4,
+ PIN_OUTPUT_SEL_COUNT = 7,
+};
+
+/* COM register 0x300 ~ 0x329 */
+struct dc_com_reg {
+ /* Address 0x300 ~ 0x301 */
+ uint crc_ctrl; /* _COM_CRC_CONTROL_0 */
+ uint crc_checksum; /* _COM_CRC_CHECKSUM_0 */
+
+ /* _COM_PIN_OUTPUT_ENABLE0/1/2/3_0: Address 0x302 ~ 0x305 */
+ uint pin_output_enb[PIN_REG_COUNT];
+
+ /* _COM_PIN_OUTPUT_POLARITY0/1/2/3_0: Address 0x306 ~ 0x309 */
+ uint pin_output_polarity[PIN_REG_COUNT];
+
+ /* _COM_PIN_OUTPUT_DATA0/1/2/3_0: Address 0x30a ~ 0x30d */
+ uint pin_output_data[PIN_REG_COUNT];
+
+ /* _COM_PIN_INPUT_ENABLE0_0: Address 0x30e ~ 0x311 */
+ uint pin_input_enb[PIN_REG_COUNT];
+
+ /* Address 0x312 ~ 0x313 */
+ uint pin_input_data0; /* _COM_PIN_INPUT_DATA0_0 */
+ uint pin_input_data1; /* _COM_PIN_INPUT_DATA1_0 */
+
+ /* _COM_PIN_OUTPUT_SELECT0/1/2/3/4/5/6_0: Address 0x314 ~ 0x31a */
+ uint pin_output_sel[PIN_OUTPUT_SEL_COUNT];
+
+ /* Address 0x31b ~ 0x329 */
+ uint pin_misc_ctrl; /* _COM_PIN_MISC_CONTROL_0 */
+ uint pm0_ctrl; /* _COM_PM0_CONTROL_0 */
+ uint pm0_duty_cycle; /* _COM_PM0_DUTY_CYCLE_0 */
+ uint pm1_ctrl; /* _COM_PM1_CONTROL_0 */
+ uint pm1_duty_cycle; /* _COM_PM1_DUTY_CYCLE_0 */
+ uint spi_ctrl; /* _COM_SPI_CONTROL_0 */
+ uint spi_start_byte; /* _COM_SPI_START_BYTE_0 */
+ uint hspi_wr_data_ab; /* _COM_HSPI_WRITE_DATA_AB_0 */
+ uint hspi_wr_data_cd; /* _COM_HSPI_WRITE_DATA_CD */
+ uint hspi_cs_dc; /* _COM_HSPI_CS_DC_0 */
+ uint scratch_reg_a; /* _COM_SCRATCH_REGISTER_A_0 */
+ uint scratch_reg_b; /* _COM_SCRATCH_REGISTER_B_0 */
+ uint gpio_ctrl; /* _COM_GPIO_CTRL_0 */
+ uint gpio_debounce_cnt; /* _COM_GPIO_DEBOUNCE_COUNTER_0 */
+ uint crc_checksum_latched; /* _COM_CRC_CHECKSUM_LATCHED_0 */
+};
+
+enum dc_disp_h_pulse_pos {
+ H_PULSE0_POSITION_A,
+ H_PULSE0_POSITION_B,
+ H_PULSE0_POSITION_C,
+ H_PULSE0_POSITION_D,
+ H_PULSE0_POSITION_COUNT,
+};
+
+struct _disp_h_pulse {
+ /* _DISP_H_PULSE0/1/2_CONTROL_0 */
+ uint h_pulse_ctrl;
+ /* _DISP_H_PULSE0/1/2_POSITION_A/B/C/D_0 */
+ uint h_pulse_pos[H_PULSE0_POSITION_COUNT];
+};
+
+enum dc_disp_v_pulse_pos {
+ V_PULSE0_POSITION_A,
+ V_PULSE0_POSITION_B,
+ V_PULSE0_POSITION_C,
+ V_PULSE0_POSITION_COUNT,
+};
+
+struct _disp_v_pulse0 {
+ /* _DISP_H_PULSE0/1_CONTROL_0 */
+ uint v_pulse_ctrl;
+ /* _DISP_H_PULSE0/1_POSITION_A/B/C_0 */
+ uint v_pulse_pos[V_PULSE0_POSITION_COUNT];
+};
+
+struct _disp_v_pulse2 {
+ /* _DISP_H_PULSE2/3_CONTROL_0 */
+ uint v_pulse_ctrl;
+ /* _DISP_H_PULSE2/3_POSITION_A_0 */
+ uint v_pulse_pos_a;
+};
+
+enum dc_disp_h_pulse_reg {
+ H_PULSE0,
+ H_PULSE1,
+ H_PULSE2,
+ H_PULSE_COUNT,
+};
+
+enum dc_disp_pp_select {
+ PP_SELECT_A,
+ PP_SELECT_B,
+ PP_SELECT_C,
+ PP_SELECT_D,
+ PP_SELECT_COUNT,
+};
+
+/* DISP register 0x400 ~ 0x4c1 */
+struct dc_disp_reg {
+ /* Address 0x400 ~ 0x40a */
+ uint disp_signal_opt0; /* _DISP_DISP_SIGNAL_OPTIONS0_0 */
+ uint disp_signal_opt1; /* _DISP_DISP_SIGNAL_OPTIONS1_0 */
+ uint disp_win_opt; /* _DISP_DISP_WIN_OPTIONS_0 */
+ uint mem_high_pri; /* _DISP_MEM_HIGH_PRIORITY_0 */
+ uint mem_high_pri_timer; /* _DISP_MEM_HIGH_PRIORITY_TIMER_0 */
+ uint disp_timing_opt; /* _DISP_DISP_TIMING_OPTIONS_0 */
+ uint ref_to_sync; /* _DISP_REF_TO_SYNC_0 */
+ uint sync_width; /* _DISP_SYNC_WIDTH_0 */
+ uint back_porch; /* _DISP_BACK_PORCH_0 */
+ uint disp_active; /* _DISP_DISP_ACTIVE_0 */
+ uint front_porch; /* _DISP_FRONT_PORCH_0 */
+
+ /* Address 0x40b ~ 0x419: _DISP_H_PULSE0/1/2_ */
+ struct _disp_h_pulse h_pulse[H_PULSE_COUNT];
+
+ /* Address 0x41a ~ 0x421 */
+ struct _disp_v_pulse0 v_pulse0; /* _DISP_V_PULSE0_ */
+ struct _disp_v_pulse0 v_pulse1; /* _DISP_V_PULSE1_ */
+
+ /* Address 0x422 ~ 0x425 */
+ struct _disp_v_pulse2 v_pulse3; /* _DISP_V_PULSE2_ */
+ struct _disp_v_pulse2 v_pulse4; /* _DISP_V_PULSE3_ */
+
+ /* Address 0x426 ~ 0x429 */
+ uint m0_ctrl; /* _DISP_M0_CONTROL_0 */
+ uint m1_ctrl; /* _DISP_M1_CONTROL_0 */
+ uint di_ctrl; /* _DISP_DI_CONTROL_0 */
+ uint pp_ctrl; /* _DISP_PP_CONTROL_0 */
+
+ /* Address 0x42a ~ 0x42d: _DISP_PP_SELECT_A/B/C/D_0 */
+ uint pp_select[PP_SELECT_COUNT];
+
+ /* Address 0x42e ~ 0x435 */
+ uint disp_clk_ctrl; /* _DISP_DISP_CLOCK_CONTROL_0 */
+ uint disp_interface_ctrl; /* _DISP_DISP_INTERFACE_CONTROL_0 */
+ uint disp_color_ctrl; /* _DISP_DISP_COLOR_CONTROL_0 */
+ uint shift_clk_opt; /* _DISP_SHIFT_CLOCK_OPTIONS_0 */
+ uint data_enable_opt; /* _DISP_DATA_ENABLE_OPTIONS_0 */
+ uint serial_interface_opt; /* _DISP_SERIAL_INTERFACE_OPTIONS_0 */
+ uint lcd_spi_opt; /* _DISP_LCD_SPI_OPTIONS_0 */
+ uint border_color; /* _DISP_BORDER_COLOR_0 */
+
+ /* Address 0x436 ~ 0x439 */
+ uint color_key0_lower; /* _DISP_COLOR_KEY0_LOWER_0 */
+ uint color_key0_upper; /* _DISP_COLOR_KEY0_UPPER_0 */
+ uint color_key1_lower; /* _DISP_COLOR_KEY1_LOWER_0 */
+ uint color_key1_upper; /* _DISP_COLOR_KEY1_UPPER_0 */
+
+ uint reserved0[2]; /* reserved_0[2] */
+
+ /* Address 0x43c ~ 0x442 */
+ uint cursor_foreground; /* _DISP_CURSOR_FOREGROUND_0 */
+ uint cursor_background; /* _DISP_CURSOR_BACKGROUND_0 */
+ uint cursor_start_addr; /* _DISP_CURSOR_START_ADDR_0 */
+ uint cursor_start_addr_ns; /* _DISP_CURSOR_START_ADDR_NS_0 */
+ uint cursor_pos; /* _DISP_CURSOR_POSITION_0 */
+ uint cursor_pos_ns; /* _DISP_CURSOR_POSITION_NS_0 */
+ uint seq_ctrl; /* _DISP_INIT_SEQ_CONTROL_0 */
+
+ /* Address 0x442 ~ 0x446 */
+ uint spi_init_seq_data_a; /* _DISP_SPI_INIT_SEQ_DATA_A_0 */
+ uint spi_init_seq_data_b; /* _DISP_SPI_INIT_SEQ_DATA_B_0 */
+ uint spi_init_seq_data_c; /* _DISP_SPI_INIT_SEQ_DATA_C_0 */
+ uint spi_init_seq_data_d; /* _DISP_SPI_INIT_SEQ_DATA_D_0 */
+
+ uint reserved1[0x39]; /* reserved1[0x39], */
+
+ /* Address 0x480 ~ 0x484 */
+ uint dc_mccif_fifoctrl; /* _DISP_DC_MCCIF_FIFOCTRL_0 */
+ uint mccif_disp0a_hyst; /* _DISP_MCCIF_DISPLAY0A_HYST_0 */
+ uint mccif_disp0b_hyst; /* _DISP_MCCIF_DISPLAY0B_HYST_0 */
+ uint mccif_disp0c_hyst; /* _DISP_MCCIF_DISPLAY0C_HYST_0 */
+ uint mccif_disp1b_hyst; /* _DISP_MCCIF_DISPLAY1B_HYST_0 */
+
+ uint reserved2[0x3b]; /* reserved2[0x3b] */
+
+ /* Address 0x4c0 ~ 0x4c1 */
+ uint dac_crt_ctrl; /* _DISP_DAC_CRT_CTRL_0 */
+ uint disp_misc_ctrl; /* _DISP_DISP_MISC_CONTROL_0 */
+};
+
+enum dc_winc_filter_p {
+ WINC_FILTER_COUNT = 0x10,
+};
+
+/* Window A/B/C register 0x500 ~ 0x628 */
+struct dc_winc_reg {
+
+ /* Address 0x500 */
+ uint color_palette; /* _WINC_COLOR_PALETTE_0 */
+
+ uint reserved0[0xff]; /* reserved_0[0xff] */
+
+ /* Address 0x600 */
+ uint palette_color_ext; /* _WINC_PALETTE_COLOR_EXT_0 */
+
+ /* _WINC_H_FILTER_P00~0F_0 */
+ /* Address 0x601 ~ 0x610 */
+ uint h_filter_p[WINC_FILTER_COUNT];
+
+ /* Address 0x611 ~ 0x618 */
+ uint csc_yof; /* _WINC_CSC_YOF_0 */
+ uint csc_kyrgb; /* _WINC_CSC_KYRGB_0 */
+ uint csc_kur; /* _WINC_CSC_KUR_0 */
+ uint csc_kvr; /* _WINC_CSC_KVR_0 */
+ uint csc_kug; /* _WINC_CSC_KUG_0 */
+ uint csc_kvg; /* _WINC_CSC_KVG_0 */
+ uint csc_kub; /* _WINC_CSC_KUB_0 */
+ uint csc_kvb; /* _WINC_CSC_KVB_0 */
+
+ /* Address 0x619 ~ 0x628: _WINC_V_FILTER_P00~0F_0 */
+ uint v_filter_p[WINC_FILTER_COUNT];
+};
+
+/* WIN A/B/C Register 0x700 ~ 0x714*/
+struct dc_win_reg {
+ /* Address 0x700 ~ 0x714 */
+ uint win_opt; /* _WIN_WIN_OPTIONS_0 */
+ uint byte_swap; /* _WIN_BYTE_SWAP_0 */
+ uint buffer_ctrl; /* _WIN_BUFFER_CONTROL_0 */
+ uint color_depth; /* _WIN_COLOR_DEPTH_0 */
+ uint pos; /* _WIN_POSITION_0 */
+ uint size; /* _WIN_SIZE_0 */
+ uint prescaled_size; /* _WIN_PRESCALED_SIZE_0 */
+ uint h_initial_dda; /* _WIN_H_INITIAL_DDA_0 */
+ uint v_initial_dda; /* _WIN_V_INITIAL_DDA_0 */
+ uint dda_increment; /* _WIN_DDA_INCREMENT_0 */
+ uint line_stride; /* _WIN_LINE_STRIDE_0 */
+ uint buf_stride; /* _WIN_BUF_STRIDE_0 */
+ uint uv_buf_stride; /* _WIN_UV_BUF_STRIDE_0 */
+ uint buffer_addr_mode; /* _WIN_BUFFER_ADDR_MODE_0 */
+ uint dv_ctrl; /* _WIN_DV_CONTROL_0 */
+ uint blend_nokey; /* _WIN_BLEND_NOKEY_0 */
+ uint blend_1win; /* _WIN_BLEND_1WIN_0 */
+ uint blend_2win_x; /* _WIN_BLEND_2WIN_X_0 */
+ uint blend_2win_y; /* _WIN_BLEND_2WIN_Y_0 */
+ uint blend_3win_xy; /* _WIN_BLEND_3WIN_XY_0 */
+ uint hp_fetch_ctrl; /* _WIN_HP_FETCH_CONTROL_0 */
+};
+
+/* WINBUF A/B/C Register 0x800 ~ 0x80a */
+struct dc_winbuf_reg {
+ /* Address 0x800 ~ 0x80a */
+ uint start_addr; /* _WINBUF_START_ADDR_0 */
+ uint start_addr_ns; /* _WINBUF_START_ADDR_NS_0 */
+ uint start_addr_u; /* _WINBUF_START_ADDR_U_0 */
+ uint start_addr_u_ns; /* _WINBUF_START_ADDR_U_NS_0 */
+ uint start_addr_v; /* _WINBUF_START_ADDR_V_0 */
+ uint start_addr_v_ns; /* _WINBUF_START_ADDR_V_NS_0 */
+ uint addr_h_offset; /* _WINBUF_ADDR_H_OFFSET_0 */
+ uint addr_h_offset_ns; /* _WINBUF_ADDR_H_OFFSET_NS_0 */
+ uint addr_v_offset; /* _WINBUF_ADDR_V_OFFSET_0 */
+ uint addr_v_offset_ns; /* _WINBUF_ADDR_V_OFFSET_NS_0 */
+ uint uflow_status; /* _WINBUF_UFLOW_STATUS_0 */
+};
+
+/* Display Controller (DC_) regs */
+struct dc_ctlr {
+ struct dc_cmd_reg cmd; /* CMD register 0x000 ~ 0x43 */
+ uint reserved0[0x2bc];
+
+ struct dc_com_reg com; /* COM register 0x300 ~ 0x329 */
+ uint reserved1[0xd6];
+
+ struct dc_disp_reg disp; /* DISP register 0x400 ~ 0x4c1 */
+ uint reserved2[0x3e];
+
+ struct dc_winc_reg winc; /* Window A/B/C 0x500 ~ 0x628 */
+ uint reserved3[0xd7];
+
+ struct dc_win_reg win; /* WIN A/B/C 0x700 ~ 0x714*/
+ uint reserved4[0xeb];
+
+ struct dc_winbuf_reg winbuf; /* WINBUF A/B/C 0x800 ~ 0x80a */
+};
+
+#define BIT(pos) (1U << pos)
+
+/* DC_CMD_DISPLAY_COMMAND 0x032 */
+#define CTRL_MODE_SHIFT 5
+#define CTRL_MODE_MASK (0x3 << CTRL_MODE_SHIFT)
+enum {
+ CTRL_MODE_STOP,
+ CTRL_MODE_C_DISPLAY,
+ CTRL_MODE_NC_DISPLAY,
+};
+
+/* _WIN_COLOR_DEPTH_0 */
+enum win_color_depth_id {
+ COLOR_DEPTH_P1,
+ COLOR_DEPTH_P2,
+ COLOR_DEPTH_P4,
+ COLOR_DEPTH_P8,
+ COLOR_DEPTH_B4G4R4A4,
+ COLOR_DEPTH_B5G5R5A,
+ COLOR_DEPTH_B5G6R5,
+ COLOR_DEPTH_AB5G5R5,
+ COLOR_DEPTH_B8G8R8A8 = 12,
+ COLOR_DEPTH_R8G8B8A8,
+ COLOR_DEPTH_B6x2G6x2R6x2A8,
+ COLOR_DEPTH_R6x2G6x2B6x2A8,
+ COLOR_DEPTH_YCbCr422,
+ COLOR_DEPTH_YUV422,
+ COLOR_DEPTH_YCbCr420P,
+ COLOR_DEPTH_YUV420P,
+ COLOR_DEPTH_YCbCr422P,
+ COLOR_DEPTH_YUV422P,
+ COLOR_DEPTH_YCbCr422R,
+ COLOR_DEPTH_YUV422R,
+ COLOR_DEPTH_YCbCr422RA,
+ COLOR_DEPTH_YUV422RA,
+};
+
+/* DC_CMD_DISPLAY_POWER_CONTROL 0x036 */
+#define PW0_ENABLE BIT(0)
+#define PW1_ENABLE BIT(2)
+#define PW2_ENABLE BIT(4)
+#define PW3_ENABLE BIT(6)
+#define PW4_ENABLE BIT(8)
+#define PM0_ENABLE BIT(16)
+#define PM1_ENABLE BIT(18)
+#define SPI_ENABLE BIT(24)
+#define HSPI_ENABLE BIT(25)
+
+/* DC_CMD_STATE_CONTROL 0x041 */
+#define GENERAL_ACT_REQ BIT(0)
+#define WIN_A_ACT_REQ BIT(1)
+#define WIN_B_ACT_REQ BIT(2)
+#define WIN_C_ACT_REQ BIT(3)
+#define GENERAL_UPDATE BIT(8)
+#define WIN_A_UPDATE BIT(9)
+#define WIN_B_UPDATE BIT(10)
+#define WIN_C_UPDATE BIT(11)
+
+/* DC_CMD_DISPLAY_WINDOW_HEADER 0x042 */
+#define WINDOW_A_SELECT BIT(4)
+#define WINDOW_B_SELECT BIT(5)
+#define WINDOW_C_SELECT BIT(6)
+
+/* DC_DISP_DISP_CLOCK_CONTROL 0x42e */
+#define SHIFT_CLK_DIVIDER_SHIFT 0
+#define SHIFT_CLK_DIVIDER_MASK (0xff << SHIFT_CLK_DIVIDER_SHIFT)
+#define PIXEL_CLK_DIVIDER_SHIFT 8
+#define PIXEL_CLK_DIVIDER_MSK (0xf << PIXEL_CLK_DIVIDER_SHIFT)
+enum {
+ PIXEL_CLK_DIVIDER_PCD1,
+ PIXEL_CLK_DIVIDER_PCD1H,
+ PIXEL_CLK_DIVIDER_PCD2,
+ PIXEL_CLK_DIVIDER_PCD3,
+ PIXEL_CLK_DIVIDER_PCD4,
+ PIXEL_CLK_DIVIDER_PCD6,
+ PIXEL_CLK_DIVIDER_PCD8,
+ PIXEL_CLK_DIVIDER_PCD9,
+ PIXEL_CLK_DIVIDER_PCD12,
+ PIXEL_CLK_DIVIDER_PCD16,
+ PIXEL_CLK_DIVIDER_PCD18,
+ PIXEL_CLK_DIVIDER_PCD24,
+ PIXEL_CLK_DIVIDER_PCD13,
+};
+
+/* DC_DISP_DISP_INTERFACE_CONTROL 0x42f */
+#define DATA_FORMAT_SHIFT 0
+#define DATA_FORMAT_MASK (0xf << DATA_FORMAT_SHIFT)
+enum {
+ DATA_FORMAT_DF1P1C,
+ DATA_FORMAT_DF1P2C24B,
+ DATA_FORMAT_DF1P2C18B,
+ DATA_FORMAT_DF1P2C16B,
+ DATA_FORMAT_DF2S,
+ DATA_FORMAT_DF3S,
+ DATA_FORMAT_DFSPI,
+ DATA_FORMAT_DF1P3C24B,
+ DATA_FORMAT_DF1P3C18B,
+};
+#define DATA_ALIGNMENT_SHIFT 8
+enum {
+ DATA_ALIGNMENT_MSB,
+ DATA_ALIGNMENT_LSB,
+};
+#define DATA_ORDER_SHIFT 9
+enum {
+ DATA_ORDER_RED_BLUE,
+ DATA_ORDER_BLUE_RED,
+};
+
+/* DC_DISP_DATA_ENABLE_OPTIONS 0x432 */
+#define DE_SELECT_SHIFT 0
+#define DE_SELECT_MASK (0x3 << DE_SELECT_SHIFT)
+#define DE_SELECT_ACTIVE_BLANK 0x0
+#define DE_SELECT_ACTIVE 0x1
+#define DE_SELECT_ACTIVE_IS 0x2
+#define DE_CONTROL_SHIFT 2
+#define DE_CONTROL_MASK (0x7 << DE_CONTROL_SHIFT)
+enum {
+ DE_CONTROL_ONECLK,
+ DE_CONTROL_NORMAL,
+ DE_CONTROL_EARLY_EXT,
+ DE_CONTROL_EARLY,
+ DE_CONTROL_ACTIVE_BLANK,
+};
+
+/* DC_WIN_WIN_OPTIONS 0x700 */
+#define H_DIRECTION BIT(0)
+enum {
+ H_DIRECTION_INCREMENT,
+ H_DIRECTION_DECREMENT,
+};
+#define V_DIRECTION BIT(2)
+enum {
+ V_DIRECTION_INCREMENT,
+ V_DIRECTION_DECREMENT,
+};
+#define COLOR_EXPAND BIT(6)
+#define CP_ENABLE BIT(16)
+#define DV_ENABLE BIT(20)
+#define WIN_ENABLE BIT(30)
+
+/* DC_WIN_BYTE_SWAP 0x701 */
+#define BYTE_SWAP_SHIFT 0
+#define BYTE_SWAP_MASK (3 << BYTE_SWAP_SHIFT)
+enum {
+ BYTE_SWAP_NOSWAP,
+ BYTE_SWAP_SWAP2,
+ BYTE_SWAP_SWAP4,
+ BYTE_SWAP_SWAP4HW
+};
+
+/* DC_WIN_POSITION 0x704 */
+#define H_POSITION_SHIFT 0
+#define H_POSITION_MASK (0x1FFF << H_POSITION_SHIFT)
+#define V_POSITION_SHIFT 16
+#define V_POSITION_MASK (0x1FFF << V_POSITION_SHIFT)
+
+/* DC_WIN_SIZE 0x705 */
+#define H_SIZE_SHIFT 0
+#define H_SIZE_MASK (0x1FFF << H_SIZE_SHIFT)
+#define V_SIZE_SHIFT 16
+#define V_SIZE_MASK (0x1FFF << V_SIZE_SHIFT)
+
+/* DC_WIN_PRESCALED_SIZE 0x706 */
+#define H_PRESCALED_SIZE_SHIFT 0
+#define H_PRESCALED_SIZE_MASK (0x7FFF << H_PRESCALED_SIZE)
+#define V_PRESCALED_SIZE_SHIFT 16
+#define V_PRESCALED_SIZE_MASK (0x1FFF << V_PRESCALED_SIZE)
+
+/* DC_WIN_DDA_INCREMENT 0x709 */
+#define H_DDA_INC_SHIFT 0
+#define H_DDA_INC_MASK (0xFFFF << H_DDA_INC_SHIFT)
+#define V_DDA_INC_SHIFT 16
+#define V_DDA_INC_MASK (0xFFFF << V_DDA_INC_SHIFT)
+
+#endif /* __ASM_ARCH_TEGRA_DC_H */
diff --git a/arch/arm/include/asm/arch-tegra20/display.h b/arch/arm/include/asm/arch-tegra20/display.h
new file mode 100644
index 0000000..c870959
--- /dev/null
+++ b/arch/arm/include/asm/arch-tegra20/display.h
@@ -0,0 +1,152 @@
+/*
+ * (C) Copyright 2010
+ * NVIDIA Corporation <www.nvidia.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __ASM_ARCH_TEGRA_DISPLAY_H
+#define __ASM_ARCH_TEGRA_DISPLAY_H
+
+#include <asm/arch/dc.h>
+#include <fdtdec.h>
+
+/* This holds information about a window which can be displayed */
+struct disp_ctl_win {
+ enum win_color_depth_id fmt; /* Color depth/format */
+ unsigned bpp; /* Bits per pixel */
+ phys_addr_t phys_addr; /* Physical address in memory */
+ unsigned x; /* Horizontal address offset (bytes) */
+ unsigned y; /* Veritical address offset (bytes) */
+ unsigned w; /* Width of source window */
+ unsigned h; /* Height of source window */
+ unsigned stride; /* Number of bytes per line */
+ unsigned out_x; /* Left edge of output window (col) */
+ unsigned out_y; /* Top edge of output window (row) */
+ unsigned out_w; /* Width of output window in pixels */
+ unsigned out_h; /* Height of output window in pixels */
+};
+
+#define FDT_LCD_TIMINGS 4
+
+enum {
+ FDT_LCD_TIMING_REF_TO_SYNC,
+ FDT_LCD_TIMING_SYNC_WIDTH,
+ FDT_LCD_TIMING_BACK_PORCH,
+ FDT_LCD_TIMING_FRONT_PORCH,
+
+ FDT_LCD_TIMING_COUNT,
+};
+
+enum lcd_cache_t {
+ FDT_LCD_CACHE_OFF = 0,
+ FDT_LCD_CACHE_WRITE_THROUGH = 1 << 0,
+ FDT_LCD_CACHE_WRITE_BACK = 1 << 1,
+ FDT_LCD_CACHE_FLUSH = 1 << 2,
+ FDT_LCD_CACHE_WRITE_BACK_FLUSH = FDT_LCD_CACHE_WRITE_BACK |
+ FDT_LCD_CACHE_FLUSH,
+};
+
+/* Information about the display controller */
+struct fdt_disp_config {
+ int valid; /* config is valid */
+ int width; /* width in pixels */
+ int height; /* height in pixels */
+ int bpp; /* number of bits per pixel */
+
+ /*
+ * log2 of number of bpp, in general, unless it bpp is 24 in which
+ * case this field holds 24 also! This is a U-Boot thing.
+ */
+ int log2_bpp;
+ struct disp_ctlr *disp; /* Display controller to use */
+ fdt_addr_t frame_buffer; /* Address of frame buffer */
+ unsigned pixel_clock; /* Pixel clock in Hz */
+ uint horiz_timing[FDT_LCD_TIMING_COUNT]; /* Horizontal timing */
+ uint vert_timing[FDT_LCD_TIMING_COUNT]; /* Vertical timing */
+ int panel_node; /* node offset of panel information */
+};
+
+/* Information about the LCD panel */
+struct fdt_panel_config {
+ int pwm_channel; /* PWM channel to use for backlight */
+ enum lcd_cache_t cache_type;
+
+ struct fdt_gpio_state backlight_en; /* GPIO for backlight enable */
+ struct fdt_gpio_state lvds_shutdown; /* GPIO for lvds shutdown */
+ struct fdt_gpio_state backlight_vdd; /* GPIO for backlight vdd */
+ struct fdt_gpio_state panel_vdd; /* GPIO for panel vdd */
+ /*
+ * Panel required timings
+ * Timing 1: delay between panel_vdd-rise and data-rise
+ * Timing 2: delay between data-rise and backlight_vdd-rise
+ * Timing 3: delay between backlight_vdd and pwm-rise
+ * Timing 4: delay between pwm-rise and backlight_en-rise
+ */
+ uint panel_timings[FDT_LCD_TIMINGS];
+};
+
+/**
+ * Register a new display based on device tree configuration.
+ *
+ * The frame buffer can be positioned by U-Boot or overriden by the fdt.
+ * You should pass in the U-Boot address here, and check the contents of
+ * struct fdt_disp_config to see what was actually chosen.
+ *
+ * @param blob Device tree blob
+ * @param default_lcd_base Default address of LCD frame buffer
+ * @return 0 if ok, -1 on error (unsupported bits per pixel)
+ */
+int tegra_display_probe(const void *blob, void *default_lcd_base);
+
+/**
+ * Return the current display configuration
+ *
+ * @return pointer to display configuration, or NULL if there is no valid
+ * config
+ */
+struct fdt_disp_config *tegra_display_get_config(void);
+
+/**
+ * Perform the next stage of the LCD init if it is time to do so.
+ *
+ * LCD init can be time-consuming because of the number of delays we need
+ * while waiting for the backlight power supply, etc. This function can
+ * be called@various times during U-Boot operation to advance the
+ * initialization of the LCD to the next stage if sufficient time has
+ * passed since the last stage. It keeps track of what stage it is up to
+ * and the time that it is permitted to move to the next stage.
+ *
+ * The final call should have wait=1 to complete the init.
+ *
+ * @param blob fdt blob containing LCD information
+ * @param wait 1 to wait until all init is complete, and then return
+ * 0 to return immediately, potentially doing nothing if it is
+ * not yet time for the next init.
+ */
+int tegra_lcd_check_next_stage(const void *blob, int wait);
+
+/**
+ * Set up the maximum LCD size so we can size the frame buffer.
+ *
+ * @param blob fdt blob containing LCD information
+ */
+void tegra_lcd_early_init(const void *blob);
+
+#endif /*__ASM_ARCH_TEGRA_DISPLAY_H*/
diff --git a/include/fdtdec.h b/include/fdtdec.h
index cdc87eb..64e5cff 100644
--- a/include/fdtdec.h
+++ b/include/fdtdec.h
@@ -67,6 +67,7 @@ enum fdt_compat_id {
COMPAT_NVIDIA_TEGRA20_KBC, /* Tegra20 Keyboard */
COMPAT_NVIDIA_TEGRA20_NAND, /* Tegra2 NAND controller */
COMPAT_NVIDIA_TEGRA20_PWM, /* Tegra 2 PWM controller */
+ COMPAT_NVIDIA_TEGRA20_DC, /* Tegra 2 Display controller */
COMPAT_COUNT,
};
diff --git a/lib/fdtdec.c b/lib/fdtdec.c
index 947f7c0..23e0205 100644
--- a/lib/fdtdec.c
+++ b/lib/fdtdec.c
@@ -44,6 +44,7 @@ static const char * const compat_names[COMPAT_COUNT] = {
COMPAT(NVIDIA_TEGRA20_KBC, "nvidia,tegra20-kbc"),
COMPAT(NVIDIA_TEGRA20_NAND, "nvidia,tegra20-nand"),
COMPAT(NVIDIA_TEGRA20_PWM, "nvidia,tegra20-pwm"),
+ COMPAT(NVIDIA_TEGRA20_DC, "nvidia,tegra20-dc"),
};
const char *fdtdec_get_compatible(enum fdt_compat_id id)
--
1.7.7.3
^ permalink raw reply related [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 07/16] tegra: Add LCD driver
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
` (5 preceding siblings ...)
2012-09-28 0:44 ` [U-Boot] [PATCH v4 06/16] tegra: Add SOC support for display/lcd Simon Glass
@ 2012-09-28 0:44 ` Simon Glass
2012-10-05 14:21 ` Marc Dietrich
2012-09-28 0:44 ` [U-Boot] [PATCH v4 08/16] tegra: Add LCD support to Nvidia boards Simon Glass
` (10 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Simon Glass @ 2012-09-28 0:44 UTC (permalink / raw)
To: u-boot
This driver supports driving a single LCD and providing a U-Boot console
on it.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v2:
- Update LCD driver to deal with new fdt bindings
Changes in v3:
- Move some fdt decode code from LCD driver to SOC display driver
- Rename fdt config structures
- Use new pwm binding from pre-linux-next
- Adjust LCD driver to use new SOC display driver structures
Changes in v4:
- Rebase on top of new tegra common directory structure
- Change LCD panel GPIOs to be entirely optional
- Only indicate that LCD init is complete when all stages complete
drivers/video/Makefile | 1 +
drivers/video/tegra.c | 361 ++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 362 insertions(+), 0 deletions(-)
create mode 100644 drivers/video/tegra.c
diff --git a/drivers/video/Makefile b/drivers/video/Makefile
index ebb6da8..78a7668 100644
--- a/drivers/video/Makefile
+++ b/drivers/video/Makefile
@@ -49,6 +49,7 @@ COBJS-$(CONFIG_VIDEO_OMAP3) += omap3_dss.o
COBJS-$(CONFIG_VIDEO_SED13806) += sed13806.o
COBJS-$(CONFIG_VIDEO_SM501) += sm501.o
COBJS-$(CONFIG_VIDEO_SMI_LYNXEM) += smiLynxEM.o videomodes.o
+COBJS-$(CONFIG_VIDEO_TEGRA) += tegra.o
COBJS-$(CONFIG_VIDEO_VCXK) += bus_vcxk.o
COBJS := $(sort $(COBJS-y))
diff --git a/drivers/video/tegra.c b/drivers/video/tegra.c
new file mode 100644
index 0000000..9df2bd3
--- /dev/null
+++ b/drivers/video/tegra.c
@@ -0,0 +1,361 @@
+/*
+ * Copyright (c) 2011 The Chromium OS Authors.
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <common.h>
+#include <fdtdec.h>
+#include <lcd.h>
+
+#include <asm/system.h>
+#include <asm/gpio.h>
+
+#include <asm/arch/clock.h>
+#include <asm/arch/funcmux.h>
+#include <asm/arch/pinmux.h>
+#include <asm/arch/pwm.h>
+#include <asm/arch/display.h>
+#include <asm/arch-tegra/timer.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+/* These are the stages we go throuh in enabling the LCD */
+enum stage_t {
+ STAGE_START,
+ STAGE_LVDS,
+ STAGE_BACKLIGHT_VDD,
+ STAGE_PWM,
+ STAGE_BACKLIGHT_EN,
+ STAGE_DONE,
+};
+
+static enum stage_t stage; /* Current stage we are at */
+static unsigned long timer_next; /* Time we can move onto next stage */
+
+/* Our LCD config, set up in handle_stage() */
+static struct fdt_panel_config config;
+struct fdt_disp_config *disp_config; /* Display controller config */
+
+enum {
+ /* Maximum LCD size we support */
+ LCD_MAX_WIDTH = 1366,
+ LCD_MAX_HEIGHT = 768,
+ LCD_MAX_LOG2_BPP = 4, /* 2^4 = 16 bpp */
+};
+
+int lcd_line_length;
+int lcd_color_fg;
+int lcd_color_bg;
+
+void *lcd_base; /* Start of framebuffer memory */
+void *lcd_console_address; /* Start of console buffer */
+
+short console_col;
+short console_row;
+
+vidinfo_t panel_info = {
+ /* Insert a value here so that we don't end up in the BSS */
+ .vl_col = -1,
+};
+
+char lcd_cursor_enabled;
+
+ushort lcd_cursor_width;
+ushort lcd_cursor_height;
+
+#ifndef CONFIG_OF_CONTROL
+#error "You must enable CONFIG_OF_CONTROL to get Tegra LCD support"
+#endif
+
+void lcd_cursor_size(ushort width, ushort height)
+{
+ lcd_cursor_width = width;
+ lcd_cursor_height = height;
+}
+
+void lcd_toggle_cursor(void)
+{
+ ushort x, y;
+ uchar *dest;
+ ushort row;
+
+ x = console_col * lcd_cursor_width;
+ y = console_row * lcd_cursor_height;
+ dest = (uchar *)(lcd_base + y * lcd_line_length + x * (1 << LCD_BPP) /
+ 8);
+
+ for (row = 0; row < lcd_cursor_height; ++row, dest += lcd_line_length) {
+ ushort *d = (ushort *)dest;
+ ushort color;
+ int i;
+
+ for (i = 0; i < lcd_cursor_width; ++i) {
+ color = *d;
+ color ^= lcd_color_fg;
+ *d = color;
+ ++d;
+ }
+ }
+}
+
+void lcd_cursor_on(void)
+{
+ lcd_cursor_enabled = 1;
+ lcd_toggle_cursor();
+}
+void lcd_cursor_off(void)
+{
+ lcd_cursor_enabled = 0;
+ lcd_toggle_cursor();
+}
+
+char lcd_is_cursor_enabled(void)
+{
+ return lcd_cursor_enabled;
+}
+
+static void update_panel_size(struct fdt_disp_config *config)
+{
+ panel_info.vl_col = config->width;
+ panel_info.vl_row = config->height;
+ panel_info.vl_bpix = config->log2_bpp;
+}
+
+/*
+ * Main init function called by lcd driver.
+ * Inits and then prints test pattern if required.
+ */
+
+void lcd_ctrl_init(void *lcdbase)
+{
+ int line_length, size;
+
+ assert(disp_config);
+
+ lcd_base = (void *)disp_config->frame_buffer;
+
+ /* Make sure that we can acommodate the selected LCD */
+ assert(disp_config->width <= LCD_MAX_WIDTH);
+ assert(disp_config->height <= LCD_MAX_HEIGHT);
+ assert(disp_config->log2_bpp <= LCD_MAX_LOG2_BPP);
+ if (disp_config->width <= LCD_MAX_WIDTH
+ && disp_config->height <= LCD_MAX_HEIGHT
+ && disp_config->log2_bpp <= LCD_MAX_LOG2_BPP)
+ update_panel_size(disp_config);
+ size = lcd_get_size(&line_length);
+
+ debug("LCD frame buffer@%p\n", lcd_base);
+}
+
+ulong calc_fbsize(void)
+{
+ return (panel_info.vl_col * panel_info.vl_row *
+ NBITS(panel_info.vl_bpix)) / 8;
+}
+
+void lcd_setcolreg(ushort regno, ushort red, ushort green, ushort blue)
+{
+}
+
+void tegra_lcd_early_init(const void *blob)
+{
+ /*
+ * Go with the maximum size for now. We will fix this up after
+ * relocation. These values are only used for memory alocation.
+ */
+ panel_info.vl_col = LCD_MAX_WIDTH;
+ panel_info.vl_row = LCD_MAX_HEIGHT;
+ panel_info.vl_bpix = LCD_MAX_LOG2_BPP;
+}
+
+/**
+ * Decode the panel information from the fdt.
+ *
+ * @param blob fdt blob
+ * @param config structure to store fdt config into
+ * @return 0 if ok, -ve on error
+ */
+static int fdt_decode_lcd(const void *blob, struct fdt_panel_config *config)
+{
+ int display_node;
+
+ disp_config = tegra_display_get_config();
+ if (!disp_config) {
+ debug("%s: Display controller is not configured\n", __func__);
+ return -1;
+ }
+ display_node = disp_config->panel_node;
+ if (display_node < 0) {
+ debug("%s: No panel configuration available\n", __func__);
+ return -1;
+ }
+
+ config->pwm_channel = pwm_request(blob, display_node, "nvidia,pwm");
+ if (config->pwm_channel < 0) {
+ debug("%s: Unable to request PWM channel\n", __func__);
+ return -1;
+ }
+
+ config->cache_type = fdtdec_get_int(blob, display_node,
+ "nvidia,cache-type",
+ FDT_LCD_CACHE_WRITE_BACK_FLUSH);
+
+ /* These GPIOs are all optional */
+ fdtdec_decode_gpio(blob, display_node, "nvidia,backlight-enable-gpios",
+ &config->backlight_en);
+ fdtdec_decode_gpio(blob, display_node, "nvidia,lvds-shutdown-gpios",
+ &config->lvds_shutdown);
+ fdtdec_decode_gpio(blob, display_node, "nvidia,backlight-vdd-gpios",
+ &config->backlight_vdd);
+ fdtdec_decode_gpio(blob, display_node, "nvidia,panel-vdd-gpios",
+ &config->panel_vdd);
+
+ return fdtdec_get_int_array(blob, display_node, "nvidia,panel-timings",
+ config->panel_timings, FDT_LCD_TIMINGS);
+}
+
+/**
+ * Handle the next stage of device init
+ */
+static int handle_stage(const void *blob)
+{
+ debug("%s: stage %d\n", __func__, stage);
+
+ /* do the things for this stage */
+ switch (stage) {
+ case STAGE_START:
+ /* Initialize the Tegra display controller */
+ if (tegra_display_probe(gd->fdt_blob, lcd_base)) {
+ printf("%s: Failed to probe display driver\n",
+ __func__);
+ return -1;
+ }
+
+ /* get panel details */
+ if (fdt_decode_lcd(blob, &config)) {
+ printf("No valid LCD information in device tree\n");
+ return -1;
+ }
+
+ /*
+ * It is possible that the FDT has requested that the LCD be
+ * disabled. We currently don't support this. It would require
+ * changes to U-Boot LCD subsystem to have LCD support
+ * compiled in but not used. An easier option might be to
+ * still have a frame buffer, but leave the backlight off and
+ * remove all mention of lcd in the stdout environment
+ * variable.
+ */
+
+ funcmux_select(PERIPH_ID_DISP1, FUNCMUX_DEFAULT);
+
+ fdtdec_setup_gpio(&config.panel_vdd);
+ fdtdec_setup_gpio(&config.lvds_shutdown);
+ fdtdec_setup_gpio(&config.backlight_vdd);
+ fdtdec_setup_gpio(&config.backlight_en);
+
+ /*
+ * TODO: If fdt includes output flag we can omit this code
+ * since fdtdec_setup_gpio will do it for us.
+ */
+ if (fdt_gpio_isvalid(&config.panel_vdd))
+ gpio_direction_output(config.panel_vdd.gpio, 1);
+ if (fdt_gpio_isvalid(&config.lvds_shutdown))
+ gpio_direction_output(config.lvds_shutdown.gpio, 0);
+ if (fdt_gpio_isvalid(&config.backlight_vdd))
+ gpio_direction_output(config.backlight_vdd.gpio, 0);
+ if (fdt_gpio_isvalid(&config.backlight_en))
+ gpio_direction_output(config.backlight_en.gpio, 0);
+ break;
+ case STAGE_LVDS:
+ if (fdt_gpio_isvalid(&config.lvds_shutdown))
+ gpio_set_value(config.lvds_shutdown.gpio, 1);
+ break;
+ case STAGE_BACKLIGHT_VDD:
+ if (fdt_gpio_isvalid(&config.backlight_vdd))
+ gpio_set_value(config.backlight_vdd.gpio, 1);
+ break;
+ case STAGE_PWM:
+ /* Enable PWM at 15/16 high, 32768 Hz with divider 1 */
+ pinmux_set_func(PINGRP_GPU, PMUX_FUNC_PWM);
+ pinmux_tristate_disable(PINGRP_GPU);
+
+ pwm_enable(config.pwm_channel, 32768, 0xdf, 1);
+ break;
+ case STAGE_BACKLIGHT_EN:
+ if (fdt_gpio_isvalid(&config.backlight_en))
+ gpio_set_value(config.backlight_en.gpio, 1);
+ break;
+ case STAGE_DONE:
+ break;
+ }
+
+ /* set up timer for next stage */
+ timer_next = timer_get_us() + config.panel_timings[stage] * 1000;
+
+ /* move to next stage */
+ stage++;
+ return 0;
+}
+
+int tegra_lcd_check_next_stage(const void *blob, int wait)
+{
+ if (stage == STAGE_DONE)
+ return 0;
+
+ do {
+ /* wait if we need to */
+ debug("%s: stage %d\n", __func__, stage);
+ if (stage != STAGE_START) {
+ int delay = timer_next - timer_get_us();
+
+ if (delay > 0) {
+ if (wait)
+ udelay(delay);
+ else
+ return 0;
+ }
+ }
+
+ if (handle_stage(blob))
+ return -1;
+ } while (wait && stage != STAGE_DONE);
+ if (stage == STAGE_DONE)
+ debug("%s: LCD init complete\n", __func__);
+
+ return 0;
+}
+
+void lcd_enable(void)
+{
+ /*
+ * Backlight and power init will be done separately in
+ * tegra_lcd_check_next_stage(), which should be called in
+ * board_late_init().
+ *
+ * U-Boot code supports only colour depth, selected at compile time.
+ * The device tree setting should match this. Otherwise the display
+ * will not look right, and U-Boot may crash.
+ */
+ if (disp_config->log2_bpp != LCD_BPP) {
+ printf("%s: Error: LCD depth configured in FDT (%d = %dbpp)"
+ " must match setting of LCD_BPP (%d)\n", __func__,
+ disp_config->log2_bpp, disp_config->bpp, LCD_BPP);
+ }
+}
--
1.7.7.3
^ permalink raw reply related [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 07/16] tegra: Add LCD driver
2012-09-28 0:44 ` [U-Boot] [PATCH v4 07/16] tegra: Add LCD driver Simon Glass
@ 2012-10-05 14:21 ` Marc Dietrich
2012-10-08 22:02 ` Simon Glass
0 siblings, 1 reply; 40+ messages in thread
From: Marc Dietrich @ 2012-10-05 14:21 UTC (permalink / raw)
To: u-boot
Simon,
I tried to adapt this for paz00. I only get backlight and an all white screen.
On checking what's wrong I stumpled about something strange below...
Marc
On Thursday 27 September 2012 17:44:28 Simon Glass wrote:
> This driver supports driving a single LCD and providing a U-Boot console
> on it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> Changes in v2:
> - Update LCD driver to deal with new fdt bindings
>
> Changes in v3:
> - Move some fdt decode code from LCD driver to SOC display driver
> - Rename fdt config structures
> - Use new pwm binding from pre-linux-next
> - Adjust LCD driver to use new SOC display driver structures
>
> Changes in v4:
> - Rebase on top of new tegra common directory structure
> - Change LCD panel GPIOs to be entirely optional
> - Only indicate that LCD init is complete when all stages complete
>
> drivers/video/Makefile | 1 +
> drivers/video/tegra.c | 361
> ++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 362
> insertions(+), 0 deletions(-)
> create mode 100644 drivers/video/tegra.c
>
> diff --git a/drivers/video/Makefile b/drivers/video/Makefile
> index ebb6da8..78a7668 100644
> --- a/drivers/video/Makefile
> +++ b/drivers/video/Makefile
> @@ -49,6 +49,7 @@ COBJS-$(CONFIG_VIDEO_OMAP3) += omap3_dss.o
> COBJS-$(CONFIG_VIDEO_SED13806) += sed13806.o
> COBJS-$(CONFIG_VIDEO_SM501) += sm501.o
> COBJS-$(CONFIG_VIDEO_SMI_LYNXEM) += smiLynxEM.o videomodes.o
> +COBJS-$(CONFIG_VIDEO_TEGRA) += tegra.o
> COBJS-$(CONFIG_VIDEO_VCXK) += bus_vcxk.o
>
> COBJS := $(sort $(COBJS-y))
> diff --git a/drivers/video/tegra.c b/drivers/video/tegra.c
> new file mode 100644
> index 0000000..9df2bd3
> --- /dev/null
> +++ b/drivers/video/tegra.c
> @@ -0,0 +1,361 @@
> +/*
> + * Copyright (c) 2011 The Chromium OS Authors.
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <common.h>
> +#include <fdtdec.h>
> +#include <lcd.h>
> +
> +#include <asm/system.h>
> +#include <asm/gpio.h>
> +
> +#include <asm/arch/clock.h>
> +#include <asm/arch/funcmux.h>
> +#include <asm/arch/pinmux.h>
> +#include <asm/arch/pwm.h>
> +#include <asm/arch/display.h>
> +#include <asm/arch-tegra/timer.h>
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +/* These are the stages we go throuh in enabling the LCD */
> +enum stage_t {
> + STAGE_START,
> + STAGE_LVDS,
> + STAGE_BACKLIGHT_VDD,
> + STAGE_PWM,
> + STAGE_BACKLIGHT_EN,
> + STAGE_DONE,
> +};
> +
> +static enum stage_t stage; /* Current stage we are at */
> +static unsigned long timer_next; /* Time we can move onto next stage */
> +
> +/* Our LCD config, set up in handle_stage() */
> +static struct fdt_panel_config config;
> +struct fdt_disp_config *disp_config; /* Display controller config */
> +
> +enum {
> + /* Maximum LCD size we support */
> + LCD_MAX_WIDTH = 1366,
> + LCD_MAX_HEIGHT = 768,
> + LCD_MAX_LOG2_BPP = 4, /* 2^4 = 16 bpp */
> +};
> +
> +int lcd_line_length;
> +int lcd_color_fg;
> +int lcd_color_bg;
> +
> +void *lcd_base; /* Start of framebuffer memory */
> +void *lcd_console_address; /* Start of console buffer */
> +
> +short console_col;
> +short console_row;
> +
> +vidinfo_t panel_info = {
> + /* Insert a value here so that we don't end up in the BSS */
> + .vl_col = -1,
> +};
> +
> +char lcd_cursor_enabled;
> +
> +ushort lcd_cursor_width;
> +ushort lcd_cursor_height;
> +
> +#ifndef CONFIG_OF_CONTROL
> +#error "You must enable CONFIG_OF_CONTROL to get Tegra LCD support"
> +#endif
> +
> +void lcd_cursor_size(ushort width, ushort height)
> +{
> + lcd_cursor_width = width;
> + lcd_cursor_height = height;
> +}
> +
> +void lcd_toggle_cursor(void)
> +{
> + ushort x, y;
> + uchar *dest;
> + ushort row;
> +
> + x = console_col * lcd_cursor_width;
> + y = console_row * lcd_cursor_height;
> + dest = (uchar *)(lcd_base + y * lcd_line_length + x * (1 << LCD_BPP) /
> + 8);
> +
> + for (row = 0; row < lcd_cursor_height; ++row, dest += lcd_line_length) {
> + ushort *d = (ushort *)dest;
> + ushort color;
> + int i;
> +
> + for (i = 0; i < lcd_cursor_width; ++i) {
> + color = *d;
> + color ^= lcd_color_fg;
> + *d = color;
> + ++d;
> + }
> + }
> +}
> +
> +void lcd_cursor_on(void)
> +{
> + lcd_cursor_enabled = 1;
> + lcd_toggle_cursor();
> +}
> +void lcd_cursor_off(void)
> +{
> + lcd_cursor_enabled = 0;
> + lcd_toggle_cursor();
> +}
> +
> +char lcd_is_cursor_enabled(void)
> +{
> + return lcd_cursor_enabled;
> +}
> +
> +static void update_panel_size(struct fdt_disp_config *config)
> +{
> + panel_info.vl_col = config->width;
> + panel_info.vl_row = config->height;
> + panel_info.vl_bpix = config->log2_bpp;
> +}
> +
> +/*
> + * Main init function called by lcd driver.
> + * Inits and then prints test pattern if required.
> + */
> +
> +void lcd_ctrl_init(void *lcdbase)
> +{
> + int line_length, size;
> +
> + assert(disp_config);
> +
> + lcd_base = (void *)disp_config->frame_buffer;
this is always NULL, because it is defined in a circular manner (see
arch/arm/cpu/armv7/tegra20/display.c:383) and ...
> + /* Make sure that we can acommodate the selected LCD */
> + assert(disp_config->width <= LCD_MAX_WIDTH);
> + assert(disp_config->height <= LCD_MAX_HEIGHT);
> + assert(disp_config->log2_bpp <= LCD_MAX_LOG2_BPP);
> + if (disp_config->width <= LCD_MAX_WIDTH
> + && disp_config->height <= LCD_MAX_HEIGHT
> + && disp_config->log2_bpp <= LCD_MAX_LOG2_BPP)
> + update_panel_size(disp_config);
> + size = lcd_get_size(&line_length);
> +
> + debug("LCD frame buffer at %p\n", lcd_base);
> +}
> +
> +ulong calc_fbsize(void)
> +{
> + return (panel_info.vl_col * panel_info.vl_row *
> + NBITS(panel_info.vl_bpix)) / 8;
> +}
> +
> +void lcd_setcolreg(ushort regno, ushort red, ushort green, ushort blue)
> +{
> +}
> +
> +void tegra_lcd_early_init(const void *blob)
> +{
> + /*
> + * Go with the maximum size for now. We will fix this up after
> + * relocation. These values are only used for memory alocation.
> + */
> + panel_info.vl_col = LCD_MAX_WIDTH;
> + panel_info.vl_row = LCD_MAX_HEIGHT;
> + panel_info.vl_bpix = LCD_MAX_LOG2_BPP;
> +}
> +
> +/**
> + * Decode the panel information from the fdt.
> + *
> + * @param blob fdt blob
> + * @param config structure to store fdt config into
> + * @return 0 if ok, -ve on error
> + */
> +static int fdt_decode_lcd(const void *blob, struct fdt_panel_config
> *config) +{
> + int display_node;
> +
> + disp_config = tegra_display_get_config();
> + if (!disp_config) {
> + debug("%s: Display controller is not configured\n", __func__);
> + return -1;
> + }
> + display_node = disp_config->panel_node;
> + if (display_node < 0) {
> + debug("%s: No panel configuration available\n", __func__);
> + return -1;
> + }
> +
> + config->pwm_channel = pwm_request(blob, display_node, "nvidia,pwm");
> + if (config->pwm_channel < 0) {
> + debug("%s: Unable to request PWM channel\n", __func__);
> + return -1;
> + }
> +
> + config->cache_type = fdtdec_get_int(blob, display_node,
> + "nvidia,cache-type",
> + FDT_LCD_CACHE_WRITE_BACK_FLUSH);
> +
> + /* These GPIOs are all optional */
> + fdtdec_decode_gpio(blob, display_node, "nvidia,backlight-enable-gpios",
> + &config->backlight_en);
> + fdtdec_decode_gpio(blob, display_node, "nvidia,lvds-shutdown-gpios",
> + &config->lvds_shutdown);
> + fdtdec_decode_gpio(blob, display_node, "nvidia,backlight-vdd-gpios",
> + &config->backlight_vdd);
> + fdtdec_decode_gpio(blob, display_node, "nvidia,panel-vdd-gpios",
> + &config->panel_vdd);
> +
> + return fdtdec_get_int_array(blob, display_node, "nvidia,panel-timings",
> + config->panel_timings, FDT_LCD_TIMINGS);
> +}
> +
> +/**
> + * Handle the next stage of device init
> + */
> +static int handle_stage(const void *blob)
> +{
> + debug("%s: stage %d\n", __func__, stage);
> +
> + /* do the things for this stage */
> + switch (stage) {
> + case STAGE_START:
> + /* Initialize the Tegra display controller */
> + if (tegra_display_probe(gd->fdt_blob, lcd_base)) {
.... here.
> + printf("%s: Failed to probe display driver\n",
> + __func__);
> + return -1;
> + }
> +
> + /* get panel details */
> + if (fdt_decode_lcd(blob, &config)) {
> + printf("No valid LCD information in device tree\n");
> + return -1;
> + }
> +
> + /*
> + * It is possible that the FDT has requested that the LCD be
> + * disabled. We currently don't support this. It would require
> + * changes to U-Boot LCD subsystem to have LCD support
> + * compiled in but not used. An easier option might be to
> + * still have a frame buffer, but leave the backlight off and
> + * remove all mention of lcd in the stdout environment
> + * variable.
> + */
> +
> + funcmux_select(PERIPH_ID_DISP1, FUNCMUX_DEFAULT);
> +
> + fdtdec_setup_gpio(&config.panel_vdd);
> + fdtdec_setup_gpio(&config.lvds_shutdown);
> + fdtdec_setup_gpio(&config.backlight_vdd);
> + fdtdec_setup_gpio(&config.backlight_en);
> +
> + /*
> + * TODO: If fdt includes output flag we can omit this code
> + * since fdtdec_setup_gpio will do it for us.
> + */
> + if (fdt_gpio_isvalid(&config.panel_vdd))
> + gpio_direction_output(config.panel_vdd.gpio, 1);
> + if (fdt_gpio_isvalid(&config.lvds_shutdown))
> + gpio_direction_output(config.lvds_shutdown.gpio, 0);
> + if (fdt_gpio_isvalid(&config.backlight_vdd))
> + gpio_direction_output(config.backlight_vdd.gpio, 0);
> + if (fdt_gpio_isvalid(&config.backlight_en))
> + gpio_direction_output(config.backlight_en.gpio, 0);
> + break;
> + case STAGE_LVDS:
> + if (fdt_gpio_isvalid(&config.lvds_shutdown))
> + gpio_set_value(config.lvds_shutdown.gpio, 1);
> + break;
> + case STAGE_BACKLIGHT_VDD:
> + if (fdt_gpio_isvalid(&config.backlight_vdd))
> + gpio_set_value(config.backlight_vdd.gpio, 1);
> + break;
> + case STAGE_PWM:
> + /* Enable PWM at 15/16 high, 32768 Hz with divider 1 */
> + pinmux_set_func(PINGRP_GPU, PMUX_FUNC_PWM);
> + pinmux_tristate_disable(PINGRP_GPU);
> +
> + pwm_enable(config.pwm_channel, 32768, 0xdf, 1);
> + break;
> + case STAGE_BACKLIGHT_EN:
> + if (fdt_gpio_isvalid(&config.backlight_en))
> + gpio_set_value(config.backlight_en.gpio, 1);
> + break;
> + case STAGE_DONE:
> + break;
> + }
> +
> + /* set up timer for next stage */
> + timer_next = timer_get_us() + config.panel_timings[stage] * 1000;
> +
> + /* move to next stage */
> + stage++;
> + return 0;
> +}
> +
> +int tegra_lcd_check_next_stage(const void *blob, int wait)
> +{
> + if (stage == STAGE_DONE)
> + return 0;
> +
> + do {
> + /* wait if we need to */
> + debug("%s: stage %d\n", __func__, stage);
> + if (stage != STAGE_START) {
> + int delay = timer_next - timer_get_us();
> +
> + if (delay > 0) {
> + if (wait)
> + udelay(delay);
> + else
> + return 0;
> + }
> + }
> +
> + if (handle_stage(blob))
> + return -1;
> + } while (wait && stage != STAGE_DONE);
> + if (stage == STAGE_DONE)
> + debug("%s: LCD init complete\n", __func__);
> +
> + return 0;
> +}
> +
> +void lcd_enable(void)
> +{
> + /*
> + * Backlight and power init will be done separately in
> + * tegra_lcd_check_next_stage(), which should be called in
> + * board_late_init().
> + *
> + * U-Boot code supports only colour depth, selected at compile time.
> + * The device tree setting should match this. Otherwise the display
> + * will not look right, and U-Boot may crash.
> + */
> + if (disp_config->log2_bpp != LCD_BPP) {
> + printf("%s: Error: LCD depth configured in FDT (%d = %dbpp)"
> + " must match setting of LCD_BPP (%d)\n", __func__,
> + disp_config->log2_bpp, disp_config->bpp, LCD_BPP);
> + }
> +}
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 07/16] tegra: Add LCD driver
2012-10-05 14:21 ` Marc Dietrich
@ 2012-10-08 22:02 ` Simon Glass
2012-10-08 22:12 ` Stephen Warren
0 siblings, 1 reply; 40+ messages in thread
From: Simon Glass @ 2012-10-08 22:02 UTC (permalink / raw)
To: u-boot
Hi Marc,
On Fri, Oct 5, 2012 at 7:21 AM, Marc Dietrich <marvin24@gmx.de> wrote:
> Simon,
>
> I tried to adapt this for paz00. I only get backlight and an all white screen.
I'm not sure about that. One possibility is that your PWM is connected
up differently. On Seaboard at least, I found that without the PWM I
would get nothing on the display.
> On checking what's wrong I stumpled about something strange below...
>
> Marc
>
> On Thursday 27 September 2012 17:44:28 Simon Glass wrote:
>> This driver supports driving a single LCD and providing a U-Boot console
>> on it.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> ---
>> Changes in v2:
>> - Update LCD driver to deal with new fdt bindings
>>
>> Changes in v3:
>> - Move some fdt decode code from LCD driver to SOC display driver
>> - Rename fdt config structures
>> - Use new pwm binding from pre-linux-next
>> - Adjust LCD driver to use new SOC display driver structures
>>
>> Changes in v4:
>> - Rebase on top of new tegra common directory structure
>> - Change LCD panel GPIOs to be entirely optional
>> - Only indicate that LCD init is complete when all stages complete
>>
>> drivers/video/Makefile | 1 +
>> drivers/video/tegra.c | 361
>> ++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 362
>> insertions(+), 0 deletions(-)
>> create mode 100644 drivers/video/tegra.c
>>
>> diff --git a/drivers/video/Makefile b/drivers/video/Makefile
>> index ebb6da8..78a7668 100644
>> --- a/drivers/video/Makefile
>> +++ b/drivers/video/Makefile
>> @@ -49,6 +49,7 @@ COBJS-$(CONFIG_VIDEO_OMAP3) += omap3_dss.o
>> COBJS-$(CONFIG_VIDEO_SED13806) += sed13806.o
>> COBJS-$(CONFIG_VIDEO_SM501) += sm501.o
>> COBJS-$(CONFIG_VIDEO_SMI_LYNXEM) += smiLynxEM.o videomodes.o
>> +COBJS-$(CONFIG_VIDEO_TEGRA) += tegra.o
>> COBJS-$(CONFIG_VIDEO_VCXK) += bus_vcxk.o
>>
>> COBJS := $(sort $(COBJS-y))
>> diff --git a/drivers/video/tegra.c b/drivers/video/tegra.c
>> new file mode 100644
>> index 0000000..9df2bd3
>> --- /dev/null
>> +++ b/drivers/video/tegra.c
>> @@ -0,0 +1,361 @@
>> +/*
>> + * Copyright (c) 2011 The Chromium OS Authors.
>> + * See file CREDITS for list of people who contributed to this
>> + * project.
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of
>> + * the License, or (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; if not, write to the Free Software
>> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>> + * MA 02111-1307 USA
>> + */
>> +
>> +#include <common.h>
>> +#include <fdtdec.h>
>> +#include <lcd.h>
>> +
>> +#include <asm/system.h>
>> +#include <asm/gpio.h>
>> +
>> +#include <asm/arch/clock.h>
>> +#include <asm/arch/funcmux.h>
>> +#include <asm/arch/pinmux.h>
>> +#include <asm/arch/pwm.h>
>> +#include <asm/arch/display.h>
>> +#include <asm/arch-tegra/timer.h>
>> +
>> +DECLARE_GLOBAL_DATA_PTR;
>> +
>> +/* These are the stages we go throuh in enabling the LCD */
>> +enum stage_t {
>> + STAGE_START,
>> + STAGE_LVDS,
>> + STAGE_BACKLIGHT_VDD,
>> + STAGE_PWM,
>> + STAGE_BACKLIGHT_EN,
>> + STAGE_DONE,
>> +};
>> +
>> +static enum stage_t stage; /* Current stage we are at */
>> +static unsigned long timer_next; /* Time we can move onto next stage */
>> +
>> +/* Our LCD config, set up in handle_stage() */
>> +static struct fdt_panel_config config;
>> +struct fdt_disp_config *disp_config; /* Display controller config */
>> +
>> +enum {
>> + /* Maximum LCD size we support */
>> + LCD_MAX_WIDTH = 1366,
>> + LCD_MAX_HEIGHT = 768,
>> + LCD_MAX_LOG2_BPP = 4, /* 2^4 = 16 bpp */
>> +};
>> +
>> +int lcd_line_length;
>> +int lcd_color_fg;
>> +int lcd_color_bg;
>> +
>> +void *lcd_base; /* Start of framebuffer memory */
>> +void *lcd_console_address; /* Start of console buffer */
>> +
>> +short console_col;
>> +short console_row;
>> +
>> +vidinfo_t panel_info = {
>> + /* Insert a value here so that we don't end up in the BSS */
>> + .vl_col = -1,
>> +};
>> +
>> +char lcd_cursor_enabled;
>> +
>> +ushort lcd_cursor_width;
>> +ushort lcd_cursor_height;
>> +
>> +#ifndef CONFIG_OF_CONTROL
>> +#error "You must enable CONFIG_OF_CONTROL to get Tegra LCD support"
>> +#endif
>> +
>> +void lcd_cursor_size(ushort width, ushort height)
>> +{
>> + lcd_cursor_width = width;
>> + lcd_cursor_height = height;
>> +}
>> +
>> +void lcd_toggle_cursor(void)
>> +{
>> + ushort x, y;
>> + uchar *dest;
>> + ushort row;
>> +
>> + x = console_col * lcd_cursor_width;
>> + y = console_row * lcd_cursor_height;
>> + dest = (uchar *)(lcd_base + y * lcd_line_length + x * (1 << LCD_BPP) /
>> + 8);
>> +
>> + for (row = 0; row < lcd_cursor_height; ++row, dest += lcd_line_length) {
>> + ushort *d = (ushort *)dest;
>> + ushort color;
>> + int i;
>> +
>> + for (i = 0; i < lcd_cursor_width; ++i) {
>> + color = *d;
>> + color ^= lcd_color_fg;
>> + *d = color;
>> + ++d;
>> + }
>> + }
>> +}
>> +
>> +void lcd_cursor_on(void)
>> +{
>> + lcd_cursor_enabled = 1;
>> + lcd_toggle_cursor();
>> +}
>> +void lcd_cursor_off(void)
>> +{
>> + lcd_cursor_enabled = 0;
>> + lcd_toggle_cursor();
>> +}
>> +
>> +char lcd_is_cursor_enabled(void)
>> +{
>> + return lcd_cursor_enabled;
>> +}
>> +
>> +static void update_panel_size(struct fdt_disp_config *config)
>> +{
>> + panel_info.vl_col = config->width;
>> + panel_info.vl_row = config->height;
>> + panel_info.vl_bpix = config->log2_bpp;
>> +}
>> +
>> +/*
>> + * Main init function called by lcd driver.
>> + * Inits and then prints test pattern if required.
>> + */
>> +
>> +void lcd_ctrl_init(void *lcdbase)
>> +{
>> + int line_length, size;
>> +
>> + assert(disp_config);
>> +
>> + lcd_base = (void *)disp_config->frame_buffer;
>
> this is always NULL, because it is defined in a circular manner (see
> arch/arm/cpu/armv7/tegra20/display.c:383) and ...
>
>> + /* Make sure that we can acommodate the selected LCD */
>> + assert(disp_config->width <= LCD_MAX_WIDTH);
>> + assert(disp_config->height <= LCD_MAX_HEIGHT);
>> + assert(disp_config->log2_bpp <= LCD_MAX_LOG2_BPP);
>> + if (disp_config->width <= LCD_MAX_WIDTH
>> + && disp_config->height <= LCD_MAX_HEIGHT
>> + && disp_config->log2_bpp <= LCD_MAX_LOG2_BPP)
>> + update_panel_size(disp_config);
>> + size = lcd_get_size(&line_length);
>> +
>> + debug("LCD frame buffer at %p\n", lcd_base);
>> +}
>> +
>> +ulong calc_fbsize(void)
>> +{
>> + return (panel_info.vl_col * panel_info.vl_row *
>> + NBITS(panel_info.vl_bpix)) / 8;
>> +}
>> +
>> +void lcd_setcolreg(ushort regno, ushort red, ushort green, ushort blue)
>> +{
>> +}
>> +
>> +void tegra_lcd_early_init(const void *blob)
>> +{
>> + /*
>> + * Go with the maximum size for now. We will fix this up after
>> + * relocation. These values are only used for memory alocation.
>> + */
>> + panel_info.vl_col = LCD_MAX_WIDTH;
>> + panel_info.vl_row = LCD_MAX_HEIGHT;
>> + panel_info.vl_bpix = LCD_MAX_LOG2_BPP;
>> +}
>> +
>> +/**
>> + * Decode the panel information from the fdt.
>> + *
>> + * @param blob fdt blob
>> + * @param config structure to store fdt config into
>> + * @return 0 if ok, -ve on error
>> + */
>> +static int fdt_decode_lcd(const void *blob, struct fdt_panel_config
>> *config) +{
>> + int display_node;
>> +
>> + disp_config = tegra_display_get_config();
>> + if (!disp_config) {
>> + debug("%s: Display controller is not configured\n", __func__);
>> + return -1;
>> + }
>> + display_node = disp_config->panel_node;
>> + if (display_node < 0) {
>> + debug("%s: No panel configuration available\n", __func__);
>> + return -1;
>> + }
>> +
>> + config->pwm_channel = pwm_request(blob, display_node, "nvidia,pwm");
>> + if (config->pwm_channel < 0) {
>> + debug("%s: Unable to request PWM channel\n", __func__);
>> + return -1;
>> + }
>> +
>> + config->cache_type = fdtdec_get_int(blob, display_node,
>> + "nvidia,cache-type",
>> + FDT_LCD_CACHE_WRITE_BACK_FLUSH);
>> +
>> + /* These GPIOs are all optional */
>> + fdtdec_decode_gpio(blob, display_node, "nvidia,backlight-enable-gpios",
>> + &config->backlight_en);
>> + fdtdec_decode_gpio(blob, display_node, "nvidia,lvds-shutdown-gpios",
>> + &config->lvds_shutdown);
>> + fdtdec_decode_gpio(blob, display_node, "nvidia,backlight-vdd-gpios",
>> + &config->backlight_vdd);
>> + fdtdec_decode_gpio(blob, display_node, "nvidia,panel-vdd-gpios",
>> + &config->panel_vdd);
>> +
>> + return fdtdec_get_int_array(blob, display_node, "nvidia,panel-timings",
>> + config->panel_timings, FDT_LCD_TIMINGS);
>> +}
>> +
>> +/**
>> + * Handle the next stage of device init
>> + */
>> +static int handle_stage(const void *blob)
>> +{
>> + debug("%s: stage %d\n", __func__, stage);
>> +
>> + /* do the things for this stage */
>> + switch (stage) {
>> + case STAGE_START:
>> + /* Initialize the Tegra display controller */
>> + if (tegra_display_probe(gd->fdt_blob, lcd_base)) {
>
> .... here.
Yes, that should be gd->fb_base I think. I will update it.
>
>> + printf("%s: Failed to probe display driver\n",
>> + __func__);
>> + return -1;
>> + }
>> +
>> + /* get panel details */
>> + if (fdt_decode_lcd(blob, &config)) {
>> + printf("No valid LCD information in device tree\n");
>> + return -1;
>> + }
>> +
>> + /*
>> + * It is possible that the FDT has requested that the LCD be
>> + * disabled. We currently don't support this. It would require
>> + * changes to U-Boot LCD subsystem to have LCD support
>> + * compiled in but not used. An easier option might be to
>> + * still have a frame buffer, but leave the backlight off and
>> + * remove all mention of lcd in the stdout environment
>> + * variable.
>> + */
>> +
>> + funcmux_select(PERIPH_ID_DISP1, FUNCMUX_DEFAULT);
>> +
>> + fdtdec_setup_gpio(&config.panel_vdd);
>> + fdtdec_setup_gpio(&config.lvds_shutdown);
>> + fdtdec_setup_gpio(&config.backlight_vdd);
>> + fdtdec_setup_gpio(&config.backlight_en);
>> +
>> + /*
>> + * TODO: If fdt includes output flag we can omit this code
>> + * since fdtdec_setup_gpio will do it for us.
>> + */
>> + if (fdt_gpio_isvalid(&config.panel_vdd))
>> + gpio_direction_output(config.panel_vdd.gpio, 1);
>> + if (fdt_gpio_isvalid(&config.lvds_shutdown))
>> + gpio_direction_output(config.lvds_shutdown.gpio, 0);
>> + if (fdt_gpio_isvalid(&config.backlight_vdd))
>> + gpio_direction_output(config.backlight_vdd.gpio, 0);
>> + if (fdt_gpio_isvalid(&config.backlight_en))
>> + gpio_direction_output(config.backlight_en.gpio, 0);
>> + break;
>> + case STAGE_LVDS:
>> + if (fdt_gpio_isvalid(&config.lvds_shutdown))
>> + gpio_set_value(config.lvds_shutdown.gpio, 1);
>> + break;
>> + case STAGE_BACKLIGHT_VDD:
>> + if (fdt_gpio_isvalid(&config.backlight_vdd))
>> + gpio_set_value(config.backlight_vdd.gpio, 1);
>> + break;
>> + case STAGE_PWM:
>> + /* Enable PWM at 15/16 high, 32768 Hz with divider 1 */
>> + pinmux_set_func(PINGRP_GPU, PMUX_FUNC_PWM);
>> + pinmux_tristate_disable(PINGRP_GPU);
>> +
>> + pwm_enable(config.pwm_channel, 32768, 0xdf, 1);
>> + break;
>> + case STAGE_BACKLIGHT_EN:
>> + if (fdt_gpio_isvalid(&config.backlight_en))
>> + gpio_set_value(config.backlight_en.gpio, 1);
>> + break;
>> + case STAGE_DONE:
>> + break;
>> + }
>> +
>> + /* set up timer for next stage */
>> + timer_next = timer_get_us() + config.panel_timings[stage] * 1000;
>> +
>> + /* move to next stage */
>> + stage++;
>> + return 0;
>> +}
>> +
>> +int tegra_lcd_check_next_stage(const void *blob, int wait)
>> +{
>> + if (stage == STAGE_DONE)
>> + return 0;
>> +
>> + do {
>> + /* wait if we need to */
>> + debug("%s: stage %d\n", __func__, stage);
>> + if (stage != STAGE_START) {
>> + int delay = timer_next - timer_get_us();
>> +
>> + if (delay > 0) {
>> + if (wait)
>> + udelay(delay);
>> + else
>> + return 0;
>> + }
>> + }
>> +
>> + if (handle_stage(blob))
>> + return -1;
>> + } while (wait && stage != STAGE_DONE);
>> + if (stage == STAGE_DONE)
>> + debug("%s: LCD init complete\n", __func__);
>> +
>> + return 0;
>> +}
>> +
>> +void lcd_enable(void)
>> +{
>> + /*
>> + * Backlight and power init will be done separately in
>> + * tegra_lcd_check_next_stage(), which should be called in
>> + * board_late_init().
>> + *
>> + * U-Boot code supports only colour depth, selected at compile time.
>> + * The device tree setting should match this. Otherwise the display
>> + * will not look right, and U-Boot may crash.
>> + */
>> + if (disp_config->log2_bpp != LCD_BPP) {
>> + printf("%s: Error: LCD depth configured in FDT (%d = %dbpp)"
>> + " must match setting of LCD_BPP (%d)\n", __func__,
>> + disp_config->log2_bpp, disp_config->bpp, LCD_BPP);
>> + }
>> +}
Regards,
Simon
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 07/16] tegra: Add LCD driver
2012-10-08 22:02 ` Simon Glass
@ 2012-10-08 22:12 ` Stephen Warren
0 siblings, 0 replies; 40+ messages in thread
From: Stephen Warren @ 2012-10-08 22:12 UTC (permalink / raw)
To: u-boot
On 10/08/2012 04:02 PM, Simon Glass wrote:
> Hi Marc,
>
> On Fri, Oct 5, 2012 at 7:21 AM, Marc Dietrich <marvin24@gmx.de> wrote:
>> Simon,
>>
>> I tried to adapt this for paz00. I only get backlight and an all white screen.
>
> I'm not sure about that. One possibility is that your PWM is connected
> up differently. On Seaboard at least, I found that without the PWM I
> would get nothing on the display.
BTW, while fiddling around trying to find the
corrupted-display-after-reboot problem on Seaboard, I turned off/on
random display-related things. IIRC, when the panel VDD was off, but the
backlight was on, the display was all-white. Now, there are probably a
ton of other reasons that might happen, but that one would be simple to
verify with a few "gpio set" or "gpio clear" commands on your system...
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot] [PATCH v4 08/16] tegra: Add LCD support to Nvidia boards
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
` (6 preceding siblings ...)
2012-09-28 0:44 ` [U-Boot] [PATCH v4 07/16] tegra: Add LCD driver Simon Glass
@ 2012-09-28 0:44 ` Simon Glass
2012-09-28 0:44 ` [U-Boot] [PATCH v4 09/16] arm: Add control over cachability of memory regions Simon Glass
` (9 subsequent siblings)
17 siblings, 0 replies; 40+ messages in thread
From: Simon Glass @ 2012-09-28 0:44 UTC (permalink / raw)
To: u-boot
Add calls to the LCD driver from Nvidia board code.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v3:
- Add separate call to pwm_init() in board_init()
Changes in v4:
- Change order of LCD init so that PWM comes first
board/nvidia/common/board.c | 21 ++++++++++++++++++++-
1 files changed, 20 insertions(+), 1 deletions(-)
diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c
index 7a7d55c..17aafb6 100644
--- a/board/nvidia/common/board.c
+++ b/board/nvidia/common/board.c
@@ -26,6 +26,7 @@
#include <linux/compiler.h>
#include <asm/io.h>
#include <asm/arch/clock.h>
+#include <asm/arch/display.h>
#include <asm/arch/emc.h>
#include <asm/arch/pinmux.h>
#include <asm/arch/pmu.h>
@@ -110,6 +111,9 @@ int board_init(void)
if (pwm_init(gd->fdt_blob))
debug("%s: Failed to init pwm\n", __func__);
#endif
+#ifdef CONFIG_LCD
+ tegra_lcd_check_next_stage(gd->fdt_blob, 0);
+#endif
/* boot param addr */
gd->bd->bi_boot_params = (NV_PA_SDRAM_BASE + 0x100);
@@ -135,6 +139,9 @@ int board_init(void)
pin_mux_usb();
board_usb_init(gd->fdt_blob);
#endif
+#ifdef CONFIG_LCD
+ tegra_lcd_check_next_stage(gd->fdt_blob, 0);
+#endif
#ifdef CONFIG_TEGRA_LP0
/* save Sdram params to PMC 2, 4, and 24 for WB0 */
@@ -165,6 +172,18 @@ int board_early_init_f(void)
#else
gpio_config_uart();
#endif
- return 0;
+#ifdef CONFIG_LCD
+ tegra_lcd_early_init(gd->fdt_blob);
+#endif
+return 0;
}
#endif /* EARLY_INIT */
+
+int board_late_init(void)
+{
+#ifdef CONFIG_LCD
+ /* Make sure we finish initing the LCD */
+ tegra_lcd_check_next_stage(gd->fdt_blob, 1);
+#endif
+ return 0;
+}
--
1.7.7.3
^ permalink raw reply related [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 09/16] arm: Add control over cachability of memory regions
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
` (7 preceding siblings ...)
2012-09-28 0:44 ` [U-Boot] [PATCH v4 08/16] tegra: Add LCD support to Nvidia boards Simon Glass
@ 2012-09-28 0:44 ` Simon Glass
2012-09-28 0:44 ` [U-Boot] [PATCH v4 10/16] lcd: Add CONFIG_LCD_ALIGNMENT to select frame buffer alignment Simon Glass
` (8 subsequent siblings)
17 siblings, 0 replies; 40+ messages in thread
From: Simon Glass @ 2012-09-28 0:44 UTC (permalink / raw)
To: u-boot
Add support for adjusting the cachability of an L1 section by updating
the MMU. The mmu_set_region_dcache() function allows drivers to make
these changes after the MMU is set up.
It is implemented only for ARMv7 at present.
This is needed for LCD support, where we want to make the LCD frame buffer
write-through (or off) rather than write-back.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v4:
- Use system bit values for enum dcache_option instead of arbitrary numbers
arch/arm/cpu/armv7/cache_v7.c | 11 +++++++++
arch/arm/include/asm/system.h | 30 ++++++++++++++++++++++++
arch/arm/lib/cache-cp15.c | 50 ++++++++++++++++++++++++++++++++---------
3 files changed, 80 insertions(+), 11 deletions(-)
diff --git a/arch/arm/cpu/armv7/cache_v7.c b/arch/arm/cpu/armv7/cache_v7.c
index 1b4e808..5f6d039 100644
--- a/arch/arm/cpu/armv7/cache_v7.c
+++ b/arch/arm/cpu/armv7/cache_v7.c
@@ -297,6 +297,12 @@ void arm_init_before_mmu(void)
v7_inval_tlb();
}
+void mmu_page_table_flush(unsigned long start, unsigned long stop)
+{
+ flush_dcache_range(start, stop);
+ v7_inval_tlb();
+}
+
/*
* Flush range from all levels of d-cache/unified-cache used:
* Affects the range [start, start + size - 1]
@@ -329,6 +335,11 @@ void arm_init_before_mmu(void)
void flush_cache(unsigned long start, unsigned long size)
{
}
+
+void mmu_page_table_flush(unsigned long start, unsigned long stop)
+{
+}
+
#endif /* #ifndef CONFIG_SYS_DCACHE_OFF */
#ifndef CONFIG_SYS_ICACHE_OFF
diff --git a/arch/arm/include/asm/system.h b/arch/arm/include/asm/system.h
index 2b28a26..9a05211 100644
--- a/arch/arm/include/asm/system.h
+++ b/arch/arm/include/asm/system.h
@@ -75,6 +75,36 @@ static inline void set_cr(unsigned int val)
isb();
}
+/* options available for data cache on each page */
+enum dcache_option {
+ DCACHE_OFF = 0x12,
+ DCACHE_WRITETHROUGH = 0x1a,
+ DCACHE_WRITEBACK = 0x1e,
+};
+
+/* Size of an MMU section */
+enum {
+ MMU_SECTION_SHIFT = 20,
+ MMU_SECTION_SIZE = 1 << MMU_SECTION_SHIFT,
+};
+
+/**
+ * Change the cache settings for a region.
+ *
+ * \param start start address of memory region to change
+ * \param size size of memory region to change
+ * \param option dcache option to select
+ */
+void mmu_set_region_dcache(u32 start, int size, enum dcache_option option);
+
+/**
+ * Register an update to the page tables, and flush the TLB
+ *
+ * \param start start address of update in page table
+ * \param stop stop address of update in page table
+ */
+void mmu_page_table_flush(unsigned long start, unsigned long stop);
+
#endif /* __ASSEMBLY__ */
#define arch_align_stack(x) (x)
diff --git a/arch/arm/lib/cache-cp15.c b/arch/arm/lib/cache-cp15.c
index 939de10..c9bee42 100644
--- a/arch/arm/lib/cache-cp15.c
+++ b/arch/arm/lib/cache-cp15.c
@@ -26,12 +26,6 @@
#if !(defined(CONFIG_SYS_ICACHE_OFF) && defined(CONFIG_SYS_DCACHE_OFF))
-#if defined(CONFIG_SYS_ARM_CACHE_WRITETHROUGH)
-#define CACHE_SETUP 0x1a
-#else
-#define CACHE_SETUP 0x1e
-#endif
-
DECLARE_GLOBAL_DATA_PTR;
void __arm_init_before_mmu(void)
@@ -50,9 +44,40 @@ static void cp_delay (void)
asm volatile("" : : : "memory");
}
-static inline void dram_bank_mmu_setup(int bank)
+void set_section_dcache(int section, enum dcache_option option)
{
u32 *page_table = (u32 *)gd->tlb_addr;
+ u32 value;
+
+ value = (section << MMU_SECTION_SHIFT) | (3 << 10);
+ value |= option;
+ page_table[section] = value;
+}
+
+void __mmu_page_table_flush(unsigned long start, unsigned long stop)
+{
+ debug("%s: Warning: not implemented\n", __func__);
+}
+
+void mmu_page_table_flush(unsigned long start, unsigned long stop)
+ __attribute__((weak, alias("__mmu_page_table_flush")));
+
+void mmu_set_region_dcache(u32 start, int size, enum dcache_option option)
+{
+ u32 *page_table = (u32 *)gd->tlb_addr;
+ u32 upto, end;
+
+ end = ALIGN(start + size, MMU_SECTION_SIZE) >> MMU_SECTION_SHIFT;
+ start = start >> MMU_SECTION_SHIFT;
+ debug("mmu_set_region_dcache start=%x, size=%x, option=%d\n",
+ start, size, option);
+ for (upto = start; upto < end; upto++)
+ set_section_dcache(upto, option);
+ mmu_page_table_flush((u32)&page_table[start], (u32)&page_table[end]);
+}
+
+static inline void dram_bank_mmu_setup(int bank)
+{
bd_t *bd = gd->bd;
int i;
@@ -60,21 +85,24 @@ static inline void dram_bank_mmu_setup(int bank)
for (i = bd->bi_dram[bank].start >> 20;
i < (bd->bi_dram[bank].start + bd->bi_dram[bank].size) >> 20;
i++) {
- page_table[i] = i << 20 | (3 << 10) | CACHE_SETUP;
+#if defined(CONFIG_SYS_ARM_CACHE_WRITETHROUGH)
+ set_section_dcache(i, DCACHE_WRITETHROUGH);
+#else
+ set_section_dcache(i, DCACHE_WRITEBACK);
+#endif
}
}
/* to activate the MMU we need to set up virtual memory: use 1M areas */
static inline void mmu_setup(void)
{
- u32 *page_table = (u32 *)gd->tlb_addr;
int i;
u32 reg;
arm_init_before_mmu();
/* Set up an identity-mapping for all 4GB, rw for everyone */
for (i = 0; i < 4096; i++)
- page_table[i] = i << 20 | (3 << 10) | 0x12;
+ set_section_dcache(i, DCACHE_OFF);
for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
dram_bank_mmu_setup(i);
@@ -82,7 +110,7 @@ static inline void mmu_setup(void)
/* Copy the page table address to cp15 */
asm volatile("mcr p15, 0, %0, c2, c0, 0"
- : : "r" (page_table) : "memory");
+ : : "r" (gd->tlb_addr) : "memory");
/* Set the access control to all-supervisor */
asm volatile("mcr p15, 0, %0, c3, c0, 0"
: : "r" (~0));
--
1.7.7.3
^ permalink raw reply related [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 10/16] lcd: Add CONFIG_LCD_ALIGNMENT to select frame buffer alignment
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
` (8 preceding siblings ...)
2012-09-28 0:44 ` [U-Boot] [PATCH v4 09/16] arm: Add control over cachability of memory regions Simon Glass
@ 2012-09-28 0:44 ` Simon Glass
2012-09-28 0:44 ` [U-Boot] [PATCH v4 11/16] lcd: Add support for flushing LCD fb from dcache after update Simon Glass
` (7 subsequent siblings)
17 siblings, 0 replies; 40+ messages in thread
From: Simon Glass @ 2012-09-28 0:44 UTC (permalink / raw)
To: u-boot
The normal alignment is PAGE_SIZE, but if this is defined, we can support
other alignments.
The motivation for this change is to make the display section-aligned on
ARM so that we can easily turn off data caching for the frame buffer region
without resorting to level 2 page tables.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v2:
- Use a more generic config CONFIG_LCD_ALIGNMENT for lcd alignment
Changes in v4:
- Remove system.h header which is included anyway by most archs
README | 10 ++++++++++
common/lcd.c | 21 ++++++++++++++++-----
include/lcd.h | 3 +++
3 files changed, 29 insertions(+), 5 deletions(-)
diff --git a/README b/README
index 5793b0a..1d0ce50 100644
--- a/README
+++ b/README
@@ -1440,6 +1440,16 @@ The following options need to be configured:
Normally display is black on white background; define
CONFIG_SYS_WHITE_ON_BLACK to get it inverted.
+
+ CONFIG_LCD_ALIGNMENT
+
+ Normally the LCD is page-aligned (tyically 4KB). If this is
+ defined then the LCD will be aligned to this value instead.
+ For ARM it is sometimes useful to use MMU_SECTION_SIZE
+ here, since it is cheaper to change data cache settings on
+ a per-section basis.
+
+
- Splash Screen Support: CONFIG_SPLASH_SCREEN
If this option is set, the environment is checked for
diff --git a/common/lcd.c b/common/lcd.c
index b6be800..37b0393 100644
--- a/common/lcd.c
+++ b/common/lcd.c
@@ -72,6 +72,10 @@
# endif
#endif
+#ifndef CONFIG_LCD_ALIGNMENT
+#define CONFIG_LCD_ALIGNMENT PAGE_SIZE
+#endif
+
DECLARE_GLOBAL_DATA_PTR;
ulong lcd_setmem (ulong addr);
@@ -326,6 +330,12 @@ static void test_pattern(void)
/* ** GENERIC Initialization Routines */
/************************************************************************/
+int lcd_get_size(int *line_length)
+{
+ *line_length = (panel_info.vl_col * NBITS(panel_info.vl_bpix)) / 8;
+ return *line_length * panel_info.vl_row;
+}
+
int drv_lcd_init (void)
{
struct stdio_dev lcddev;
@@ -333,7 +343,7 @@ int drv_lcd_init (void)
lcd_base = (void *)(gd->fb_base);
- lcd_line_length = (panel_info.vl_col * NBITS (panel_info.vl_bpix)) / 8;
+ lcd_get_size(&lcd_line_length);
lcd_init(lcd_base); /* LCD initialization */
@@ -445,15 +455,16 @@ static int lcd_init(void *lcdbase)
ulong lcd_setmem(ulong addr)
{
ulong size;
- int line_length = (panel_info.vl_col * NBITS(panel_info.vl_bpix)) / 8;
+ int line_length;
debug("LCD panel info: %d x %d, %d bit/pix\n", panel_info.vl_col,
panel_info.vl_row, NBITS(panel_info.vl_bpix));
- size = line_length * panel_info.vl_row;
+ size = lcd_get_size(&line_length);
- /* Round up to nearest full page */
- size = (size + (PAGE_SIZE - 1)) & ~(PAGE_SIZE - 1);
+ /* Round up to nearest full page, or MMU section if defined */
+ size = ALIGN(size, CONFIG_LCD_ALIGNMENT);
+ addr = ALIGN(addr - CONFIG_LCD_ALIGNMENT + 1, CONFIG_LCD_ALIGNMENT);
/* Allocate pages for the frame buffer. */
addr -= size;
diff --git a/include/lcd.h b/include/lcd.h
index 42070d7..6a600ee 100644
--- a/include/lcd.h
+++ b/include/lcd.h
@@ -297,6 +297,9 @@ int lcd_display_bitmap(ulong bmp_image, int x, int y);
/* Allow boards to customize the information displayed */
void lcd_show_board_info(void);
+/* Return the size of the LCD frame buffer, and the line length */
+int lcd_get_size(int *line_length);
+
/************************************************************************/
/* ** BITMAP DISPLAY SUPPORT */
/************************************************************************/
--
1.7.7.3
^ permalink raw reply related [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 11/16] lcd: Add support for flushing LCD fb from dcache after update
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
` (9 preceding siblings ...)
2012-09-28 0:44 ` [U-Boot] [PATCH v4 10/16] lcd: Add CONFIG_LCD_ALIGNMENT to select frame buffer alignment Simon Glass
@ 2012-09-28 0:44 ` Simon Glass
2012-09-28 0:44 ` [U-Boot] [PATCH v4 12/16] tegra: Align LCD frame buffer to section boundary Simon Glass
` (6 subsequent siblings)
17 siblings, 0 replies; 40+ messages in thread
From: Simon Glass @ 2012-09-28 0:44 UTC (permalink / raw)
To: u-boot
This provides an option for the LCD to flush the dcache after each update
(puts, scroll or clear).
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v2:
- Put the LCD cache flush logic into lcd_putc() instead of lcd_puts()
Changes in v3:
- Put the LCD cache flush logic back into lcd_puts()
Changes in v4:
- Use lcd_puts() for echoing user input so lcd cached data is flushed
common/lcd.c | 46 +++++++++++++++++++++++++++++++++++++++-------
common/main.c | 12 ++++++++++--
include/lcd.h | 8 ++++++++
3 files changed, 57 insertions(+), 9 deletions(-)
diff --git a/common/lcd.c b/common/lcd.c
index 37b0393..74fa3f9 100644
--- a/common/lcd.c
+++ b/common/lcd.c
@@ -94,6 +94,9 @@ static void lcd_setbgcolor(int color);
char lcd_is_enabled = 0;
+static char lcd_flush_dcache; /* 1 to flush dcache after each lcd update */
+
+
#ifdef NOT_USED_SO_FAR
static void lcd_getcolreg(ushort regno,
ushort *red, ushort *green, ushort *blue);
@@ -102,6 +105,28 @@ static int lcd_getfgcolor(void);
/************************************************************************/
+/* Flush LCD activity to the caches */
+void lcd_sync(void)
+{
+ /*
+ * flush_dcache_range() is declared in common.h but it seems that some
+ * architectures do not actually implement it. Is there a way to find
+ * out whether it exists? For now, ARM is safe.
+ */
+#ifdef CONFIG_ARM
+ int line_length;
+
+ if (lcd_flush_dcache)
+ flush_dcache_range((u32)lcd_base,
+ (u32)(lcd_base + lcd_get_size(&line_length)));
+#endif
+}
+
+void lcd_set_flush_dcache(int flush)
+{
+ lcd_flush_dcache = (flush != 0);
+}
+
/*----------------------------------------------------------------------*/
static void console_scrollup(void)
@@ -111,6 +136,7 @@ static void console_scrollup(void)
/* Clear the last one */
memset(CONSOLE_ROW_LAST, COLOR_MASK(lcd_color_bg), CONSOLE_ROW_SIZE);
+ lcd_sync();
}
/*----------------------------------------------------------------------*/
@@ -140,6 +166,8 @@ static inline void console_newline(void)
/* Scroll everything up */
console_scrollup();
--console_row;
+ } else {
+ lcd_sync();
}
}
@@ -195,6 +223,7 @@ void lcd_puts(const char *s)
while (*s) {
lcd_putc(*s++);
}
+ lcd_sync();
}
/*----------------------------------------------------------------------*/
@@ -362,13 +391,6 @@ int drv_lcd_init (void)
}
/*----------------------------------------------------------------------*/
-static
-int do_lcd_clear(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
-{
- lcd_clear();
- return 0;
-}
-
void lcd_clear(void)
{
#if LCD_BPP == LCD_MONOCHROME
@@ -410,6 +432,14 @@ void lcd_clear(void)
console_col = 0;
console_row = 0;
+ lcd_sync();
+}
+
+static int do_lcd_clear(cmd_tbl_t *cmdtp, int flag, int argc,
+ char *const argv[])
+{
+ lcd_clear();
+ return 0;
}
U_BOOT_CMD(
@@ -621,6 +651,7 @@ void bitmap_plot(int x, int y)
}
WATCHDOG_RESET();
+ lcd_sync();
}
#else
static inline void bitmap_plot(int x, int y) {}
@@ -842,6 +873,7 @@ int lcd_display_bitmap(ulong bmp_image, int x, int y)
break;
};
+ lcd_sync();
return 0;
}
#endif
diff --git a/common/main.c b/common/main.c
index 81984ac..d3356e1 100644
--- a/common/main.c
+++ b/common/main.c
@@ -1040,8 +1040,16 @@ int readline_into_buffer(const char *const prompt, char *buffer, int timeout)
puts (tab_seq+(col&07));
col += 8 - (col&07);
} else {
- ++col; /* echo input */
- putc (c);
+ char buf[2];
+
+ /*
+ * Echo input using puts() to force am
+ * LCD flush if we are using an LCD
+ */
+ ++col;
+ buf[0] = c;
+ buf[1] = '\0';
+ puts(buf);
}
*p++ = c;
++n;
diff --git a/include/lcd.h b/include/lcd.h
index 6a600ee..8f84741 100644
--- a/include/lcd.h
+++ b/include/lcd.h
@@ -57,6 +57,14 @@ extern void lcd_initcolregs (void);
extern struct bmp_image *gunzip_bmp(unsigned long addr, unsigned long *lenp);
extern int bmp_display(ulong addr, int x, int y);
+/**
+ * Set whether we need to flush the dcache when changing the LCD image. This
+ * defaults to off.
+ *
+ * @param flush non-zero to flush cache after update, 0 to skip
+ */
+void lcd_set_flush_dcache(int flush);
+
#if defined CONFIG_MPC823
/*
* LCD controller stucture for MPC823 CPU
--
1.7.7.3
^ permalink raw reply related [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 12/16] tegra: Align LCD frame buffer to section boundary
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
` (10 preceding siblings ...)
2012-09-28 0:44 ` [U-Boot] [PATCH v4 11/16] lcd: Add support for flushing LCD fb from dcache after update Simon Glass
@ 2012-09-28 0:44 ` Simon Glass
2012-09-28 0:44 ` [U-Boot] [PATCH v4 13/16] tegra: Support control of cache settings for LCD Simon Glass
` (5 subsequent siblings)
17 siblings, 0 replies; 40+ messages in thread
From: Simon Glass @ 2012-09-28 0:44 UTC (permalink / raw)
To: u-boot
For tegra we want to enable the cache for the LCD. This is easier if
we can avoid using L2 page tages, so align the LCD to a section
boundary.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v2:
- Align tegra display using new CONFIG_LCD_ALIGNMENT feature
include/configs/tegra20-common.h | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/include/configs/tegra20-common.h b/include/configs/tegra20-common.h
index fa14a1c..a96233a 100644
--- a/include/configs/tegra20-common.h
+++ b/include/configs/tegra20-common.h
@@ -45,6 +45,9 @@
#include <asm/arch/tegra.h> /* get chip and board defs */
+/* Align LCD to 1MB boundary */
+#define CONFIG_LCD_ALIGNMENT MMU_SECTION_SIZE
+
/*
* Display CPU and Board information
*/
--
1.7.7.3
^ permalink raw reply related [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 13/16] tegra: Support control of cache settings for LCD
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
` (11 preceding siblings ...)
2012-09-28 0:44 ` [U-Boot] [PATCH v4 12/16] tegra: Align LCD frame buffer to section boundary Simon Glass
@ 2012-09-28 0:44 ` Simon Glass
2012-09-28 0:44 ` [U-Boot] [PATCH v4 14/16] tegra: fdt: Add LCD definitions for Seaboard Simon Glass
` (4 subsequent siblings)
17 siblings, 0 replies; 40+ messages in thread
From: Simon Glass @ 2012-09-28 0:44 UTC (permalink / raw)
To: u-boot
Add support for selecting the required cache mode for the LCD:
off, write-through or write-back.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v3:
- Handle a cached frame buffer out of normal U-Boot memory
drivers/video/tegra.c | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/drivers/video/tegra.c b/drivers/video/tegra.c
index 9df2bd3..ff2b70e 100644
--- a/drivers/video/tegra.c
+++ b/drivers/video/tegra.c
@@ -145,6 +145,7 @@ static void update_panel_size(struct fdt_disp_config *config)
void lcd_ctrl_init(void *lcdbase)
{
int line_length, size;
+ int type = DCACHE_OFF;
assert(disp_config);
@@ -160,6 +161,16 @@ void lcd_ctrl_init(void *lcdbase)
update_panel_size(disp_config);
size = lcd_get_size(&line_length);
+ /* Set up the LCD caching as requested */
+ if (config.cache_type & FDT_LCD_CACHE_WRITE_THROUGH)
+ type = DCACHE_WRITETHROUGH;
+ else if (config.cache_type & FDT_LCD_CACHE_WRITE_BACK)
+ type = DCACHE_WRITEBACK;
+ mmu_set_region_dcache(disp_config->frame_buffer, size, type);
+
+ /* Enable flushing after LCD writes if requested */
+ lcd_set_flush_dcache(config.cache_type & FDT_LCD_CACHE_FLUSH);
+
debug("LCD frame buffer at %p\n", lcd_base);
}
--
1.7.7.3
^ permalink raw reply related [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 14/16] tegra: fdt: Add LCD definitions for Seaboard
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
` (12 preceding siblings ...)
2012-09-28 0:44 ` [U-Boot] [PATCH v4 13/16] tegra: Support control of cache settings for LCD Simon Glass
@ 2012-09-28 0:44 ` Simon Glass
2012-10-03 22:58 ` Stephen Warren
2012-09-28 0:44 ` [U-Boot] [PATCH v4 15/16] lcd: Add CONSOLE_SCROLL_LINES option to speed console Simon Glass
` (3 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Simon Glass @ 2012-09-28 0:44 UTC (permalink / raw)
To: u-boot
The Seaboard has a 1366x768 16bpp LCD. The backlight is controlled
by one of the PWMs.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v2:
- Update seaboard LCD definitions for new fdt binding
Changes in v3:
- Use new upstream proposed LCD definitions
Changes in v4:
- Adjust LCD fdt nodes for new binding
- Remove LCD frame buffer address property hack
board/nvidia/dts/tegra20-seaboard.dts | 31 +++++++++++++++++++++++++++++++
1 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/board/nvidia/dts/tegra20-seaboard.dts b/board/nvidia/dts/tegra20-seaboard.dts
index 25a63a0..df730f5 100644
--- a/board/nvidia/dts/tegra20-seaboard.dts
+++ b/board/nvidia/dts/tegra20-seaboard.dts
@@ -163,4 +163,35 @@
compatible = "hynix,hy27uf4g2b", "nand-flash";
};
};
+
+ host1x {
+ dc at 54200000 {
+ rgb {
+ status = "okay";
+ nvidia,panel = <&lcd_panel>;
+ };
+ };
+ };
+
+ lcd_panel: panel {
+ /* Seaboard has 1366x768 */
+ clock = <70600000>;
+ xres = <1366>;
+ yres = <768>;
+ left-margin = <58>;
+ right-margin = <58>;
+ hsync-len = <58>;
+ lower-margin = <4>;
+ upper-margin = <4>;
+ vsync-len = <4>;
+ hsync-active-high;
+ nvidia,bits-per-pixel = <16>;
+ nvidia,pwm = <&pwm 2 0>;
+ nvidia,backlight-enable-gpios = <&gpio 28 0>; /* PD4 */
+ nvidia,lvds-shutdown-gpios = <&gpio 10 0>; /* PB2 */
+ nvidia,backlight-vdd-gpios = <&gpio 176 0>; /* PW0 */
+ nvidia,panel-vdd-gpios = <&gpio 22 0>; /* PC6 */
+ nvidia,panel-timings = <4 203 17 15>;
+ };
+
};
--
1.7.7.3
^ permalink raw reply related [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 14/16] tegra: fdt: Add LCD definitions for Seaboard
2012-09-28 0:44 ` [U-Boot] [PATCH v4 14/16] tegra: fdt: Add LCD definitions for Seaboard Simon Glass
@ 2012-10-03 22:58 ` Stephen Warren
2012-10-08 20:06 ` Simon Glass
0 siblings, 1 reply; 40+ messages in thread
From: Stephen Warren @ 2012-10-03 22:58 UTC (permalink / raw)
To: u-boot
On 09/27/2012 06:44 PM, Simon Glass wrote:
> The Seaboard has a 1366x768 16bpp LCD. The backlight is controlled
> by one of the PWMs.
> diff --git a/board/nvidia/dts/tegra20-seaboard.dts b/board/nvidia/dts/tegra20-seaboard.dts
> + host1x {
> + dc at 54200000 {
So based on my previous comment, I think you want status="okay" at this
level too, perhaps even at the host1x level.
> + rgb {
> + status = "okay";
> + nvidia,panel = <&lcd_panel>;
> + };
> + };
> + };
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 14/16] tegra: fdt: Add LCD definitions for Seaboard
2012-10-03 22:58 ` Stephen Warren
@ 2012-10-08 20:06 ` Simon Glass
0 siblings, 0 replies; 40+ messages in thread
From: Simon Glass @ 2012-10-08 20:06 UTC (permalink / raw)
To: u-boot
Hi Stephen,
On Wed, Oct 3, 2012 at 3:58 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 09/27/2012 06:44 PM, Simon Glass wrote:
>> The Seaboard has a 1366x768 16bpp LCD. The backlight is controlled
>> by one of the PWMs.
>
>> diff --git a/board/nvidia/dts/tegra20-seaboard.dts b/board/nvidia/dts/tegra20-seaboard.dts
>
>> + host1x {
>> + dc at 54200000 {
>
> So based on my previous comment, I think you want status="okay" at this
> level too, perhaps even at the host1x level.
Yes I will do this.
>
>> + rgb {
>> + status = "okay";
>> + nvidia,panel = <&lcd_panel>;
>> + };
>> + };
>> + };
>
Regards,
Simon
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot] [PATCH v4 15/16] lcd: Add CONSOLE_SCROLL_LINES option to speed console
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
` (13 preceding siblings ...)
2012-09-28 0:44 ` [U-Boot] [PATCH v4 14/16] tegra: fdt: Add LCD definitions for Seaboard Simon Glass
@ 2012-09-28 0:44 ` Simon Glass
2012-09-28 14:51 ` Lucas Stach
2012-09-28 0:44 ` [U-Boot] [PATCH v4 16/16] tegra: Enable display/lcd support on Seaboard Simon Glass
` (2 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Simon Glass @ 2012-09-28 0:44 UTC (permalink / raw)
To: u-boot
When the cursor position gets to the end of the LCD console we normally
scroll by one line. This adds an option to increase that value.
Console scrolling is often slow, and if a large amount of output is
being sent, increasing this option to 10 or so will speed things up
considerably.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v3:
- Fix tiny bug in mult-line lcd scrolling
Changes in v4:
- Use CONFIG_CONSOLE_SCROLL_LINES instead of CONSOLE_SCROLL_LINES
- Put default CONFIG_CONSOLE_SCROLL_LINES at top of file
README | 6 ++++++
common/lcd.c | 18 +++++++++++++++---
2 files changed, 21 insertions(+), 3 deletions(-)
diff --git a/README b/README
index 1d0ce50..14b1f83 100644
--- a/README
+++ b/README
@@ -1449,6 +1449,12 @@ The following options need to be configured:
here, since it is cheaper to change data cache settings on
a per-section basis.
+ CONFIG_CONSOLE_SCROLL_LINES
+
+ When the console need to be scrolled, this is the number of
+ lines to scroll by. It defaults to 1. Increasing this makes
+ the console jump but can help speed up operation when scrolling
+ is slow.
- Splash Screen Support: CONFIG_SPLASH_SCREEN
diff --git a/common/lcd.c b/common/lcd.c
index 74fa3f9..460f0ca 100644
--- a/common/lcd.c
+++ b/common/lcd.c
@@ -76,6 +76,11 @@
#define CONFIG_LCD_ALIGNMENT PAGE_SIZE
#endif
+/* By default we scroll by a single line */
+#ifndef CONFIG_CONSOLE_SCROLL_LINES
+#define CONFIG_CONSOLE_SCROLL_LINES 1
+#endif
+
DECLARE_GLOBAL_DATA_PTR;
ulong lcd_setmem (ulong addr);
@@ -131,12 +136,20 @@ void lcd_set_flush_dcache(int flush)
static void console_scrollup(void)
{
+ const int rows = CONFIG_CONSOLE_SCROLL_LINES;
+
/* Copy up rows ignoring the first one */
- memcpy(CONSOLE_ROW_FIRST, CONSOLE_ROW_SECOND, CONSOLE_SCROLL_SIZE);
+ memcpy(CONSOLE_ROW_FIRST,
+ lcd_console_address + CONSOLE_ROW_SIZE * rows,
+ CONSOLE_SIZE - CONSOLE_ROW_SIZE * rows);
/* Clear the last one */
- memset(CONSOLE_ROW_LAST, COLOR_MASK(lcd_color_bg), CONSOLE_ROW_SIZE);
+ memset(lcd_console_address + CONSOLE_SIZE - CONSOLE_ROW_SIZE * rows,
+ COLOR_MASK(lcd_color_bg),
+ CONSOLE_ROW_SIZE * rows);
+
lcd_sync();
+ console_row -= rows;
}
/*----------------------------------------------------------------------*/
@@ -165,7 +178,6 @@ static inline void console_newline(void)
if (console_row >= CONSOLE_ROWS) {
/* Scroll everything up */
console_scrollup();
- --console_row;
} else {
lcd_sync();
}
--
1.7.7.3
^ permalink raw reply related [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 15/16] lcd: Add CONSOLE_SCROLL_LINES option to speed console
2012-09-28 0:44 ` [U-Boot] [PATCH v4 15/16] lcd: Add CONSOLE_SCROLL_LINES option to speed console Simon Glass
@ 2012-09-28 14:51 ` Lucas Stach
2012-10-08 19:55 ` Simon Glass
0 siblings, 1 reply; 40+ messages in thread
From: Lucas Stach @ 2012-09-28 14:51 UTC (permalink / raw)
To: u-boot
Am Donnerstag, den 27.09.2012, 17:44 -0700 schrieb Simon Glass:
> When the cursor position gets to the end of the LCD console we normally
> scroll by one line. This adds an option to increase that value.
>
> Console scrolling is often slow, and if a large amount of output is
> being sent, increasing this option to 10 or so will speed things up
> considerably.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> Changes in v3:
> - Fix tiny bug in mult-line lcd scrolling
>
> Changes in v4:
> - Use CONFIG_CONSOLE_SCROLL_LINES instead of CONSOLE_SCROLL_LINES
> - Put default CONFIG_CONSOLE_SCROLL_LINES at top of file
>
> README | 6 ++++++
> common/lcd.c | 18 +++++++++++++++---
> 2 files changed, 21 insertions(+), 3 deletions(-)
>
> diff --git a/README b/README
> index 1d0ce50..14b1f83 100644
> --- a/README
> +++ b/README
> @@ -1449,6 +1449,12 @@ The following options need to be configured:
> here, since it is cheaper to change data cache settings on
> a per-section basis.
>
> + CONFIG_CONSOLE_SCROLL_LINES
> +
> + When the console need to be scrolled, this is the number of
> + lines to scroll by. It defaults to 1. Increasing this makes
> + the console jump but can help speed up operation when scrolling
> + is slow.
>
> - Splash Screen Support: CONFIG_SPLASH_SCREEN
>
> diff --git a/common/lcd.c b/common/lcd.c
> index 74fa3f9..460f0ca 100644
> --- a/common/lcd.c
> +++ b/common/lcd.c
> @@ -76,6 +76,11 @@
> #define CONFIG_LCD_ALIGNMENT PAGE_SIZE
> #endif
>
> +/* By default we scroll by a single line */
> +#ifndef CONFIG_CONSOLE_SCROLL_LINES
> +#define CONFIG_CONSOLE_SCROLL_LINES 1
> +#endif
> +
> DECLARE_GLOBAL_DATA_PTR;
>
> ulong lcd_setmem (ulong addr);
> @@ -131,12 +136,20 @@ void lcd_set_flush_dcache(int flush)
>
> static void console_scrollup(void)
> {
> + const int rows = CONFIG_CONSOLE_SCROLL_LINES;
> +
> /* Copy up rows ignoring the first one */
Comment is inaccurate as you possibly ignore more than the first line.
> - memcpy(CONSOLE_ROW_FIRST, CONSOLE_ROW_SECOND, CONSOLE_SCROLL_SIZE);
> + memcpy(CONSOLE_ROW_FIRST,
> + lcd_console_address + CONSOLE_ROW_SIZE * rows,
> + CONSOLE_SIZE - CONSOLE_ROW_SIZE * rows);
>
> /* Clear the last one */
Same as above.
> - memset(CONSOLE_ROW_LAST, COLOR_MASK(lcd_color_bg), CONSOLE_ROW_SIZE);
> + memset(lcd_console_address + CONSOLE_SIZE - CONSOLE_ROW_SIZE * rows,
> + COLOR_MASK(lcd_color_bg),
> + CONSOLE_ROW_SIZE * rows);
> +
> lcd_sync();
> + console_row -= rows;
> }
>
> /*----------------------------------------------------------------------*/
> @@ -165,7 +178,6 @@ static inline void console_newline(void)
> if (console_row >= CONSOLE_ROWS) {
> /* Scroll everything up */
> console_scrollup();
> - --console_row;
> } else {
> lcd_sync();
> }
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 15/16] lcd: Add CONSOLE_SCROLL_LINES option to speed console
2012-09-28 14:51 ` Lucas Stach
@ 2012-10-08 19:55 ` Simon Glass
0 siblings, 0 replies; 40+ messages in thread
From: Simon Glass @ 2012-10-08 19:55 UTC (permalink / raw)
To: u-boot
Hi Lucas,
On Fri, Sep 28, 2012 at 7:51 AM, Lucas Stach <dev@lynxeye.de> wrote:
> Am Donnerstag, den 27.09.2012, 17:44 -0700 schrieb Simon Glass:
>> When the cursor position gets to the end of the LCD console we normally
>> scroll by one line. This adds an option to increase that value.
>>
>> Console scrolling is often slow, and if a large amount of output is
>> being sent, increasing this option to 10 or so will speed things up
>> considerably.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> ---
>> Changes in v3:
>> - Fix tiny bug in mult-line lcd scrolling
>>
>> Changes in v4:
>> - Use CONFIG_CONSOLE_SCROLL_LINES instead of CONSOLE_SCROLL_LINES
>> - Put default CONFIG_CONSOLE_SCROLL_LINES at top of file
>>
>> README | 6 ++++++
>> common/lcd.c | 18 +++++++++++++++---
>> 2 files changed, 21 insertions(+), 3 deletions(-)
>>
>> diff --git a/README b/README
>> index 1d0ce50..14b1f83 100644
>> --- a/README
>> +++ b/README
>> @@ -1449,6 +1449,12 @@ The following options need to be configured:
>> here, since it is cheaper to change data cache settings on
>> a per-section basis.
>>
>> + CONFIG_CONSOLE_SCROLL_LINES
>> +
>> + When the console need to be scrolled, this is the number of
>> + lines to scroll by. It defaults to 1. Increasing this makes
>> + the console jump but can help speed up operation when scrolling
>> + is slow.
>>
>> - Splash Screen Support: CONFIG_SPLASH_SCREEN
>>
>> diff --git a/common/lcd.c b/common/lcd.c
>> index 74fa3f9..460f0ca 100644
>> --- a/common/lcd.c
>> +++ b/common/lcd.c
>> @@ -76,6 +76,11 @@
>> #define CONFIG_LCD_ALIGNMENT PAGE_SIZE
>> #endif
>>
>> +/* By default we scroll by a single line */
>> +#ifndef CONFIG_CONSOLE_SCROLL_LINES
>> +#define CONFIG_CONSOLE_SCROLL_LINES 1
>> +#endif
>> +
>> DECLARE_GLOBAL_DATA_PTR;
>>
>> ulong lcd_setmem (ulong addr);
>> @@ -131,12 +136,20 @@ void lcd_set_flush_dcache(int flush)
>>
>> static void console_scrollup(void)
>> {
>> + const int rows = CONFIG_CONSOLE_SCROLL_LINES;
>> +
>> /* Copy up rows ignoring the first one */
> Comment is inaccurate as you possibly ignore more than the first line.
>
>> - memcpy(CONSOLE_ROW_FIRST, CONSOLE_ROW_SECOND, CONSOLE_SCROLL_SIZE);
>> + memcpy(CONSOLE_ROW_FIRST,
>> + lcd_console_address + CONSOLE_ROW_SIZE * rows,
>> + CONSOLE_SIZE - CONSOLE_ROW_SIZE * rows);
>>
>> /* Clear the last one */
> Same as above.
OK thanks, I will tidy these up.
>
>> - memset(CONSOLE_ROW_LAST, COLOR_MASK(lcd_color_bg), CONSOLE_ROW_SIZE);
>> + memset(lcd_console_address + CONSOLE_SIZE - CONSOLE_ROW_SIZE * rows,
>> + COLOR_MASK(lcd_color_bg),
>> + CONSOLE_ROW_SIZE * rows);
>> +
>> lcd_sync();
>> + console_row -= rows;
>> }
>>
>> /*----------------------------------------------------------------------*/
>> @@ -165,7 +178,6 @@ static inline void console_newline(void)
>> if (console_row >= CONSOLE_ROWS) {
>> /* Scroll everything up */
>> console_scrollup();
>> - --console_row;
>> } else {
>> lcd_sync();
>> }
>
>
Regards,
Simon
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot] [PATCH v4 16/16] tegra: Enable display/lcd support on Seaboard
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
` (14 preceding siblings ...)
2012-09-28 0:44 ` [U-Boot] [PATCH v4 15/16] lcd: Add CONSOLE_SCROLL_LINES option to speed console Simon Glass
@ 2012-09-28 0:44 ` Simon Glass
2012-10-03 17:05 ` [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Stephen Warren
2012-10-03 23:00 ` Stephen Warren
17 siblings, 0 replies; 40+ messages in thread
From: Simon Glass @ 2012-09-28 0:44 UTC (permalink / raw)
To: u-boot
From: Mayuresh Kulkarni <mkulkarni@nvidia.com>
Enable the Seaboard's 16-bit LCD and use it as the console.
Signed-off-by: Mayuresh Kulkarni <mkulkarni@nvidia.com>
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v4:
- Add CONFIG_BOARD_LATE_INIT to enable LCD
- Use CONFIG_CONSOLE_SCROLL_LINES instead of CONSOLE_SCROLL_LINES
- Enable separate CONFIG_PWM_TEGRA option
include/configs/seaboard.h | 13 +++++++++++--
1 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/include/configs/seaboard.h b/include/configs/seaboard.h
index de19e38..19c5bf3 100644
--- a/include/configs/seaboard.h
+++ b/include/configs/seaboard.h
@@ -55,6 +55,7 @@
#define CONFIG_MACH_TYPE MACH_TYPE_SEABOARD
#define CONFIG_BOARD_EARLY_INIT_F
+#define CONFIG_BOARD_LATE_INIT /* Make sure LCD init is complete */
/* I2C */
#define CONFIG_TEGRA_I2C
@@ -101,8 +102,16 @@
#undef TEGRA_DEVICE_SETTINGS
#define TEGRA_DEVICE_SETTINGS "stdin=serial,tegra-kbc\0" \
- "stdout=serial\0" \
- "stderr=serial\0"
+ "stdout=serial,lcd\0" \
+ "stderr=serial,lcd\0"
+
+/* LCD support */
+#define CONFIG_LCD
+#define CONFIG_PWM_TEGRA
+#define CONFIG_VIDEO_TEGRA
+#define LCD_BPP LCD_COLOR16
+#define CONFIG_SYS_WHITE_ON_BLACK
+#define CONFIG_CONSOLE_SCROLL_LINES 10
#include "tegra-common-post.h"
--
1.7.7.3
^ permalink raw reply related [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
` (15 preceding siblings ...)
2012-09-28 0:44 ` [U-Boot] [PATCH v4 16/16] tegra: Enable display/lcd support on Seaboard Simon Glass
@ 2012-10-03 17:05 ` Stephen Warren
2012-10-03 17:22 ` Stephen Warren
` (2 more replies)
2012-10-03 23:00 ` Stephen Warren
17 siblings, 3 replies; 40+ messages in thread
From: Stephen Warren @ 2012-10-03 17:05 UTC (permalink / raw)
To: u-boot
On 09/27/2012 06:44 PM, Simon Glass wrote:
> This series adds support for the Tegra2x's display peripheral. This
> supports the LCD display on Seaboard and we use this to enable console
> output in U-Boot on the LCD.
I tested this on Seaboard, and found a couple of minor issues:
1) Nothing sets up the environment to enable LCD output; I had to execute:
setenv stdout serial,lcd
... in order to see anything on the display. I'd expect patch 16/16 to
cause this to happen automatically?
It's probably best to fix this by revising patch 16 rather than later,
since I presume this is trivial to fix?
2) The display works fine for cold boot, or hitting the physical reset
button, but when I execute "reset" at the U-Boot prompt, or "reboot"
within Linux, the display is messed up; it looks like the LCD isn't able
to sync to the timings sent by the display controller or something similar.
Since this is slightly a corner case, it may be OK to fix it later (but
not much later; reboot is very useful to me.)
I'll provide review comments on the patches themselves later.
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard
2012-10-03 17:05 ` [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Stephen Warren
@ 2012-10-03 17:22 ` Stephen Warren
2012-10-03 20:56 ` Simon Glass
2012-10-05 19:51 ` Stephen Warren
2 siblings, 0 replies; 40+ messages in thread
From: Stephen Warren @ 2012-10-03 17:22 UTC (permalink / raw)
To: u-boot
On 10/03/2012 11:05 AM, Stephen Warren wrote:
> On 09/27/2012 06:44 PM, Simon Glass wrote:
>> This series adds support for the Tegra2x's display peripheral. This
>> supports the LCD display on Seaboard and we use this to enable console
>> output in U-Boot on the LCD.
>
> I tested this on Seaboard, and found a couple of minor issues:
>
> 1) Nothing sets up the environment to enable LCD output; I had to execute:
>
> setenv stdout serial,lcd
>
> ... in order to see anything on the display. I'd expect patch 16/16 to
> cause this to happen automatically?
>
> It's probably best to fix this by revising patch 16 rather than later,
> since I presume this is trivial to fix?
This is a false alarm. I had a valid environment in flash before which
didn't set stdout to LCD obviously. As soon as I run "env default -a",
everything works as expected.
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard
2012-10-03 17:05 ` [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Stephen Warren
2012-10-03 17:22 ` Stephen Warren
@ 2012-10-03 20:56 ` Simon Glass
2012-10-05 19:51 ` Stephen Warren
2 siblings, 0 replies; 40+ messages in thread
From: Simon Glass @ 2012-10-03 20:56 UTC (permalink / raw)
To: u-boot
Hi Stephen,
On Wed, Oct 3, 2012 at 10:05 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 09/27/2012 06:44 PM, Simon Glass wrote:
>> This series adds support for the Tegra2x's display peripheral. This
>> supports the LCD display on Seaboard and we use this to enable console
>> output in U-Boot on the LCD.
>
> I tested this on Seaboard, and found a couple of minor issues:
>
> 1) Nothing sets up the environment to enable LCD output; I had to execute:
>
> setenv stdout serial,lcd
>
> ... in order to see anything on the display. I'd expect patch 16/16 to
> cause this to happen automatically?
>
> It's probably best to fix this by revising patch 16 rather than later,
> since I presume this is trivial to fix?
OK, skipping this as per your next message.
>
> 2) The display works fine for cold boot, or hitting the physical reset
> button, but when I execute "reset" at the U-Boot prompt, or "reboot"
> within Linux, the display is messed up; it looks like the LCD isn't able
> to sync to the timings sent by the display controller or something similar.
>
> Since this is slightly a corner case, it may be OK to fix it later (but
> not much later; reboot is very useful to me.)
Yes I also noticed this, and I think we discussed it with the previous
version also. Sorry I didn't add this to the commit message. It seems
odd that a s/w reset would put it into a different state that a
physical reset. I am not too sure how to approach this problem - I
wonder if it might be one for Nvidia to look at?
>
>
> I'll provide review comments on the patches themselves later.
Regards,
Simon
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard
2012-10-03 17:05 ` [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Stephen Warren
2012-10-03 17:22 ` Stephen Warren
2012-10-03 20:56 ` Simon Glass
@ 2012-10-05 19:51 ` Stephen Warren
2012-10-08 20:06 ` Simon Glass
2 siblings, 1 reply; 40+ messages in thread
From: Stephen Warren @ 2012-10-05 19:51 UTC (permalink / raw)
To: u-boot
On 10/03/2012 11:05 AM, Stephen Warren wrote:
> On 09/27/2012 06:44 PM, Simon Glass wrote:
>> This series adds support for the Tegra2x's display peripheral. This
>> supports the LCD display on Seaboard and we use this to enable console
>> output in U-Boot on the LCD.
...
> 2) The display works fine for cold boot, or hitting the physical reset
> button, but when I execute "reset" at the U-Boot prompt, or "reboot"
> within Linux, the display is messed up; it looks like the LCD isn't able
> to sync to the timings sent by the display controller or something similar.
>
> Since this is slightly a corner case, it may be OK to fix it later (but
> not much later; reboot is very useful to me.)
A couple more points:
BTW, I tried the same tests on Springbank which is basically Seaboard
with a slightly different PCB layout, and didn't see this issue. That
leads me to suspect some timing issue interacting with the panel, which
I believe is different albeit theoretically compatible
resolution/scan-timing wise.
Second, I first applied Tom's Tegra30 patches and tested those, then
applied your LCD series. The LCD series as-is breaks compilation of the
Tegra30 support. I have no idea which order Tom might apply these in,
but this is a heads-up there will be conflicts and one needs to be
rebased on top of the other.
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard
2012-10-05 19:51 ` Stephen Warren
@ 2012-10-08 20:06 ` Simon Glass
2012-10-08 20:26 ` Tom Warren
2012-10-08 21:30 ` Stephen Warren
0 siblings, 2 replies; 40+ messages in thread
From: Simon Glass @ 2012-10-08 20:06 UTC (permalink / raw)
To: u-boot
Hi Stephen,
On Fri, Oct 5, 2012 at 12:51 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 10/03/2012 11:05 AM, Stephen Warren wrote:
>> On 09/27/2012 06:44 PM, Simon Glass wrote:
>>> This series adds support for the Tegra2x's display peripheral. This
>>> supports the LCD display on Seaboard and we use this to enable console
>>> output in U-Boot on the LCD.
> ...
>> 2) The display works fine for cold boot, or hitting the physical reset
>> button, but when I execute "reset" at the U-Boot prompt, or "reboot"
>> within Linux, the display is messed up; it looks like the LCD isn't able
>> to sync to the timings sent by the display controller or something similar.
>>
>> Since this is slightly a corner case, it may be OK to fix it later (but
>> not much later; reboot is very useful to me.)
>
> A couple more points:
>
> BTW, I tried the same tests on Springbank which is basically Seaboard
> with a slightly different PCB layout, and didn't see this issue. That
> leads me to suspect some timing issue interacting with the panel, which
> I believe is different albeit theoretically compatible
> resolution/scan-timing wise.
OK. I wonder the panel does not get reset properly on Seaboard?
>
> Second, I first applied Tom's Tegra30 patches and tested those, then
> applied your LCD series. The LCD series as-is breaks compilation of the
> Tegra30 support. I have no idea which order Tom might apply these in,
> but this is a heads-up there will be conflicts and one needs to be
> rebased on top of the other.
OK, let's see what Tom wants to do on that one.
Regards,
Simon
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard
2012-10-08 20:06 ` Simon Glass
@ 2012-10-08 20:26 ` Tom Warren
2012-10-08 21:30 ` Stephen Warren
1 sibling, 0 replies; 40+ messages in thread
From: Tom Warren @ 2012-10-08 20:26 UTC (permalink / raw)
To: u-boot
Simon/Stephen,
> -----Original Message-----
> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
> Sent: Monday, October 08, 2012 1:06 PM
> To: Stephen Warren
> Cc: U-Boot Mailing List; Tom Warren
> Subject: Re: [PATCH v4 0/16] tegra: Add display driver and LCD support for
> Seaboard
>
> Hi Stephen,
>
> On Fri, Oct 5, 2012 at 12:51 PM, Stephen Warren <swarren@wwwdotorg.org>
> wrote:
> > On 10/03/2012 11:05 AM, Stephen Warren wrote:
> >> On 09/27/2012 06:44 PM, Simon Glass wrote:
> >>> This series adds support for the Tegra2x's display peripheral. This
> >>> supports the LCD display on Seaboard and we use this to enable
> >>> console output in U-Boot on the LCD.
> > ...
> >> 2) The display works fine for cold boot, or hitting the physical
> >> reset button, but when I execute "reset" at the U-Boot prompt, or
> "reboot"
> >> within Linux, the display is messed up; it looks like the LCD isn't
> >> able to sync to the timings sent by the display controller or something
> similar.
> >>
> >> Since this is slightly a corner case, it may be OK to fix it later
> >> (but not much later; reboot is very useful to me.)
> >
> > A couple more points:
> >
> > BTW, I tried the same tests on Springbank which is basically Seaboard
> > with a slightly different PCB layout, and didn't see this issue. That
> > leads me to suspect some timing issue interacting with the panel,
> > which I believe is different albeit theoretically compatible
> > resolution/scan-timing wise.
>
> OK. I wonder the panel does not get reset properly on Seaboard?
>
> >
> > Second, I first applied Tom's Tegra30 patches and tested those, then
> > applied your LCD series. The LCD series as-is breaks compilation of
> > the
> > Tegra30 support. I have no idea which order Tom might apply these in,
> > but this is a heads-up there will be conflicts and one needs to be
> > rebased on top of the other.
>
> OK, let's see what Tom wants to do on that one.
I'll have to wait to address this until I get back from HQ (next week, most likely).
Thanks,
Tom
>
> Regards,
> Simon
--
nvpublic
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard
2012-10-08 20:06 ` Simon Glass
2012-10-08 20:26 ` Tom Warren
@ 2012-10-08 21:30 ` Stephen Warren
2012-10-08 21:50 ` Simon Glass
1 sibling, 1 reply; 40+ messages in thread
From: Stephen Warren @ 2012-10-08 21:30 UTC (permalink / raw)
To: u-boot
On 10/08/2012 02:06 PM, Simon Glass wrote:
> Hi Stephen,
>
> On Fri, Oct 5, 2012 at 12:51 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 10/03/2012 11:05 AM, Stephen Warren wrote:
>>> On 09/27/2012 06:44 PM, Simon Glass wrote:
>>>> This series adds support for the Tegra2x's display peripheral. This
>>>> supports the LCD display on Seaboard and we use this to enable console
>>>> output in U-Boot on the LCD.
>> ...
>>> 2) The display works fine for cold boot, or hitting the physical reset
>>> button, but when I execute "reset" at the U-Boot prompt, or "reboot"
>>> within Linux, the display is messed up; it looks like the LCD isn't able
>>> to sync to the timings sent by the display controller or something similar.
>>>
>>> Since this is slightly a corner case, it may be OK to fix it later (but
>>> not much later; reboot is very useful to me.)
>>
>> A couple more points:
>>
>> BTW, I tried the same tests on Springbank which is basically Seaboard
>> with a slightly different PCB layout, and didn't see this issue. That
>> leads me to suspect some timing issue interacting with the panel, which
>> I believe is different albeit theoretically compatible
>> resolution/scan-timing wise.
>
> OK. I wonder the panel does not get reset properly on Seaboard?
I looked at the panel spec for the panels on the two boards. Both of
them specify that when vdd_pnl is dropped to zero, you must wait at
least 400mS before raising it again. Evidently the Seaboard panel
actually cares about this, yet the Springbank panel seems to be more
flexible than the specification. So, modifying
drivers/video/tegra.c:handle_stage() case STAGE_START to:
if (fdt_gpio_isvalid(&config.panel_vdd)) {
udelay(400000);
gpio_direction_output(config.panel_vdd.gpio, 1);
}
... appears to solve the problem; I can run "reset" in U-Boot many many
times without any issue after that change.
I guess this means that the nvidia,panel-timings DT property needs a
pre-delay entry for STAGE_START, or something like that?
Also, I wondered if we shouldn't explicitly do:
gpio_direction_output(config.panel_vdd.gpio, 0);
udelay(400000);
gpio_direction_output(config.panel_vdd.gpio, 1);
... although that doesn't make a difference; the particular GPIO used on
Seaboard appears to default to 0. I'm not sure that all GPIOs are
guaranteed to though.
Slightly related, I notice that handle_stage() always executes:
timer_next = timer_get_us() + config.panel_timings[stage] * 1000;
However, that function is called for stage==0..4 (or perhaps 0..5 given
the set of case statements it supports, but not looking at the code at
the call site), yet there are only entries 0..3 in that array; there's
an overrun there.
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard
2012-10-08 21:30 ` Stephen Warren
@ 2012-10-08 21:50 ` Simon Glass
2012-10-08 22:38 ` Stephen Warren
0 siblings, 1 reply; 40+ messages in thread
From: Simon Glass @ 2012-10-08 21:50 UTC (permalink / raw)
To: u-boot
Hi Stephen,
On Mon, Oct 8, 2012 at 2:30 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 10/08/2012 02:06 PM, Simon Glass wrote:
>> Hi Stephen,
>>
>> On Fri, Oct 5, 2012 at 12:51 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>> On 10/03/2012 11:05 AM, Stephen Warren wrote:
>>>> On 09/27/2012 06:44 PM, Simon Glass wrote:
>>>>> This series adds support for the Tegra2x's display peripheral. This
>>>>> supports the LCD display on Seaboard and we use this to enable console
>>>>> output in U-Boot on the LCD.
>>> ...
>>>> 2) The display works fine for cold boot, or hitting the physical reset
>>>> button, but when I execute "reset" at the U-Boot prompt, or "reboot"
>>>> within Linux, the display is messed up; it looks like the LCD isn't able
>>>> to sync to the timings sent by the display controller or something similar.
>>>>
>>>> Since this is slightly a corner case, it may be OK to fix it later (but
>>>> not much later; reboot is very useful to me.)
>>>
>>> A couple more points:
>>>
>>> BTW, I tried the same tests on Springbank which is basically Seaboard
>>> with a slightly different PCB layout, and didn't see this issue. That
>>> leads me to suspect some timing issue interacting with the panel, which
>>> I believe is different albeit theoretically compatible
>>> resolution/scan-timing wise.
>>
>> OK. I wonder the panel does not get reset properly on Seaboard?
>
> I looked at the panel spec for the panels on the two boards. Both of
> them specify that when vdd_pnl is dropped to zero, you must wait at
> least 400mS before raising it again. Evidently the Seaboard panel
> actually cares about this, yet the Springbank panel seems to be more
> flexible than the specification. So, modifying
> drivers/video/tegra.c:handle_stage() case STAGE_START to:
>
> if (fdt_gpio_isvalid(&config.panel_vdd)) {
> udelay(400000);
> gpio_direction_output(config.panel_vdd.gpio, 1);
> }
>
> ... appears to solve the problem; I can run "reset" in U-Boot many many
> times without any issue after that change.
>
> I guess this means that the nvidia,panel-timings DT property needs a
> pre-delay entry for STAGE_START, or something like that?
>
> Also, I wondered if we shouldn't explicitly do:
>
> gpio_direction_output(config.panel_vdd.gpio, 0);
> udelay(400000);
> gpio_direction_output(config.panel_vdd.gpio, 1);
>
> ... although that doesn't make a difference; the particular GPIO used on
> Seaboard appears to default to 0. I'm not sure that all GPIOs are
> guaranteed to though.
So reset is causing the line to go low? OK, there's probably nothing
we can do here except wait for 400ms. Is there any way to detect this
condition? Adding 400ms is quite a big jump in boot time.
>
> Slightly related, I notice that handle_stage() always executes:
>
> timer_next = timer_get_us() + config.panel_timings[stage] * 1000;
>
> However, that function is called for stage==0..4 (or perhaps 0..5 given
> the set of case statements it supports, but not looking at the code at
> the call site), yet there are only entries 0..3 in that array; there's
> an overrun there.
I will add a check there,
Regards,
Simon
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard
2012-10-08 21:50 ` Simon Glass
@ 2012-10-08 22:38 ` Stephen Warren
0 siblings, 0 replies; 40+ messages in thread
From: Stephen Warren @ 2012-10-08 22:38 UTC (permalink / raw)
To: u-boot
On 10/08/2012 03:50 PM, Simon Glass wrote:
> Hi Stephen,
>
> On Mon, Oct 8, 2012 at 2:30 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 10/08/2012 02:06 PM, Simon Glass wrote:
>>> Hi Stephen,
>>>
>>> On Fri, Oct 5, 2012 at 12:51 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>>> On 10/03/2012 11:05 AM, Stephen Warren wrote:
>>>>> On 09/27/2012 06:44 PM, Simon Glass wrote:
>>>>>> This series adds support for the Tegra2x's display peripheral. This
>>>>>> supports the LCD display on Seaboard and we use this to enable console
>>>>>> output in U-Boot on the LCD.
>>>> ...
>>>>> 2) The display works fine for cold boot, or hitting the physical reset
>>>>> button, but when I execute "reset" at the U-Boot prompt, or "reboot"
>>>>> within Linux, the display is messed up; it looks like the LCD isn't able
>>>>> to sync to the timings sent by the display controller or something similar.
>>>>>
>>>>> Since this is slightly a corner case, it may be OK to fix it later (but
>>>>> not much later; reboot is very useful to me.)
>>>>
>>>> A couple more points:
>>>>
>>>> BTW, I tried the same tests on Springbank which is basically Seaboard
>>>> with a slightly different PCB layout, and didn't see this issue. That
>>>> leads me to suspect some timing issue interacting with the panel, which
>>>> I believe is different albeit theoretically compatible
>>>> resolution/scan-timing wise.
>>>
>>> OK. I wonder the panel does not get reset properly on Seaboard?
>>
>> I looked at the panel spec for the panels on the two boards. Both of
>> them specify that when vdd_pnl is dropped to zero, you must wait at
>> least 400mS before raising it again. Evidently the Seaboard panel
>> actually cares about this, yet the Springbank panel seems to be more
>> flexible than the specification. So, modifying
>> drivers/video/tegra.c:handle_stage() case STAGE_START to:
>>
>> if (fdt_gpio_isvalid(&config.panel_vdd)) {
>> udelay(400000);
>> gpio_direction_output(config.panel_vdd.gpio, 1);
>> }
>>
>> ... appears to solve the problem; I can run "reset" in U-Boot many many
>> times without any issue after that change.
>>
>> I guess this means that the nvidia,panel-timings DT property needs a
>> pre-delay entry for STAGE_START, or something like that?
>>
>> Also, I wondered if we shouldn't explicitly do:
>>
>> gpio_direction_output(config.panel_vdd.gpio, 0);
>> udelay(400000);
>> gpio_direction_output(config.panel_vdd.gpio, 1);
>>
>> ... although that doesn't make a difference; the particular GPIO used on
>> Seaboard appears to default to 0. I'm not sure that all GPIOs are
>> guaranteed to though.
>
> So reset is causing the line to go low?
I would imagine so.
> OK, there's probably nothing
> we can do here except wait for 400ms. Is there any way to detect this
> condition? Adding 400ms is quite a big jump in boot time.
I think the PMIC has a "power-on/reset reason" register. However, I
don't know exactly how long the minimum time between powering off and
immediately powering on is; it's plausible it isn't safe to skip some
waiting even in that case.
^ permalink raw reply [flat|nested] 40+ messages in thread
* [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard
2012-09-28 0:44 [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
` (16 preceding siblings ...)
2012-10-03 17:05 ` [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard Stephen Warren
@ 2012-10-03 23:00 ` Stephen Warren
2012-10-04 0:19 ` Simon Glass
17 siblings, 1 reply; 40+ messages in thread
From: Stephen Warren @ 2012-10-03 23:00 UTC (permalink / raw)
To: u-boot
On 09/27/2012 06:44 PM, Simon Glass wrote:
> This series adds support for the Tegra2x's display peripheral. This
> supports the LCD display on Seaboard and we use this to enable console
> output in U-Boot on the LCD.
Aside from the comments I made just now, the whole series,
Acked-by: Stephen Warren <swarren@nvidia.com>
At this stage, I figure it's more important to get this feature checked
in and enabled than anything else. For this version of the series, I
only briefly scanned the patches, and mostly concentrated on the device
tree files themselves. They're obviously close enough to the proposed
kernel bindings that we should be able to migrate them easily enough to
the finalized bindings when they're available.
^ permalink raw reply [flat|nested] 40+ messages in thread* [U-Boot] [PATCH v4 0/16] tegra: Add display driver and LCD support for Seaboard
2012-10-03 23:00 ` Stephen Warren
@ 2012-10-04 0:19 ` Simon Glass
0 siblings, 0 replies; 40+ messages in thread
From: Simon Glass @ 2012-10-04 0:19 UTC (permalink / raw)
To: u-boot
Hi Stephen,
On Wed, Oct 3, 2012 at 4:00 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 09/27/2012 06:44 PM, Simon Glass wrote:
>> This series adds support for the Tegra2x's display peripheral. This
>> supports the LCD display on Seaboard and we use this to enable console
>> output in U-Boot on the LCD.
>
> Aside from the comments I made just now, the whole series,
>
> Acked-by: Stephen Warren <swarren@nvidia.com>
>
> At this stage, I figure it's more important to get this feature checked
> in and enabled than anything else. For this version of the series, I
> only briefly scanned the patches, and mostly concentrated on the device
> tree files themselves. They're obviously close enough to the proposed
> kernel bindings that we should be able to migrate them easily enough to
> the finalized bindings when they're available.
Yes I think so. Thanks.
I will address the comments and send out a new series likely Monday.
Regards,
Simon
^ permalink raw reply [flat|nested] 40+ messages in thread