From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fdt: Add warning about CONFIG_OF_EMBED
Date: Wed, 5 Dec 2018 17:08:53 +0100 [thread overview]
Message-ID: <18c1081c-6bd2-d69a-cd44-60486ee1fcde@gmail.com> (raw)
In-Reply-To: <CAPnjgZ0eTry47LhKhxnHKHuGLgh3Btac310hTjUUO1jVXbeZ0A@mail.gmail.com>
Hi Simon,
Am 05.12.2018 um 16:57 schrieb Simon Glass:
> Hi Simon,
>
> On Wed, 5 Dec 2018 at 07:22, Simon Goldschmidt
> <simon.k.r.goldschmidt@gmail.com> wrote:
>>
>> Am 05.12.2018 um 14:57 schrieb Simon Glass:
>>> This option has crept into use with some boards. Add a warning to try to
>>> prevent this.
>>>
>>> As an example:
>>> https://lists.denx.de/pipermail/u-boot/2017-September/304966.html
>>
>> We have just discussed this in another thread. There seem to be ~109
>> defconfigs in the tree that enable OF_EMBED.
>>
>> I doubt all of them do this for fun, so we might want to collect the
>> reasons they do so. I do know two:
>>
>> - socfpga_stratix10_defconfig needs this to get a correct u-boot-spl.hex
>
> Let's fix that then.
>
>> - I would need it to ensure in SPL, the DTB is in one block with the
>> other readonly parts. Without OF_EMBED, we have '.text', '.bss', DT.
>
> Similarly, let's change that.
>
> CONFIG_OF_EMBED should not be a work-around for missing features that we need.
I'm with you there. Don't get me wrong, I don't want to argue to use
OF_EMBED, just wanted to list the use cases I know so that we only fix
them once instead of letting everyone fixing them on their own.
Regards,
Simon
next prev parent reply other threads:[~2018-12-05 16:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 13:57 [U-Boot] [PATCH] fdt: Add warning about CONFIG_OF_EMBED Simon Glass
2018-12-05 14:22 ` Simon Goldschmidt
2018-12-05 15:57 ` Simon Glass
2018-12-05 16:08 ` Simon Goldschmidt [this message]
2018-12-05 16:32 ` Tom Rini
2018-12-19 10:11 ` Lukasz Majewski
2018-12-27 23:29 ` Simon Glass
2018-12-31 11:26 ` Lukasz Majewski
2018-12-31 16:23 ` Simon Glass
2018-12-06 1:32 ` Tom Rini
2018-12-13 0:47 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18c1081c-6bd2-d69a-cd44-60486ee1fcde@gmail.com \
--to=simon.k.r.goldschmidt@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox