From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] mx35: Clean up lowlevel_init
Date: Tue, 21 Aug 2012 14:58:44 +0200 (CEST) [thread overview]
Message-ID: <1908084914.2642035.1345553924445.JavaMail.root@advansee.com> (raw)
In-Reply-To: <5033250C.1050400@denx.de>
Hi Stefano, Fabio,
> On 20/08/2012 22:25, Fabio Estevam wrote:
> > Hi Stefano,
> >
> > On Mon, Aug 20, 2012 at 4:42 PM, stefano babic <sbabic@denx.de>
> > wrote:
> >
> >> With the flea3 I have made some clean-up, making the
> >> lowLevel_init.S
> >> essential. Same changes were not reported back to the mx35pdk. I
> >> am
> >> going also to put in a common place the functions to setup the DDR
> >> controller ( board_setup_sdram_bank() in the flea3 directory).
> >> This
> >> should allow to factorize some other code, reducing the
> >> lowlevel_init.S.
> >
> > Maybe even better would be to convert the init from lowlevel_init.S
> > into C code, like was done on mx31.
> >
> > It is much easier to debug/maintain C code then assemby.
>
> Yes, agree.
>
> Regards,
> Stefano
Yes, but we must also not forget the size constraints for SPLs.
Best regards,
Beno?t
next prev parent reply other threads:[~2012-08-21 12:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 21:03 [U-Boot] [PATCH 1/3] mx35: Remove duplicate GPIO3_BASE_ADDR Benoît Thébaudeau
2012-08-14 21:03 ` [U-Boot] [PATCH 2/3] mx35: Define MAX and AIPS registers Benoît Thébaudeau
2012-09-30 12:56 ` Stefano Babic
2012-08-14 21:04 ` [U-Boot] [PATCH 3/3] mx35: Clean up lowlevel_init Benoît Thébaudeau
2012-08-20 12:09 ` Benoît Thébaudeau
2012-08-20 19:42 ` stefano babic
2012-08-20 19:54 ` [U-Boot] [PATCH v2 " Benoît Thébaudeau
2012-10-10 11:26 ` Stefano Babic
2012-08-20 20:25 ` [U-Boot] [PATCH " Fabio Estevam
2012-08-21 6:05 ` Stefano Babic
2012-08-21 12:58 ` Benoît Thébaudeau [this message]
2012-08-17 19:57 ` [U-Boot] [PATCH 1/3] mx35: Remove duplicate GPIO3_BASE_ADDR Stefano Babic
2012-08-20 7:57 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1908084914.2642035.1345553924445.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox