From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= <benoit.thebaudeau@advansee.com>
Date: Fri, 20 Jul 2012 01:17:31 +0200 (CEST)
Subject: [U-Boot] [PATCH 7/7] FAT: Make it possible to read from any
 file position
In-Reply-To: <201207191844.53559.vapier@gentoo.org>
Message-ID: <1923456823.295434.1342739851645.JavaMail.root@advansee.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Friday 20 July 2012 00:44:52 Mike Frysinger wrote:
> On Thursday 19 July 2012 18:03:06 Beno?t Th?baudeau wrote:
> > --- u-boot-66714b1.orig/fs/fat/fat.c
> > +++ u-boot-66714b1/fs/fat/fat.c
> > 
> > +__u8 get_contents_vfatname_block[MAX_CLUSTSIZE]
> > +	__aligned(ARCH_DMA_MINALIGN);
> 
> is there any reason for this to be exported ?  could you mark it
> static ?

I'll do that. There are probably other variables in fat.c missing static, so
I'll do a dedicated patch before this series. That will shift the patch numbers.
How should I repost the new version of the series? Should I keep the message ID
of each patch even if the numbering changes, or should I post a v2 completely
separately from v1?

> >  static long
> > -get_contents (fsdata *mydata, dir_entry *dentptr, __u8 *buffer,
> > -	      unsigned long maxsize)
> > +get_contents (fsdata *mydata, dir_entry *dentptr, unsigned long
> > pos,
> 
> delete the space before the "("
> 
> >  long
> > -do_fat_read (const char *filename, void *buffer, unsigned long
> > maxsize,
> > -	     int dols)
> > +do_fat_read_at (const char *filename, unsigned long pos, void
> > *buffer,
> 
> delete the space before the "("
> 
> > +long
> > +do_fat_read (const char *filename, void *buffer, unsigned long
> > maxsize,
> 
> no spaces before that "("

I'll add a cosmetic patch for that in a prequel.

Regards,
Beno?t