From: Heiko Stuebner <heiko@sntech.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 11/12] rockchip: add px30 architecture core
Date: Sun, 10 Nov 2019 15:46:44 +0100 [thread overview]
Message-ID: <1952482.mV1BMFkout@phil> (raw)
In-Reply-To: <6489606b-51c5-72d4-b7e9-023b555a4b88@rock-chips.com>
Hi Kever,
Am Sonntag, 10. November 2019, 15:13:52 CET schrieb Kever Yang:
> On 2019/10/25 下午3:47, Heiko Stübner wrote:
> > Am Freitag, 25. Oktober 2019, 04:49:54 CEST schrieb Kever Yang:
> >> On 2019/10/25 上午7:28, Heiko Stuebner wrote:
> >>> From: Kever Yang <kever.yang@rock-chips.com>
> >>>
> >>> Add core architecture code to support the px30 soc.
> >>> This includes a separate tpl board file due to very limited
> >>> sram size as well as a non-dm sdram driver, as this also has
> >>> to fit into the tiny sram.
> >>
> >> Could you leave the sram code and make it possible to use the common
> >> sdram code
> >>
> >> I have send out:
> >>
> >> https://patchwork.ozlabs.org/cover/1183700/
> >>
> >> The sram driver should goes to driver/ram folder instead of arch/arm folder.
> > That won't work. For the px30, the ddr-init portion will need to stay in
> > arch-rockchip/px30 I'm afraid.
> >
> > To compile things in drivers/ram you need to have TPL_RAM enabled
> > which in turn depends on TPL_DM which in turn makes the tpl size
> > to big.
>
>
> Can we just update the TPL_RAM not depends on DM, and leave the code in
> the driver/ram folder,
>
> and let the code itself to decide if use DM or not? We do use
> CONFIG_TPL_BUILD and CONFIG_SPL_BUILD
>
> for dram driver code to make choice.
>
> The core implement of PX30 DRAM driver is shared with other SoCs, it
> should be at the same place with
> other SoCs.
CONFIG_RAM (the core symbol) already depends on CONFIG_DM, so changing
this will cause a lot of churn for us but also other drivers living there.
And thus probably a long and detailed discussion.
And while this will be worthwhile in the long run (also for the rk3036
and future socs), can we maybe do that in 2 steps?
Aka doing your ddr-series and px30-support and then in a second step adapt
drivers/ram as needed and move rk3036 + px30 over there?
That way we don't get stalled until everybody is happy with a solution.
Thanks
Heiko
next prev parent reply other threads:[~2019-11-10 14:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 23:27 [U-Boot] [PATCH 00/12] rockchip: add support for px30 Heiko Stuebner
2019-10-24 23:27 ` [U-Boot] [PATCH 01/12] spl: separate SPL_FRAMEWORK config for spl and tpl Heiko Stuebner
2019-10-25 1:55 ` Kever Yang
2019-10-24 23:27 ` [U-Boot] [PATCH 02/12] rockchip: add core px30 headers Heiko Stuebner
2019-10-25 2:04 ` Kever Yang
2019-10-24 23:27 ` [U-Boot] [PATCH 03/12] pinctrl: rockchip: add px30 pinctrl driver Heiko Stuebner
2019-10-25 2:07 ` Kever Yang
2019-10-24 23:27 ` [U-Boot] [PATCH 04/12] rockchip: clk: add px30 clock driver Heiko Stuebner
2019-10-24 23:27 ` [U-Boot] [PATCH 05/12] net: gmac_rockchip: add support for px30 Heiko Stuebner
2019-10-25 2:09 ` Kever Yang
2019-10-24 23:27 ` [U-Boot] [PATCH 06/12] rockchip: mkimage: " Heiko Stuebner
2019-10-25 2:09 ` Kever Yang
2019-10-24 23:27 ` [U-Boot] [PATCH 07/12] misc: add driver for the Rockchip otp controller Heiko Stuebner
2019-10-25 2:10 ` Kever Yang
2019-10-24 23:27 ` [U-Boot] [PATCH 08/12] rockchip: misc: read cpuid either from efuse or otp Heiko Stuebner
2019-10-25 2:11 ` Kever Yang
2019-10-24 23:28 ` [U-Boot] [PATCH 09/12] rockchip: ram: add dm-based sdram driver Heiko Stuebner
2019-10-24 23:28 ` [U-Boot] [PATCH 10/12] rockchip: add px30 devicetrees Heiko Stuebner
2019-10-25 2:39 ` Kever Yang
2019-10-24 23:28 ` [U-Boot] [PATCH 11/12] rockchip: add px30 architecture core Heiko Stuebner
2019-10-25 2:49 ` Kever Yang
2019-10-25 7:47 ` Heiko Stübner
2019-11-10 14:13 ` Kever Yang
2019-11-10 14:46 ` Heiko Stuebner [this message]
2019-10-24 23:28 ` [U-Boot] [PATCH 12/12] rockchip: add px30-evb board Heiko Stuebner
2019-10-25 2:51 ` Kever Yang
2019-10-25 1:44 ` [U-Boot] [PATCH 00/12] rockchip: add support for px30 Kever Yang
2019-11-18 2:57 ` Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1952482.mV1BMFkout@phil \
--to=heiko@sntech.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox