From: Ajay Bhargav <ajay.bhargav@einfochips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] USB: Armada100: Add UTMI PHY interface driver
Date: Fri, 27 Jan 2012 12:31:54 +0530 (IST) [thread overview]
Message-ID: <1978582266.117750.1327647714615.JavaMail.root@ahm.einfochips.com> (raw)
In-Reply-To: <1380796084.117744.1327647617482.JavaMail.root@ahm.einfochips.com>
----- "Prafulla Wadaskar" <prafulla@marvell.com> wrote:
> > +
> > +/* MPMU Clocks */
> > +#define MPMU_EN_ALL_CLKS 0x1EFFFF
>
> Turning on all clocks is not logical to enable this support, only
> relevant clock necessary for this components SHOULD BE enabled.
>
> Enabling clocks for unused peripherals/components may result in
> unnecessarily extra power consumption
>
> Otherwise ack for rest of the patch
>
> Regards..
> Prafulla . . .
>
I followed programming guidlines as per Armada_16x software manual.
section: 20.4.3.1
snip of pseudo code from Programming guidlines section:
[...snip...]
print "******main PMU turn on all clocks\n"
set val *(unsigned long *)PMUM_ACGR=0x001EFFFF
print "******PMUap USBCLK Reset Control\n"
set val *(unsigned long *)PMUA_USB_CLK_RES_CTRL=0x1B
print "******UTMI ID\n"
eval /hex *(unsigned long *)UTMI_REVISION
[...snip...]
There is nothing mentioned in specific which clock is used/required by USB host controller.
Regards,
Ajay Bhargav
next parent reply other threads:[~2012-01-27 7:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1380796084.117744.1327647617482.JavaMail.root@ahm.einfochips.com>
2012-01-27 7:01 ` Ajay Bhargav [this message]
2012-01-28 23:24 ` [U-Boot] [PATCH 1/3] USB: Armada100: Add UTMI PHY interface driver Wolfgang Denk
2012-01-30 6:08 ` Ajay Bhargav
2012-01-25 12:19 Ajay Bhargav
2012-01-26 17:59 ` Prafulla Wadaskar
2012-02-26 23:12 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1978582266.117750.1327647714615.JavaMail.root@ahm.einfochips.com \
--to=ajay.bhargav@einfochips.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox