From: Becky Bruce <beckyb@kernel.crashing.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 08/13] SBC8560: #define CONFIG_SYS_LBC_NO_SDRAM_INIT
Date: Fri, 3 Dec 2010 14:54:23 -0600 [thread overview]
Message-ID: <1E61DA01-5F52-49E5-95AF-EC1961815CD3@kernel.crashing.org> (raw)
In-Reply-To: <1291392546.20072.584.camel@petert>
On Dec 2, 2010, at 8:26 PM, Peter Tyser wrote:
> Hi Becky,
>
>> +/* Common ddr init for non-corenet fsl 85xx platforms */
>> +#ifndef CONFIG_FSL_CORENET
>> +phys_size_t initdram(int board_type)
>> +{
>> + phys_size_t dram_size = 0;
>> +
>> + puts("Initializing\n");
>
> Any chance we can remove the puts() above? "DRAM:" is always printed
> out directly before initdram is called, so I don't think the
> "Initializing" message adds much benefit and slightly dirties the
> output. For reference:
That's fine with me.... does anybody object to this? It's certainly easy to change this now.
-Becky
>
> I2C: ready
> DRAM: Initializing
> DDR: 2 GiB (DDR2, 64-bit, CL=5, ECC on)
> FLASH: Executed from FLASH1
> FLASH: 256 MiB
>
> vs
>
> I2C: ready
> DRAM: DDR: 2 GiB (DDR2, 64-bit, CL=5, ECC on)
> FLASH: Executed from FLASH1
> FLASH: 256 MiB
>
> Otherwise it looked good. I tested on the xpedite5170 that was a corner
> case, and the xpedite5370 (mpc8572-based).
>
> Acked-by: Peter Tyser <ptyser@xes-inc.com>
> Tested-by: Peter Tyser <ptyser@xes-inc.com>
next prev parent reply other threads:[~2010-12-03 20:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 23:45 [U-Boot] [PATCH 00/13] Go to common initdram() on 85xx-based boards Becky Bruce
2010-12-02 23:45 ` [U-Boot] [PATCH 01/13] mpc8540eval: Split initdram() into initdram() and sdram_init() Becky Bruce
2010-12-02 23:45 ` [U-Boot] [PATCH 02/13] tqm85xx: create fixed_sdram() to do sdram setup Becky Bruce
2010-12-02 23:45 ` [U-Boot] [PATCH 03/13] mpc85xx/tlb.c: Allow platforms to specify wimge bits Becky Bruce
2010-12-02 23:45 ` [U-Boot] [PATCH 04/13] socrates: rename sdram_setup fixed_sdram() Becky Bruce
2010-12-02 23:45 ` [U-Boot] [PATCH 05/13] mpc8569mds: Remove unnecessary CONFIG_SYS_LBC_SDRAM_BASE definition Becky Bruce
2010-12-02 23:45 ` [U-Boot] [PATCH 06/13] PM854: rename CONFIG_SYS_LBC_SDRAM_BASE CONFIG_SYS_LBC_BASE Becky Bruce
2010-12-02 23:45 ` [U-Boot] [PATCH 07/13] PM856: Rename " Becky Bruce
2010-12-02 23:45 ` [U-Boot] [PATCH 08/13] SBC8560: #define CONFIG_SYS_LBC_NO_SDRAM_INIT Becky Bruce
2010-12-02 23:45 ` [U-Boot] [PATCH 09/13] stxgp3: " Becky Bruce
2010-12-02 23:45 ` [U-Boot] [PATCH 10/13] SBC8540: " Becky Bruce
2010-12-02 23:45 ` [U-Boot] [PATCH 11/13] MPC8568/MPC8569: Remove CONFIG_DDR_DLL define Becky Bruce
2010-12-02 23:45 ` [U-Boot] [PATCH 12/13] mpc85xx boards: initdram() cleanup/bugfix Becky Bruce
2010-12-02 23:45 ` [U-Boot] [PATCH 13/13] 85xx boards: Rename CONFIG_DDR_DLL to CONFIG_SYS_FSL_ERRATUM_DDR_MSYNC_IN Becky Bruce
2010-12-03 16:09 ` [U-Boot] [PATCH 12/13] mpc85xx boards: initdram() cleanup/bugfix Peter Tyser
2010-12-03 20:54 ` Becky Bruce [this message]
2010-12-03 21:22 ` [U-Boot] [PATCH 08/13] SBC8560: #define CONFIG_SYS_LBC_NO_SDRAM_INIT Peter Tyser
2010-12-03 2:26 ` Timur Tabi
2010-12-03 20:44 ` Becky Bruce
2010-12-03 21:48 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1E61DA01-5F52-49E5-95AF-EC1961815CD3@kernel.crashing.org \
--to=beckyb@kernel.crashing.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox