public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: David Andrey <David.Andrey@netmodule.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v2] PHY: micrel.c: add support for KSZ9031
Date: Mon, 25 Mar 2013 21:39:12 +0100	[thread overview]
Message-ID: <1UKEBx-0000x3-4D@wolf.netmodule.com> (raw)
In-Reply-To: <51388BA2.70604@denx.de>

Hi Stefan,

> Why don't you just change the mask to support both PHY's with one
struct here? Something like this:
>
>  static struct phy_driver ksz9021_driver = {
> -	.name = "Micrel ksz9021",
> +	.name = "Micrel ksz90x1",
>  	.uid  = 0x221610,
> -	.mask = 0xfffff0,
> +	.mask = 0xffffc0,
>
> This would be much "simpler". Does it work for you?

Well, because the ksz9031 works well with the generic phy config
function. See ksz9021_config vs genphy_config

Regards
David

  reply	other threads:[~2013-03-25 20:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-06 21:18 [U-Boot] [Patch v2] PHY: micrel.c: add support for KSZ9031 David Andrey
2013-03-07 12:44 ` Stefan Roese
2013-03-25 20:39   ` David Andrey [this message]
2013-04-02 12:04     ` Stefan Roese
2013-06-18 15:31 ` Fabio Estevam
2013-06-22 12:18   ` Joe Hershberger
2013-07-08 16:06 ` Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1UKEBx-0000x3-4D@wolf.netmodule.com \
    --to=david.andrey@netmodule.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox