From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Andrey Date: Mon, 25 Mar 2013 21:39:12 +0100 Subject: [U-Boot] [Patch v2] PHY: micrel.c: add support for KSZ9031 In-Reply-To: <51388BA2.70604@denx.de> References: <1360185517-9317-1-git-send-email-david.andrey@netmodule.com> <51388BA2.70604@denx.de> Message-ID: <1UKEBx-0000x3-4D@wolf.netmodule.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefan, > Why don't you just change the mask to support both PHY's with one struct here? Something like this: > > static struct phy_driver ksz9021_driver = { > - .name = "Micrel ksz9021", > + .name = "Micrel ksz90x1", > .uid = 0x221610, > - .mask = 0xfffff0, > + .mask = 0xffffc0, > > This would be much "simpler". Does it work for you? Well, because the ksz9031 works well with the generic phy config function. See ksz9021_config vs genphy_config Regards David