From: Andre Heider <a.heider@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH] ARM: Distro boot: document the need for fdtfile variable to be set
Date: Thu, 3 Sep 2020 19:50:32 +0200 [thread overview]
Message-ID: <1ab3610d-dd3b-ee34-d7a2-a8b2cb36b5d3@gmail.com> (raw)
In-Reply-To: <20200903164034.115210-1-dennis@ausil.us>
Hi Dennis,
On 03/09/2020 18:40, Dennis Gilmore wrote:
> When testing builds provided in https://github.com/openwrt/openwrt/pull/3360
> I discovered that fdtfile was not set and as a result the firmware was not
> functional. So I am documenting what is needed.
>
> Signed-off-by: Dennis Gilmore <dennis@ausil.us>
>
> Cc: Atish Patra <atish.patra@wdc.com>
> Cc: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Cc: Vagrant Cascadian <vagrant@debian.org>
> Cc: Stephen Warren <swarren@nvidia.com>
> Cc: Karsten Merker <merker@debian.org>
> ---
> doc/README.distro | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/doc/README.distro b/doc/README.distro
> index 5076bebd18..3eb70aeb14 100644
> --- a/doc/README.distro
> +++ b/doc/README.distro
> @@ -224,6 +224,14 @@ fdt_addr_r:
>
> A size of 1MB for the FDT/DTB seems reasonable.
>
> +fdtfile:
> +
> + Mandatory. the name of the DTB file for the specific board for instance
> + the espressobin v5 board the value is "marvell/armada-3720-espressobin.dtb"
> + while on a clearfog pro it is "armada-388-clearfog-pro.dtb" in the case of
> + a board providing its firmware based DTB this value can be used to override
> + the DTB with a different DTB.
is that really supposed to include the vendor subdir on arm64?
If so, adding fdtfile like that would break booting debian using its
flash-image. It installs dtbs without that subdir into /boot:
/boot/dtbs/4.19.0-9-arm64/armada-3720-espressobin.dtb
But it already supports $fdtfile:
https://salsa.debian.org/installer-team/flash-kernel/-/blob/master/bootscript/arm64/bootscr.uboot-generic#L32
If I read that script correctly, it would fail to boot with
fdtfile=marvell/armada-3720-espressobin.dtb...
Regards,
Andre
next prev parent reply other threads:[~2020-09-03 17:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 16:40 [PATCH] ARM: Distro boot: document the need for fdtfile variable to be set Dennis Gilmore
2020-09-03 17:50 ` Andre Heider [this message]
2020-09-03 17:54 ` Tom Rini
2020-09-03 18:59 ` Vagrant Cascadian
2020-09-03 19:53 ` Andre Heider
2020-09-04 0:30 ` flash-kernel: Add vendor path for some arm64 machines Vagrant Cascadian
2020-09-03 19:15 ` [PATCH] ARM: Distro boot: document the need for fdtfile variable to be set Stephen Warren
2020-09-03 20:14 ` Dennis Gilmore
2020-09-03 20:24 ` Stephen Warren
2020-09-03 21:18 ` Dennis Gilmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ab3610d-dd3b-ee34-d7a2-a8b2cb36b5d3@gmail.com \
--to=a.heider@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox