From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61FC7C04A95 for ; Tue, 25 Oct 2022 09:33:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2464884D1F; Tue, 25 Oct 2022 11:33:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="Yl5eFD1v"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0582C84D21; Tue, 25 Oct 2022 11:33:14 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2041.outbound.protection.outlook.com [40.107.212.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3A6AB84D1E for ; Tue, 25 Oct 2022 11:33:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HcqhDa50gupxBLwOv5fdXQRXl30ebHWXdsIKzoohaOBd1vXq9k3uSw7CpO2XAPS6glV7FPA07lW9qLaKTC3Vw+CvpzXofXFnDjYjieWvXd31AnLCMsyBkEkniPD7JSm2qDG3RNp1VeXXh0OBRHB+XZXbqf/Ws5gdA4EhecCrbN2OE/hoLsVpen6kaRPYim+KYNXDK6QksO0lT/kExXw5syQB3obKitKPmFdX1+T6gckaPYAG/8Vk1PwGqbxJLgw+L1/dXhyQpet/ywDnKECAy6ocHObKcqf521NlxXWMaqnFMZ77m6AzdFzAn8mzVzUyAhootSiS5DJUfJ03PbAA8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=78wT2Cm9c+TIqVhiAiOiqTTUJHjNF3skjEKfIQit7C4=; b=RgSgeDZe1F6swO+ogxqgtsQqTzCRvr/9e2sLQLMBXN5V0ZpOzBgVyiC5XpLNDiYFow4u38yZa4YagGzvjb4KhQ9tu+YbVYbo3bQp/rhaPbTHU30ZGFXl8wWQtRQVt9IkKMXz9h9xY774u4bwnUX6MsBPJsRTIZKFLR/M/kvPCuVTiDesgl9GH37ylL6/qPcFlEvZ5DEvB9jH0p42TY0XyKKWpzAfFVf6zdydx2VMvmX3F0ZLPGSHBFKpiOpWM5CAbrhzpsxRITawXI320kObL0wPDS0J+CmCnqdq1TL552fk9x7gOA60VVerwiKGO9DLG4kAFV7QFfWBms0YcglLBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=78wT2Cm9c+TIqVhiAiOiqTTUJHjNF3skjEKfIQit7C4=; b=Yl5eFD1vpcFnpFSINhazXFLyo/1M2VtZcMzYOi781I6tAfpEb2O8ZfUjT5G9NqyMAMQjwwuW9H4t0QMBhw0W2zQyR855bAlfJ550XEOLjOnJb3M5a6VkkVNR0AdI64lbsMrD8d3aBe7ForsTC1pBcAPK8JztPd/6pkgx1XKENzo= Received: from DM6PR21CA0018.namprd21.prod.outlook.com (2603:10b6:5:174::28) by MW4PR12MB7262.namprd12.prod.outlook.com (2603:10b6:303:228::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Tue, 25 Oct 2022 09:33:08 +0000 Received: from DM6NAM11FT072.eop-nam11.prod.protection.outlook.com (2603:10b6:5:174:cafe::5d) by DM6PR21CA0018.outlook.office365.com (2603:10b6:5:174::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.8 via Frontend Transport; Tue, 25 Oct 2022 09:33:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT072.mail.protection.outlook.com (10.13.173.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5746.16 via Frontend Transport; Tue, 25 Oct 2022 09:33:07 +0000 Received: from [10.254.241.52] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct 2022 04:33:03 -0500 Message-ID: <1ae64c90-2fe7-2b1b-5554-511a3d014b2e@amd.com> Date: Tue, 25 Oct 2022 11:32:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 3/3] timer: xilinx-timer: use timer_conv_64() to fix timer wrap around Content-Language: en-US To: Ovidiu Panait , References: <20221012053656.1492457-1-ovpanait@gmail.com> <20221012053656.1492457-3-ovpanait@gmail.com> From: Michal Simek In-Reply-To: <20221012053656.1492457-3-ovpanait@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT072:EE_|MW4PR12MB7262:EE_ X-MS-Office365-Filtering-Correlation-Id: 111214f6-e5ad-48dc-ee51-08dab66bed03 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oFf7quCPxNUjKUezPy6RUwAlwwve14hgPA1Aq4olUAK+eYlNAPQ3e1pqP+2PE47QLPu6vrJyGAmyLCc7iQt5lvj7XKPER0aRf9m/deo4ESwCz9tUz8BO/ehlYbkZCq0pOYofZVfomtZb7E0ePUJ8GGZBNsvV1FcCfwHP3XKY6CAqeDiyIwOeGFyI0CAqWqNxG+WWGdCRJwvKdJ2tkMmK2zkAs94h4tYMHZX1iqJ++vEKulVe3U0FDWQM/q3R2xzgux8iHeeCd3vBrTJCSuOdJqUmk2XBwBDv1N86+6GJ0lx+10mo7NPCAnqxoFzHSOhmZYaTACDjkQuAaX9vlYJQ5GwS+bqVzgiER0Uu44mm0hXlXk0GDq0F0nf36dpK9/b2cnF0XKzLRSYceNEcbFIsYoryO4rBTvl3ptO3UHLAF5MdZkhTnvJrcPdoLp4xFhWKcZatJRrRHvLJCMR1HtY7CzciFK5BPtYHwm/hJbqpfMltZPAeDLlMQaypTHvqoVNG0k6VYjsBUWEDiNpKhCFAJ7CnkJ+SRO8OwiRxW+5r0A/QMkv7HMPF0uYrNbFmksHOvcU0XEg9UjooF0keyWbWqQ3YE66/L1V/pag7MGnRAFDyvgR566/UPogvjg/MZcBAQuiqx64TAx0r4MzLYdKVKO/D6aele38PNwuknTGwhz6Zdpz6/oYKmryb+FRSPVWsbjG5hrZPOmeEvKIvh/S21VJ5894X35J3dBtuAn4PHRNo+dMzicu6cTtRss8p5KwC4MhSoinyYZe/AqdW6xY34mjx8cUzSAcyQir3jRx5Acz/KT3pQpH3Li2cp2fpuiXx4lBx/9enqv4d/oP609AwhA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(396003)(39860400002)(346002)(376002)(136003)(451199015)(40470700004)(36840700001)(46966006)(36756003)(478600001)(82310400005)(86362001)(5660300002)(2616005)(83380400001)(356005)(81166007)(44832011)(70206006)(31696002)(53546011)(6666004)(70586007)(47076005)(8676002)(8936002)(41300700001)(426003)(31686004)(110136005)(26005)(16526019)(36860700001)(336012)(40460700003)(40480700001)(16576012)(2906002)(316002)(186003)(82740400003)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 09:33:07.9622 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 111214f6-e5ad-48dc-ee51-08dab66bed03 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT072.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7262 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 10/12/22 07:36, Ovidiu Panait wrote: > Current xilinx_timer_get_count() implementation does not take into account > the periodic 32-bit wrap arounds, as it directly returns the 32-bit counter > register value. The roll-overs cause problems in the upper timer layers, as > generic timer code expects an incrementing 64-bit value from get_count() to > work correctly. > > Add the missing 64-bit up-conversion to fix random hangs/delays in > __udelay(). > > Fixes: a36d86720f ("microblaze: Convert axi timer to DM driver") > Signed-off-by: Ovidiu Panait > --- > > drivers/timer/xilinx-timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/timer/xilinx-timer.c b/drivers/timer/xilinx-timer.c > index 75b4473b63..172fd9f929 100644 > --- a/drivers/timer/xilinx-timer.c > +++ b/drivers/timer/xilinx-timer.c > @@ -40,7 +40,7 @@ static u64 xilinx_timer_get_count(struct udevice *dev) > > regmap_read(priv->regs, TIMER_COUNTER_OFFSET, &value); > > - return value; > + return timer_conv_64(value); > } > > static int xilinx_timer_probe(struct udevice *dev) Applied all. M