From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 044A4C41535 for ; Fri, 22 Dec 2023 12:45:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 53D0486F64; Fri, 22 Dec 2023 13:45:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="K0QzbKh1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1E62886F64; Fri, 22 Dec 2023 13:45:00 +0100 (CET) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 94DF987861 for ; Fri, 22 Dec 2023 13:44:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=maz@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 3FACCCE21B6; Fri, 22 Dec 2023 12:44:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBE04C433C8; Fri, 22 Dec 2023 12:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703249092; bh=9sYbU0OSFi7d4vqKKiQ539yLpxofybmafVQYpghu628=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K0QzbKh1G+LMONumGgBZVw+NscUfW+OEBfgvMGDNF+zZw7ePBjqz8n6C7/spQH2tA Q0hbhILDH/Lp7w3WSUmZS6yt9q03tMyu3unsU2X9pN8pIotRuV0ZF3NvYZ9eEEYL8G oSVCcd90zBS1KmO3D4bSVtvlJ5ZNiGXbefo8UXm3+GHdd7YJRvzBJvqNhdRiSMQUbf juiImqJxHa0r16DnSNMibpQ9fcT7E42AxSlmHTmNKS1jUQ5talHIrb9jklf6Wo2aE0 HOsLrIFW5I+qLd41a8go2c6LCVEfJzUs26Q/hXRyuI2o8Q+5etOSH0lt44PV/ShQy3 IsxC1IsVEYsiA== Received: from disco-boy.misterjones.org ([217.182.43.188] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rGetV-006JDW-EJ; Fri, 22 Dec 2023 12:44:49 +0000 MIME-Version: 1.0 Date: Fri, 22 Dec 2023 12:44:49 +0000 From: Marc Zyngier To: "Ivan T. Ivanov" Cc: Matthias Brugger , Peter Robinson , Dmitry Malkin , Thomas Fitzsimmons , Peng Fan , Jaehoon Chung , Anatolij Gustschin , wahrenst@gmx.net, florian.fainelli@broadcom.com, u-boot@lists.denx.de Subject: Re: [PATCH v3 0/7] rpi5: initial support In-Reply-To: References: <20231218210341.30073-1-iivanov@suse.de> User-Agent: Roundcube Webmail/1.4.15 Message-ID: <1b435a7d04a9cd3a0d7c71c5b44f5e45@kernel.org> X-Sender: maz@kernel.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 217.182.43.188 X-SA-Exim-Rcpt-To: iivanov@suse.de, mbrugger@suse.com, pbrobinson@gmail.com, dmitry@bedrocksystems.com, fitzsim@fitzsim.org, peng.fan@nxp.com, jh80.chung@samsung.com, agust@denx.de, wahrenst@gmx.net, florian.fainelli@broadcom.com, u-boot@lists.denx.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2023-12-22 12:33, Ivan T. Ivanov wrote: > On 12-22 12:19, Marc Zyngier wrote: >> >> Hi Ivan, >> >> On 2023-12-18 21:03, Ivan T. Ivanov wrote: >> > Hi, >> > >> > These patches are adding basic support for RPi5. >> > They are based on v2 series from Dmitry Malkin[1]. >> > >> > With them I am able to _start_ current openSUSE >> > Tumbleweed without modification. They are still >> > a lot of things to be added to the upstream Linux >> > before it runs flawlessly on this device, but at >> > least in U-Booot SD controller used for uSD card >> > and Frameboffer and HDMI0 devices are working fine >> > now. It seems that PCIe controller is working fine >> > too, but I have not tested it too much. >> > >> > Serial console and reset are also functional. >> > >> > Hopefully this will help others add missing pieces >> > more easily. >> >> So I've given this a go, and the basics (serial) worked >> out of the box (thanks for that!) after performing the >> memory-map change you described in your reply to patch 1. >> >> However, I don't get anything on the PCIe front: >> >> U-Boot> pci enum >> PCIe BRCM: link down >> PCIe BRCM: link down >> >> despite having an nvme device connected and enabled >> (the RPi kernel finds it). >> >> I'm guessing I must be missing something. How did you >> test PCIe? >> > > No, you are not missing anything. I have not tested it > for real. That is why I said "it seems". Sorry. > > Yesterday I started looking more closely at what's missing > and unfortunately a lot more changes are needed. Ah, fair enough. I was slightly surprised that it appeared to be working out of the box, which would have been a first on the ARM side... Happy to test whatever patches you come up with! Thanks, M. -- Jazz is not dead. It just smells funny...