Re: [PATCH 0/2] dm: core: Add support for filling script_offset_f/script_size_f from DT

[Michal Simek <michal.simek@amd.com>]

On 8/3/23 15:36, Michal Simek wrote:
> Hi,
> 
> The commit https://github.com/devicetree-org/dt-schema/pull/105 added
> support for reading memory location where bootscript should be loaded.
> This is follow up series on reading information from DT where boot script
> is placed in flash memory.
> 
> Patches are based on
> https://lore.kernel.org/r/b37aec1460d93727a9065766aa5f50fa356ae5aa.1690873880.git.michal.simek@amd.com
> and
> https://lore.kernel.org/r/b77352af92102dfad2e12a49a7680f5f64f8ee31.1690873880.git.michal.simek@amd.com
> 
> I didn't send pull request to dt-schema yet because I want to check logic
> around it and DT variable names bootscr-flash-offset and bootscr-flash-size
> are correct.
> 
> Also there should be follow up patch to remove CONFIG_BOOT_SCRIPT_OFFSET
> Kconfig symbol and remove variable script_size_f setup from config file.
> 
> Also keep in mind that this is pretty much just 1:1 conversion between DT
> and variable. Upstream code is using it for QSPI only and we are also using
> in for NAND devices too. But the same approach could be used for DISKs,
> EEPROMs or SD RAW. That's why I pretty much think that DT description
> should be done a little bit differently.
> For example:
> bootscr-location = <&nvmem offset size>;
> 
> Thanks,
> Michal
> 
> 
> Michal Simek (2):
>    dm: core: ofnode: Add ofnode_read_bootscript_flash()
>    xilinx: board: Add support to pick bootscr flash offset/size from DT
> 
>   arch/sandbox/dts/test.dts   |  2 ++
>   board/xilinx/common/board.c | 13 +++++++++++--
>   drivers/core/ofnode.c       | 34 ++++++++++++++++++++++++++++++++++
>   include/dm/ofnode.h         | 27 +++++++++++++++++++++++++++
>   test/dm/ofnode.c            |  9 +++++++--
>   5 files changed, 81 insertions(+), 4 deletions(-)
> 

Applied.
M