From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Date: Wed, 15 Feb 2017 13:30:38 +0200 Subject: [U-Boot] [PATCH v2 1/6] arm: am57xx: reintroduce the CONFIG_AM57XX symbol In-Reply-To: <7c6cff82-ad8d-f506-09d7-9af8d4600bc8@ti.com> References: <1486985692-26625-1-git-send-email-uri.mashiach@compulab.co.il> <20170213132715.GX26129@bill-the-cat> <20170214192017.GL26129@bill-the-cat> <20170214201256.GM26129@bill-the-cat> <7c6cff82-ad8d-f506-09d7-9af8d4600bc8@ti.com> Message-ID: <1be76bec-6b5a-2cc0-590c-fab244829f9d@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 15/02/17 10:24, Roger Quadros wrote: > On 14/02/17 22:12, Tom Rini wrote: >> On Tue, Feb 14, 2017 at 01:26:24PM -0600, Nishanth Menon wrote: >>> On 02/14/2017 01:20 PM, Tom Rini wrote: >>>> On Tue, Feb 14, 2017 at 01:18:20PM -0600, menon.nishanth at gmail.com wrote: >>>>> On Mon, Feb 13, 2017 at 7:27 AM, Tom Rini wrote: >>>>>> On Mon, Feb 13, 2017 at 01:34:52PM +0200, Uri Mashiach wrote: >>>>>> >>>>>>> The SOC family symbol CONFIG_AM57XX was removed by the commit >>>>>>> 3891a54: "ARM: DRA7x/AM57xx: Get rid of CONFIG_AM57XX". >>>>>>> >>>>>>> The symbol is needed by the XHCI OMAP USB driver. >>>>>>> Without the symbol all the AM57x targets symbols should be ored in the >>>>>>> ifdef'ery. >>>>>>> >>>>>>> Signed-off-by: Uri Mashiach >>>>>> >>>>>> We need to introduce it into Kconfig files now, thanks! >>>>> >>>>> DRA7 and AM57xx are literally the same. the #ifdeffery in USB is more >>>>> to do which port to use rather than having anything to do with DRA7 Vs >>>>> AM57xx. >>>> >>>> Yes, agreed. And we need to solve this, and introduce some Kconfig >>>> CONFIG symbol to deal with it. Maybe the better way to look at this is, >>>> can we have DRA7xx boards configured in the way Uri wants to be able to >>>> configure the AM57xx board he's working with? And vice versa? The >>>> answer to that will help drive what the right CONFIG_xxx name is. >>> >>> Should'nt be ideally done via DM model instead? I have no >>> understanding of USB integration done in u-boot to comment better. >> >> That's also something that could be explored. >> > > Yes, ideally this should be taken care of by DM. > Till that migration is complete I'm fine with fixing this temporarily. > > OMAP5, DRA7, AM57 and AM43 use different XHCI_BASE address. > Just to clarify further on this DRA7 and AM57 are identical SoCs but the EVMs are using different instances of the USB as host so the difference in XHCI_BASE. DRA7-evm uses USB1 instance whereas AM57x-EVM uses USB0 instance as host. -- cheers, -roger