From: Eugen Hristev <eugen.hristev@collabora.com>
To: Ramon Fried <rfried.dev@gmail.com>
Cc: u-boot@lists.denx.de, joe.hershberger@ni.com, jonas@kwiboo.se,
jagan@edgeble.ai, kever.yang@rock-chips.com
Subject: Re: [PATCH 1/2] net: rtl8169: add minimal support for 8125B variant
Date: Tue, 25 Apr 2023 22:47:22 +0300 [thread overview]
Message-ID: <1c694822-e735-409e-eaf9-6b6414888e59@collabora.com> (raw)
In-Reply-To: <CAGi-RULO_dNrX1=9OgoyUjFzcf_2vqdqE=bvWk4vH8cpcTWe4A@mail.gmail.com>
On 4/25/23 22:22, Ramon Fried wrote:
> On Tue, Apr 25, 2023 at 4:17 PM Eugen Hristev
> <eugen.hristev@collabora.com> wrote:
>>
>> On 4/25/23 16:06, Eugen Hristev wrote:
>>> Add minimal support for 8125B version.
>>> Changes are based on the Linux driver.
>>> Tested on Radxa Rock 5B Rk3588 board.
>>>
>>> Connection to a laptop worked fine in 100 Mbps mode.
>>> 1000 Mbps mode is not working at the moment.
>>>
>>> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
>>> ---
>>
>> The one thing that impacts all the rtl chips is the way the pci BAR is
>> now mapped.
>> I could not test this on another platform so help on this matter is
>> appreciated.
>>
>> Thanks!
>> Eugen
> Let's wait a bit to see if someone can test it. why did you change the
> mapping of the BAR ?
It did not work with the old code. It provided a bad address, to some
area which did not have the right registers.
I looked into similar drivers and they were using this call, which works
perfectly for 8125b device
Eugen
next prev parent reply other threads:[~2023-04-25 19:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 13:06 [PATCH 1/2] net: rtl8169: add minimal support for 8125B variant Eugen Hristev
2023-04-25 13:06 ` [PATCH 2/2] configs: rock5b-rk3588: add rtl8169 driver Eugen Hristev
2023-05-05 22:03 ` Tom Rini
2023-05-15 12:36 ` Eugen Hristev
2023-05-15 12:52 ` Tom Rini
2023-05-15 12:57 ` Eugen Hristev
2023-05-15 13:16 ` Tom Rini
2023-05-17 10:46 ` Eugen Hristev
2023-07-21 9:51 ` Eugen Hristev
2023-05-18 1:03 ` Kever Yang
2023-04-25 13:17 ` [PATCH 1/2] net: rtl8169: add minimal support for 8125B variant Eugen Hristev
2023-04-25 19:22 ` Ramon Fried
2023-04-25 19:47 ` Eugen Hristev [this message]
2023-04-30 19:44 ` Ramon Fried
2023-05-17 10:54 ` Eugen Hristev
2023-05-06 14:54 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c694822-e735-409e-eaf9-6b6414888e59@collabora.com \
--to=eugen.hristev@collabora.com \
--cc=jagan@edgeble.ai \
--cc=joe.hershberger@ni.com \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=rfried.dev@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox