From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrice CHOTARD Date: Mon, 6 Aug 2018 07:30:22 +0000 Subject: [U-Boot] [U-Boot, v4, 9/9] ARM: dts: stm32: remove cd-inverted for stm32f746-disco In-Reply-To: <20180804233935.GR32145@bill-the-cat> References: <1532533752-15200-10-git-send-email-patrice.chotard@st.com> <20180804233935.GR32145@bill-the-cat> Message-ID: <1de7fe0e-1867-2e3c-e758-e571af3e5cc0@st.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom On 08/05/2018 01:39 AM, Tom Rini wrote: > On Wed, Jul 25, 2018 at 05:49:12PM +0200, Patrice Chotard wrote: > >> As cd-inverted property is no more used by arm_pl180_mmci driver, >> remove it. Update cd-gpios active level accordingly. >> >> Reported-by: Tuomas Tynkkynen >> Signed-off-by: Patrice Chotard >> --- >> >> Changes in v4: None >> Changes in v3: None >> Changes in v2: None >> >> arch/arm/dts/stm32f746-disco.dts | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/arch/arm/dts/stm32f746-disco.dts b/arch/arm/dts/stm32f746-disco.dts >> index e47f762e54dc..187c94b99bfa 100644 >> --- a/arch/arm/dts/stm32f746-disco.dts >> +++ b/arch/arm/dts/stm32f746-disco.dts >> @@ -307,8 +307,7 @@ >> >> &sdio { >> status = "okay"; >> - cd-gpios = <&gpioc 13 0>; >> - cd-inverted; >> + cd-gpios = <&gpioc 13 GPIO_ACTIVE_LOW>; >> pinctrl-names = "default", "opendrain"; >> pinctrl-0 = <&sdio_pins>; >> pinctrl-1 = <&sdio_pins_od>; > > So I can't apply this one as it breaks the build for stm32f746-disco as > dt-bindings/gpio/gpio.h isn't being included by this dts tree. Sorry, i will resend patches 8 and 9 with the correct fix. Patrice Thanks >